~dannf/charms/+source/scalebot-jenkins:config-rename

Branch merges

Propose for merging

Merged into ~ce-hyperscale/charms/+source/scalebot-jenkins:master at revision 83694acbc6e86881e3ecafc02e328dcf32bc0d6f

Sean Feole: Approve on 2017-10-16

Diff: 126 lines (+23/-21)

2 files modified

config.yaml (+6/-6)
reactive/scalebot-jenkins.py (+17/-15)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

83694ac... by dann frazier on 2017-10-12

Use the sample config repo as the default

3bd6a7b... by dann frazier on 2017-10-12

Rename lp_ssh_key to scalebot_private_ssh_key

Because our configs get combined with all of the configs in the sub layers,
let's keep all of our config names in the scalebot_* name space. This will
both avoid potential conflicts with configs in other layers, and also
highlight the scalebot-specific configs for the end user.

Also, add "private" to the name so it is obvious that this isn't the
public key.

Finally, the git repository shouldn't have to be on Launchpad, so drop
the "lp" bit. Note that the charm currently only preloads the server host
keys for Launchpad into the jenkins user's known_hosts file. To really
support non-LP-git+ssh repos, we'd need to add a new config to pass in
arbitrary host keys, or maybe a "Trust On First Use" mode.

7f65dab... by dann frazier on 2017-10-12

Rename scalebot_{repo,branch} to scalebot_config_{repo,branch}

Adding "config" to the name should help clarify what the repository contains.

bdba1b9... by dann frazier on 2017-10-12

Make lp_ssh_key config optional

An ssh key is only needed when your scalebot config repo has a git+ssh://
URI. If you're accessing a public repo anonymously (git://), you should
be able to leave this empty.

4ddd2a3... by dann frazier on 2017-09-29

Destroy the lab controller on charm stop hook

0f1b609... by dann frazier on 2017-09-29

Add empty default settings for config

Fixes the following warnings from 'charm build':

proof: W: config.yaml: option scalebot_juju_bootstrap_constraints does not have the keys: default
proof: W: config.yaml: option scalebot_repo does not have the keys: default
proof: W: config.yaml: option scalebot_juju_model_defaults does not have the keys: default
proof: W: config.yaml: option scalebot_juju_credentials does not have the keys: default
proof: W: config.yaml: option lp_ssh_key does not have the keys: default
proof: W: config.yaml: option scalebot_juju_clouds does not have the keys: default
proof: W: config.yaml: option scalebot_branch does not have the keys: default

5d8fd80... by dann frazier on 2017-09-29

metadata.yaml: add tags list

Fixes the following warning during charm build:

proof: W: Metadata missing required field "tags"

6ec1fdb... by dann frazier on 2017-09-27

Add links to referenced projects

6bdb582... by dann frazier on 2017-09-26

Add README.md

f178a11... by dann frazier on 2017-09-18

 Add config to allow passing in constraints for scalebot's juju controller