Merge ~danilogondolfo/ubuntu/+source/usbmuxd:create_user_preinst into ubuntu/+source/usbmuxd:ubuntu/devel

Proposed by Danilo Egea Gondolfo
Status: Merged
Merged at revision: 95b28857b4431193680937b21e35a2e22246cb07
Proposed branch: ~danilogondolfo/ubuntu/+source/usbmuxd:create_user_preinst
Merge into: ubuntu/+source/usbmuxd:ubuntu/devel
Diff against target: 38 lines (+14/-1)
2 files modified
debian/changelog (+12/-0)
debian/control (+2/-1)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior (community) Approve
git-ubuntu import Pending
Review via email: mp+450906@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Danilo.

Interesting issue. I was able to reproduce it locally and then confirm that your package fixes it.

My main concern was that sometimes we do things in postinst that depend on the package being installed, which means that we aren't able to simply rename the script to preinst and be done with it. But this doesn't seem to be the case.

I'm going ahead and uploading it now. Let's see what the archive admins will say.

Uploaded:

$ dput usbmuxd_1.1.1-3ubuntu1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/usbmuxd/usbmuxd_1.1.1-3ubuntu1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/usbmuxd/usbmuxd_1.1.1-3ubuntu1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading usbmuxd_1.1.1-3ubuntu1.dsc: done.
  Uploading usbmuxd_1.1.1-3ubuntu1.debian.tar.xz: done.
  Uploading usbmuxd_1.1.1-3ubuntu1_source.buildinfo: done.
  Uploading usbmuxd_1.1.1-3ubuntu1_source.changes: done.
Successfully uploaded packages.

review: Approve
Revision history for this message
Danilo Egea Gondolfo (danilogondolfo) wrote :

Thank you, Sergio ;)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 7e4f6fb..84399e3 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,15 @@
6+usbmuxd (1.1.1-3ubuntu1) mantic; urgency=medium
7+
8+ * Rename usbmuxd.postinst to usbmuxd.preinst (LP: #2034539)
9+ - Due to an issue with Netplan (LP#1999178), upgrades from Lunar to Mantic
10+ are suffering from long pauses. One of the observed causes is the fact
11+ that usbmuxd will install a udev rules file referring to a user that
12+ will only be created later in the upgrade process. While we work on the
13+ proper fix, turning the postinst script that created the user to a
14+ preinst will help working around this issue.
15+
16+ -- Danilo Egea Gondolfo <danilo.egea.gondolfo@canonical.com> Wed, 06 Sep 2023 12:22:35 +0100
17+
18 usbmuxd (1.1.1-3) unstable; urgency=medium
19
20 * Team upload.
21diff --git a/debian/control b/debian/control
22index e38b85e..2b3f270 100644
23--- a/debian/control
24+++ b/debian/control
25@@ -1,7 +1,8 @@
26 Source: usbmuxd
27 Section: utils
28 Priority: optional
29-Maintainer: gtkpod Maintainers <pkg-gtkpod-devel@alioth-lists.debian.net>
30+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
31+XSBC-Original-Maintainer: gtkpod Maintainers <pkg-gtkpod-devel@alioth-lists.debian.net>
32 Uploaders: Yves-Alexis Perez <corsac@debian.org>
33 Standards-Version: 4.5.0
34 Build-Depends: debhelper-compat (= 12),
35diff --git a/debian/usbmuxd.postinst b/debian/usbmuxd.preinst
36similarity index 100%
37rename from debian/usbmuxd.postinst
38rename to debian/usbmuxd.preinst

Subscribers

People subscribed via source and target branches