Merge ~danilogondolfo/ubuntu/+source/libdumbnet:fix_ftbfs into ubuntu/+source/libdumbnet:ubuntu/devel

Proposed by Danilo Egea Gondolfo
Status: Merged
Merged at revision: 3fbe526cc0638c18676bcea3ca7818352bc63bf7
Proposed branch: ~danilogondolfo/ubuntu/+source/libdumbnet:fix_ftbfs
Merge into: ubuntu/+source/libdumbnet:ubuntu/devel
Diff against target: 45 lines (+12/-3)
3 files modified
debian/changelog (+8/-0)
debian/control (+2/-1)
debian/libdumbnet1.symbols (+2/-2)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior (community) Approve
git-ubuntu import Pending
Review via email: mp+461632@code.launchpad.net

Description of the change

The functions strlcpy and strlcat were added to glibc 2.38 and is causing a FTBFS.

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

LGTM modulo one small nit on the changelog entry. Let me know when you fix it and I'll upload the package right away. Thanks!

review: Approve
Revision history for this message
Danilo Egea Gondolfo (danilogondolfo) wrote :

Done. Thank you, Sergio :)

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thank you!

Uploaded:

$ dput libdumbnet_1.17.0-1ubuntu1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/libdumbnet/libdumbnet_1.17.0-1ubuntu1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/libdumbnet/libdumbnet_1.17.0-1ubuntu1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading libdumbnet_1.17.0-1ubuntu1.dsc: done.
  Uploading libdumbnet_1.17.0-1ubuntu1.debian.tar.xz: done.
  Uploading libdumbnet_1.17.0-1ubuntu1_source.buildinfo: done.
  Uploading libdumbnet_1.17.0-1ubuntu1_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index df85168..64b1447 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+libdumbnet (1.17.0-1ubuntu1) noble; urgency=medium
7+
8+ * d/libdumbnet1.symbols: set symbols strlcpy/strlcat as optional
9+ (LP: #2055693). These symbols were added to glibc 2.38 and the
10+ package is FTBFS due to lintian.
11+
12+ -- Danilo Egea Gondolfo <danilo.egea.gondolfo@canonical.com> Thu, 29 Feb 2024 17:45:05 +0000
13+
14 libdumbnet (1.17.0-1) unstable; urgency=medium
15
16 * [f85ba27] New upstream version 1.17.0
17diff --git a/debian/control b/debian/control
18index e098393..c3b7ed3 100644
19--- a/debian/control
20+++ b/debian/control
21@@ -3,7 +3,8 @@ Section: libs
22 Priority: optional
23 Standards-Version: 4.6.2
24 Homepage: https://github.com/ofalk/libdnet
25-Maintainer: Florian Ernst <florian@debian.org>
26+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
27+XSBC-Original-Maintainer: Florian Ernst <florian@debian.org>
28 Build-Depends:
29 check,
30 debhelper-compat (= 13),
31diff --git a/debian/libdumbnet1.symbols b/debian/libdumbnet1.symbols
32index 9654f45..923606c 100644
33--- a/debian/libdumbnet1.symbols
34+++ b/debian/libdumbnet1.symbols
35@@ -93,8 +93,8 @@ libdumbnet.so.1 libdumbnet1 #MINVER#
36 route_get@Base 1.8
37 route_loop@Base 1.8
38 route_open@Base 1.8
39- strlcat@Base 1.8
40- strlcpy@Base 1.8
41+ (optional) strlcat@Base 1.8
42+ (optional) strlcpy@Base 1.8
43 tun_close@Base 1.11
44 tun_fileno@Base 1.11
45 tun_name@Base 1.11

Subscribers

People subscribed via source and target branches