Merge ~danilogondolfo/netplan/+git/ubuntu:kinetic_lp1997467_dbus into ~ubuntu-core-dev/netplan/+git/ubuntu:ubuntu-kinetic
Proposed by
Danilo Egea Gondolfo
Status: | Merged |
---|---|
Approved by: | Łukasz Zemczak |
Approved revision: | 2967b8afe84b00e5ec544a0d6ba608f0e1a4d3a6 |
Merged at revision: | 2967b8afe84b00e5ec544a0d6ba608f0e1a4d3a6 |
Proposed branch: | ~danilogondolfo/netplan/+git/ubuntu:kinetic_lp1997467_dbus |
Merge into: | ~ubuntu-core-dev/netplan/+git/ubuntu:ubuntu-kinetic |
Diff against target: |
222 lines (+194/-0) 4 files modified
debian/changelog (+13/-0) debian/patches/lp1997467/0009-dbus-Build-the-copy-path-correctly.patch (+93/-0) debian/patches/lp1997467/0010-tests-Add-an-integration-test-for-netplan-dbus.patch (+86/-0) debian/patches/series (+2/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Łukasz Zemczak | Approve | ||
Review via email:
|
To post a comment you must log in.
Update scan failed
At least one of the branches involved have failed to scan. You can manually schedule a rescan if required.
Looking good, will merge and release. Discussed with Danilo already that I didn't see the tests/integrati on/dbus. py test added as part of these changes. Not strictly required, but more testing is never a bad thing, even if it makes the diff bigger.
Anyway, let's proceed!