Merge lp:~danilo/po2xpi/firefox4-support into lp:po2xpi

Proposed by Данило Шеган
Status: Merged
Merge reported by: Chris Coulson
Merged at revision: not available
Proposed branch: lp:~danilo/po2xpi/firefox4-support
Merge into: lp:po2xpi
Diff against target: 78 lines (+10/-14)
3 files modified
src/process_lp_export (+1/-1)
src/rosetta_xpi_to_sources (+2/-1)
src/runpo2xpi (+7/-12)
To merge this branch: bzr merge lp:~danilo/po2xpi/firefox4-support
Reviewer Review Type Date Requested Status
Chris Coulson Approve
Review via email: mp+46309@code.launchpad.net

Description of the change

Support for Firefox 4.0 XPIs.

Changes only the shell script, we might want to rename it if we want it to be parallel runnable with the one for older Firefox.

To post a comment you must log in.
lp:~danilo/po2xpi/firefox4-support updated
56. By Данило Шеган

Generalize rosetta_xpi_to_sources a bit. It could still be improved.

Revision history for this message
Chris Coulson (chrisccoulson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/process_lp_export'
2--- src/process_lp_export 2010-01-21 01:34:00 +0000
3+++ src/process_lp_export 2011-01-14 22:51:23 +0000
4@@ -66,7 +66,7 @@
5 application=xulrunner-1.9
6 ;;
7 firefox)
8- application=firefox-3.0
9+ application=firefox-4.0
10 ;;
11 xulrunner-*)
12 application=$arg_TRANSLATION_DOMAIN
13
14=== modified file 'src/rosetta_xpi_to_sources'
15--- src/rosetta_xpi_to_sources 2010-01-21 01:34:38 +0000
16+++ src/rosetta_xpi_to_sources 2011-01-14 22:51:23 +0000
17@@ -31,7 +31,8 @@
18 exit 1
19 fi
20
21-PO2XPI_INSTALL_PATH=/home/asac/mozilla-rosetta/po2xpi/
22+dirname=`dirname $0`
23+PO2XPI_INSTALL_PATH=`cd $dirname/.. && pwd`
24 PO2XPI_INSTALL_DATA_BASE=$PO2XPI_INSTALL_PATH/data/
25 PO2XPI_INSTALL_DATA=$PO2XPI_INSTALL_DATA_BASE/8.04
26 PO2XPI_DEV_MODE=
27
28=== modified file 'src/runpo2xpi'
29--- src/runpo2xpi 2010-01-21 01:37:11 +0000
30+++ src/runpo2xpi 2011-01-14 22:51:23 +0000
31@@ -212,7 +212,7 @@
32 grep -v $APPLICATION_NAME-$LANGUAGE-chrome.manifest$ | \
33 grep -v chrome.manifest$ | \
34 grep -v \.jar$`; do
35- targetpath=../new/$LANGUAGE.xpi/`echo $notdtdorprop | sed -e 's/^.?xpi\///' | sed -e "s/en-US\.jar/$LANGUAGE.jar/
36+ targetpath=../new/$LANGUAGE.xpi/`echo $notdtdorprop | sed -e 's/^.?xpi\///' | sed -e "s/en-US/$LANGUAGE/
37 s/en-US/$LANGUAGE/g"`
38 echo TAREGETPATH: $targetpath
39 if ! test -d `dirname $targetpath`; then
40@@ -225,7 +225,7 @@
41 _IFS=$IFS
42 IFS='
43 '
44- targetpath=../new/$LANGUAGE.xpi/`echo $dtdfile | sed -e 's/^.?xpi\///' | sed -e "s/en-US\.jar/$LANGUAGE.jar/
45+ targetpath=../new/$LANGUAGE.xpi/`echo $dtdfile | sed -e 's/^.?xpi\///' | sed -e "s/en-US/$LANGUAGE/
46 s/en-US/$LANGUAGE/g"`
47 for entityline in `grep ENTITY.*%.*SYSTEM $dtdfile`; do
48 old_IFS=$IFS
49@@ -245,7 +245,7 @@
50 done
51 IFS=$_IFS
52 done
53- $SED "s/en-US\.jar/$APPLICATION_NAME-$LANGUAGE.jar/
54+ $SED "s/en-US/$LANGUAGE/
55 s/en-US/$LANGUAGE/g" chrome.manifest >../new/chrome.manifest
56 $SED "s/en-US/$LANGUAGE/g" install.rdf >../new/install.rdf
57 cd ..
58@@ -273,17 +273,12 @@
59 # argument 1 - APPLICATION_NAME
60 jar_up() {
61 cd new
62- local JARDIR=`$GREP -m1 "#:" ../$FILENAME | $CUT -d " " -f 2 | $CUT -d '!' -f 1`
63- local JARPATH=`$REVPATH $JARDIR`
64- local DELPATH=`echo $JARDIR | cut -d '/' -f 1`
65 local APPLICATION_NAME=$1
66
67- cd "$JARDIR!"
68- $ZIP -9r $JARPATH/$APPLICATION_NAME-$LANGUAGE.jar locale > /dev/null
69- cd $JARPATH
70- $RM -Rf $DELPATH
71- $ZIP -9 $LANGUAGE.xpi chrome.manifest $APPLICATION_NAME-$LANGUAGE.jar install.rdf &>/dev/null
72- $RM chrome.manifest $APPLICATION_NAME-$LANGUAGE.jar install.rdf
73+ # Ensure $LANGUAGE.xpi is not in the way even when RM is set to "echo".
74+ rm -rf $LANGUAGE.xpi
75+ $ZIP -r9 $LANGUAGE.xpi chrome.manifest chrome install.rdf #&>/dev/null
76+ $RM -rf chrome.manifest chrome install.rdf
77 cd ..
78 }
79

Subscribers

People subscribed via source and target branches