Code review comment for lp:~danilo/maas/django-upgrade-legacy-migrations

Revision history for this message
Данило Шеган (danilo) wrote :

import_settings(settings) will actually set it. I am not too happy with how the code works and looks, but import_settings() imports the stuff from a passed-in module into the global namespace: that's where we get INSTALLED_APPS from.

FWIW, as the comment indicates, INSTALLED_APPS is set to None just to avoid lint warnings when it's modified or accessed later on in the file.

Also, note that I have run the tests in both 1.8 and 1.11 about a gazillion times in each of my django 1.11 branches, and I never submit them before they are an improvement in 1.11 (as in a reduced count of test failures), and pass completely with 1.8.

« Back to merge proposal