Merge lp:~danilo/linaro-license-protection/openid-enablement into lp:~linaro-automation/linaro-license-protection/trunk

Proposed by Данило Шеган
Status: Merged
Approved by: Stevan Radaković
Approved revision: 104
Merged at revision: 104
Proposed branch: lp:~danilo/linaro-license-protection/openid-enablement
Merge into: lp:~linaro-automation/linaro-license-protection/trunk
Diff against target: 70 lines (+15/-13)
2 files modified
settings.py (+10/-8)
urls.py (+5/-5)
To merge this branch: bzr merge lp:~danilo/linaro-license-protection/openid-enablement
Reviewer Review Type Date Requested Status
Stevan Radaković Approve
Review via email: mp+120080@code.launchpad.net

Description of the change

Change OpenID configuration so it can easily coexist with apache openid
protection.

To post a comment you must log in.
Revision history for this message
Stevan Radaković (stevanr) wrote :

Good work, thanks.
Approve +1.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'settings.py'
2--- settings.py 2012-08-01 13:46:32 +0000
3+++ settings.py 2012-08-17 08:39:19 +0000
4@@ -96,7 +96,9 @@
5
6 ROOT_URLCONF = ROOT_DIR + '.urls'
7
8-TEMPLATE_DIRS = (os.path.join(PROJECT_ROOT, "templates" ),)
9+TEMPLATE_DIRS = (
10+ os.path.join(PROJECT_ROOT, "templates" ),
11+ )
12
13 INSTALLED_APPS = (
14 'django.contrib.auth',
15@@ -105,11 +107,8 @@
16 'django.contrib.sites',
17 'django.contrib.messages',
18 'django.contrib.staticfiles',
19- # Uncomment the next line to enable the admin:
20 'django.contrib.admin',
21 'django_openid_auth',
22- # Uncomment the next line to enable admin documentation:
23- # 'django.contrib.admindocs',
24 ROOT_DIR + '.license_protected_downloads',
25 )
26
27@@ -118,13 +117,16 @@
28 'django.contrib.auth.backends.ModelBackend',
29 )
30
31-LOGIN_URL = '/openid/login/'
32+LOGIN_URL = '/linaro-openid/login/'
33+LOGIN_REDIRECT_URL = '/'
34
35 OPENID_CREATE_USERS = True
36 OPENID_SSO_SERVER_URL = 'https://login.launchpad.net/'
37-OPENID_LAUNCHPAD_TEAMS_MAPPING = {
38- 'linaro': 'linaro',
39-}
40+OPENID_UPDATE_DETAILS_FROM_SREG = True
41+OPENID_LAUNCHPAD_TEAMS_MAPPING_AUTO = True
42+OPENID_FOLLOW_RENAMES = True
43+OPENID_USE_AS_ADMIN_LOGIN = True
44+OPENID_USE_EMAIL_FOR_USERNAME = True
45
46 # A sample logging configuration. The only tangible logging
47 # performed by this configuration is to send an email to
48
49=== modified file 'urls.py'
50--- urls.py 2012-07-11 13:08:55 +0000
51+++ urls.py 2012-08-17 08:39:19 +0000
52@@ -6,13 +6,13 @@
53
54
55 urlpatterns = patterns('',
56- # Uncomment the admin/doc line below to enable admin documentation:
57- url(r'^admin/doc/', include('django.contrib.admindocs.urls')),
58-
59- # Uncomment the next line to enable the admin:
60 url(r'^admin/', include(admin.site.urls)),
61
62- url(r'^openid/', include('django_openid_auth.urls')),
63+ # Use "linaro-openid" to allow peaceful coexistence of both
64+ # python-apache-openid and django-openid authentication on the
65+ # same server. When we get rid of apache openid protection,
66+ # we can go back to using just "openid" here.
67+ url(r'^linaro-openid/', include('django_openid_auth.urls')),
68 url(r'^logout/$', 'django.contrib.auth.views.logout'),
69
70 # The license page...

Subscribers

People subscribed via source and target branches