Merge lp:~danilo/launchpad/remove-primary-duplicate-reason into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Данило Шеган |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12887 |
Proposed branch: | lp:~danilo/launchpad/remove-primary-duplicate-reason |
Merge into: | lp:launchpad |
Diff against target: |
142 lines (+21/-31) 2 files modified
lib/lp/bugs/model/personsubscriptioninfo.py (+13/-11) lib/lp/bugs/model/tests/test_personsubscriptioninfo.py (+8/-20) |
To merge this branch: | bzr merge lp:~danilo/launchpad/remove-primary-duplicate-reason |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | code | Approve | |
Review via email: mp+57839@code.launchpad.net |
Commit message
[r=adeuring][bug=761596] Stop treating bug duplication as symmetric for the purposes of bug subscription descriptions. It's not.
Description of the change
= Remove symmetric handling of duplicates =
Atm, the code assumes that bug duplication is a symmetric process as far as email notifications go. Since that's not the case (I double-checked that), we need to stop treating it as such.
== Implementation details ==
Remove the bug join condition that fetches the primary bug for a duplicate. The condition list was Or()d together.
The test has been updated to confirm this is the case.
Lint fixes in a separate commit, getting pushed after review :)
== Tests ==
bin/test -cvvt PersonSubscript
== Demo and Q/A ==
1. Turn on 'malone.
2. Mark a bug https:/
3. Subscribe to bug 5
4. Make sure the https:/
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
./lib/lp/
119: E501 line too long (80 characters)
257: E301 expected 1 blank line, found 0
267: E301 expected 1 blank line, found 0
274: E301 expected 1 blank line, found 0
305: E202 whitespace before ')'
313: E202 whitespace before ')'
119: Line exceeds 78 characters.
./lib/lp/
12: 'searchbuilder' imported but unused
29: 'anonymous_
8: 'Store' imported but unused
16: 'BugTaskStatus' imported but unused
10: 'ProxyFactory' imported but unused
9: 'Unauthorized' imported but unused
16: 'BugTaskImportance' imported but unused
29: 'login_person' imported but unused
26: 'BugSubscriptio
13: 'IStore' imported but unused
37: E302 expected 2 blank lines, found 1