Merge lp:~danilo/launchpad/merge-ss-with-filters-urls into lp:launchpad/db-devel
Status: | Work in progress |
---|---|
Proposed branch: | lp:~danilo/launchpad/merge-ss-with-filters-urls |
Merge into: | lp:launchpad/db-devel |
Diff against target: |
393 lines (+117/-38) 9 files modified
lib/lp/bugs/browser/configure.zcml (+1/-1) lib/lp/bugs/browser/structuralsubscription.py (+1/-4) lib/lp/bugs/browser/tests/test_bugsubscriptionfilter.py (+2/-1) lib/lp/bugs/browser/tests/test_structuralsubscription.py (+47/-12) lib/lp/bugs/interfaces/structuralsubscription.py (+9/-6) lib/lp/bugs/model/structuralsubscription.py (+11/-1) lib/lp/bugs/tests/test_structuralsubscriptiontarget.py (+27/-0) lib/lp/registry/stories/person/xx-person-subscriptions.txt (+2/-2) lib/lp/registry/stories/webservice/xx-structuralsubscription.txt (+17/-11) |
To merge this branch: | bzr merge lp:~danilo/launchpad/merge-ss-with-filters-urls |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+47403@code.launchpad.net |
Commit message
[r=gmb]
Description of the change
= Make StructuralSubsc
In accordance with our higher-level goal of having multiple structural subscription per-target, per-person, we need to have a URL for structural subscriptions that is not limited to one per person.
At the moment, canonical_url for a SS is /<target>
== Pre-implementation notes ==
I discussed with Gary the option of putting all SSs on a top-level StructuralSubsc
== Implementation details ==
I provided a getSubscriptionByID on IStructuralSubs
== Tests ==
bin/test -cvvt structuralsubsc
== Demo and Q/A ==
Check that structural subscriptions appear on appropriate links on QA staging.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
Just one minor change needed, which we discussed on IRC:
[13:57] gmb: ubscriptionTarg etAPI are a bit ambiguous - enough so that a reader would need to find their definition to find out what they are, anyway. I think that self.subscripti on_target and .ws_subscriptio n_target would be better names. What do you think?
danilo: self.structure and self.ws_structure in TestStructuralS
[13:57] danilos:
gmb, agreed!