Merge lp:~danilo/launchpad/db-bug-718809 into lp:launchpad/db-devel

Proposed by Данило Шеган
Status: Merged
Approved by: Данило Шеган
Approved revision: no longer in the source branch.
Merged at revision: 10208
Proposed branch: lp:~danilo/launchpad/db-bug-718809
Merge into: lp:launchpad/db-devel
Diff against target: 10 lines (+6/-0)
1 file modified
database/schema/patch-2208-44-0.sql (+6/-0)
To merge this branch: bzr merge lp:~danilo/launchpad/db-bug-718809
Reviewer Review Type Date Requested Status
Stuart Bishop db Approve
Review via email: mp+49952@code.launchpad.net

Commit message

[incr] [r=stub][bug=718809] Change DB default for PersonSettings.selfgenerated_bugnotifications to False.

Description of the change

= Bug 718809: DB patch =

This is just a DB patch to finish off https://code.launchpad.net/~danilo/launchpad/bug-718809/+merge/49950

== Implementation notes ==

Sample data in current.sql seems to be out of date, but it's definitely not due to my branch, and I'd only fix that right before the landing.

Sample data in current-dev.sql might be out of date due to me playing around, but I don't want to wait for 'make schema' to confirm, especially since the test sampledata should not be affected by that.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  database/schema/patch-2208-99-0.sql

== Schema ==

database/sampledata/current.sql
    database/sampledata/lintdata.sql differs from database/sampledata/current.sql.
    Patches to the schema, or manual edits to database/sampledata/current.sql
    do not match the dump of the launchpad_ftest_template database.
    If database/sampledata/lintdata.sql is correct, copy it to
    database/sampledata/current.sql.
    Otherwise update database/sampledata/current.sql and run:
        make schema
        make newsampledata
        cd database/sampledata
        cp newsampledata.sql database/sampledata/current.sql
    Run make schema again to update the test/dev database.

database/sampledata/current.sql
    database/sampledata/lintdata-dev.sql differs from database/sampledata/current-dev.sql.
    Patches to the schema, or manual edits to database/sampledata/current-dev.sql
    do not match the dump of the launchpad_dev_template database.
    If database/sampledata/lintdata-dev.sql is correct, copy it to
    database/sampledata/current-dev.sql.
    Otherwise update database/sampledata/current-dev.sql and run:
        make schema
        make newsampledata
        cd database/sampledata
        cp newsampledata-dev.sql database/sampledata/current-dev.sql
    Run make schema again to update the test/dev database.

To post a comment you must log in.
Stuart Bishop (stub) wrote :

Fine. patch-2208-44-0.sql

From IRC, we don't alter existing users settings as we want them to keep the existing behavior unless they change the setting, where as new users will no longer get selfgenerated bugnotifications using this new feature.

review: Approve (db)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'database/schema/patch-2208-44-0.sql'
2--- database/schema/patch-2208-44-0.sql 1970-01-01 00:00:00 +0000
3+++ database/schema/patch-2208-44-0.sql 2011-02-16 12:03:16 +0000
4@@ -0,0 +1,6 @@
5+SET client_min_messages=ERROR;
6+
7+ALTER TABLE PersonSettings
8+ ALTER COLUMN selfgenerated_bugnotifications SET DEFAULT FALSE;
9+
10+INSERT INTO LaunchpadDatabaseRevision VALUES (2208, 44, 0);

Subscribers

People subscribed via source and target branches

to status/vote changes: