Merge lp:~danilo/launchpad/bug-820511 into lp:launchpad
Proposed by
Данило Шеган
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Данило Шеган | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 13679 | ||||
Proposed branch: | lp:~danilo/launchpad/bug-820511 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
188 lines (+42/-19) 7 files modified
lib/lp/code/scripts/tests/test_create_merge_proposals.py (+3/-2) lib/lp/code/scripts/tests/test_merge_proposal_jobs.py (+3/-1) lib/lp/code/scripts/tests/test_reclaim_branch_space.py (+3/-1) lib/lp/code/scripts/tests/test_sendbranchmail.py (+6/-4) lib/lp/services/job/runner.py (+13/-4) lib/lp/services/job/tests/test_runner.py (+12/-7) lib/lp/translations/scripts/tests/test_packaging_translations.py (+2/-0) |
||||
To merge this branch: | bzr merge lp:~danilo/launchpad/bug-820511 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
j.c.sackett (community) | Approve | ||
Review via email: mp+71179@code.launchpad.net |
Commit message
[r=jcsackett][bug=820511] Log Job IDs on INFO level when running jobs to ease debugging efforts when things go wrong.
Description of the change
= Bug 820511 =
Log the job ID and class name on the INFO level in the runner.
== Tests ==
bin/test -cvvt test_runner
== Demo and Q/A ==
Run any jobs (eg. cronscripts/
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
To post a comment you must log in.
This looks good. It'll certainly be easier to debug jobs this way.
One question, though.
> 18 @@ -262,7 +265,8 @@ info('Job resulted in OOPS: %s' % oops_id) info('Job resulted in OOPS: %s' % ( ids.append( oops_id)
> 19 def _logOopsId(self, oops_id):
> 20 """Report oopses by id to the log."""
> 21 if self.logger is not None:
> 22 - self.logger.
> 23 + self.logger.
> 24 + oops_id))
> 25 self.oops_
I'm not sure I see the need for this change; it doesn't look like the line was over the character limit, and functionally the two are identical, aren't they?
Given that I think they're identical, this doesn't block approval, I'm just curious what the intent was.