Merge lp:~danilo/launchpad/bug-772763-remove-nothing into lp:launchpad/db-devel
Status: | Merged |
---|---|
Approved by: | Данило Шеган |
Approved revision: | no longer in the source branch. |
Merged at revision: | 10563 |
Proposed branch: | lp:~danilo/launchpad/bug-772763-remove-nothing |
Merge into: | lp:launchpad/db-devel |
Prerequisite: | lp:~danilo/launchpad/proper-bug-muting |
Diff against target: |
578 lines (+52/-188) 15 files modified
lib/lp/bugs/browser/bugsubscription.py (+4/-12) lib/lp/bugs/browser/bugsubscriptionfilter.py (+8/-19) lib/lp/bugs/browser/tests/test_bug_context_menu.py (+2/-1) lib/lp/bugs/browser/tests/test_bugsubscription_views.py (+1/-79) lib/lp/bugs/browser/tests/test_bugsubscriptionfilter.py (+3/-39) lib/lp/bugs/enum.py (+0/-11) lib/lp/bugs/interfaces/bug.py (+1/-2) lib/lp/bugs/model/bug.py (+3/-3) lib/lp/bugs/model/personsubscriptioninfo.py (+16/-6) lib/lp/bugs/model/tests/test_bug.py (+4/-4) lib/lp/bugs/model/tests/test_bugsubscriptioninfo.py (+2/-2) lib/lp/bugs/model/tests/test_personsubscriptioninfo.py (+1/-3) lib/lp/bugs/stories/webservice/xx-bug.txt (+2/-2) lib/lp/bugs/tests/test_bug.py (+2/-2) lib/lp/bugs/tests/test_structuralsubscription.py (+3/-3) |
To merge this branch: | bzr merge lp:~danilo/launchpad/bug-772763-remove-nothing |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stuart Bishop (community) | Abstain | ||
Graham Binns (community) | code | Approve | |
Review via email: mp+61251@code.launchpad.net |
Commit message
[r=gmb][bug=772763][incr] Remove BugNotification
Description of the change
= Bug 772763: Remove BugNotification
Remove BugNotification
In a few tests, I had to replace the old call (used to be compatible with bug.mute()) bug.subscribe(..., level=NOTHING) with the appropriate bug.mute(...) call.
Most of the code is simplified with this removal.
I didn't fix lint issues in xx-bug.txt because it simply has too many of them.
== Tests ==
bin/test -cvvm lp.bugs
== Demo and Q/A ==
Go to a bug page and play with muting/unmuting a bug.
You'll need to turn the malone.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
database/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
database/
lib/lp/
database/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
13: source has bad indentation.
53: want exceeds 78 characters.
61: source has bad indentation.
67: source has bad indentation.
74: source has bad indentation.
165: source has bad indentation.
170: source exceeds 78 characters.
176: source exceeds 78 characters.
182: source has bad indentation.
194: source has bad indentation.
205: source has bad indentation.
211: source has bad indentation.
221: source has bad indentation.
232: source has bad indentation.
250: source has bad indentation.
253: source has bad indentation.
260: source has bad indentation.
265: source exceeds 78 characters.
265: source has bad indentation.
271: source has bad indentation.
281: source has bad indentation.
292: source has bad indentation.
301: source has bad indentation.
316: source has bad indentation.
322: source has bad indentation.
349: want exceeds 78 characters.
354: source has bad indentation.
359: source has bad indentation.
364: source has bad indentation.
370: source has bad indentation.
374: source has bad indentation.
378: source has bad indentation.
385: source has bad indentation.
389: source has bad indentation.
395: source has bad indentation.
398: source has bad indentation.
402: source has bad indentation.
408: source has bad indentation.
414: source has bad indentation.
418: source has bad indentation.
426: source has bad indentation.
429: source has bad indentation.
434: source has bad indentation.
440: source has bad indentation.
446: source has bad indentation.
452: source has bad indentation.
460: source has bad indentation.
473: source has bad indentation.
482: source has bad indentation.
492: source has bad indentation.
502: source has bad indentation.
512: source has bad indentation.
523: source has bad indentation.
549: source has bad indentation.
559: source has bad indentation.
568: source has bad indentation.
578: source has bad indentation.
827: source has bad indentation.
851: source has bad indentation.
863: source exceeds 78 characters.
863: source has bad indentation.
1057: source has bad indentation.
1062: source has bad indentation.
1066: source has bad indentation.
1085: source has bad indentation.
1091: source has bad indentation.
1096: source has bad indentation.
1099: source has bad indentation.
1103: source has bad indentation.
1109: source has bad indentation.
1122: source has bad indentation.
1136: source has bad indentation.
1160: source has bad indentation.
1162: source has bad indentation.
1175: want exceeds 78 characters.
1180: source has bad indentation.
1201: source has bad indentation.
1212: source has bad indentation.
1217: want exceeds 78 characters.
1253: source has bad indentation.
1263: source has bad indentation.
1276: source has bad indentation.
1295: source has bad indentation.
1309: source has bad indentation.
1317: source has bad indentation.
1319: source has bad indentation.
1326: source has bad indentation.
1329: source has bad indentation.
1332: source has bad indentation.
1338: source has bad indentation.
1340: want exceeds 78 characters.
1353: source has bad indentation.
1364: source has bad indentation.
1370: source has bad indentation.
1382: source has bad indentation.
1388: source has bad indentation.
1391: want exceeds 78 characters.
1646: source exceeds 78 characters.
2019: source exceeds 78 characters.
2079: narrative exceeds 78 characters.
2124: source has bad indentation.
2135: source has bad indentation.
./lib/lp/
3849: local variable 'karma_total' is assigned to but never used
Stuart, no need for you to review this branch, lp-propose added you automatically because a pre-requisite branch has a DB patch I guess.