Merge lp:~danilo/launchpad/bug-720826-links into lp:launchpad/db-devel
Status: | Merged |
---|---|
Approved by: | Данило Шеган |
Approved revision: | no longer in the source branch. |
Merged at revision: | 10265 |
Proposed branch: | lp:~danilo/launchpad/bug-720826-links |
Merge into: | lp:launchpad/db-devel |
Prerequisite: | lp:~danilo/launchpad/bug-720826-emails |
Diff against target: |
153 lines (+39/-6) 5 files modified
lib/lp/bugs/configure.zcml (+4/-0) lib/lp/bugs/doc/bugnotification-sending.txt (+9/-3) lib/lp/bugs/mail/bugnotificationrecipients.py (+11/-0) lib/lp/bugs/model/bugnotification.py (+11/-0) lib/lp/bugs/model/structuralsubscription.py (+4/-3) |
To merge this branch: | bzr merge lp:~danilo/launchpad/bug-720826-links |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gary Poster (community) | Approve | ||
Review via email: mp+52226@code.launchpad.net |
Commit message
[r=gary][bug=720826] Populate BugNotification
Description of the change
= Bug 720826 =
This finally ties everything up together: we start adding links to
subscription filters that have caused a certain BugNotification to
go off.
Previously, framework for this was provided, and if these links were
there, appropriate email headers and content was added to outgoing
emails.
== Proposed fix ==
* Extend BugNotification
along with recipients and reasons they are getting emails
* Find out what those filters are and add them to the `recipients`
in structuralsubsc
* In BugNotification
linking rows for all the filters present in `recipients`.
== Implementation details ==
BugNotification
I am only providing the integration test in bugnotification
== Tests ==
bin/test -cvvt bugnotification
== Demo and Q/A ==
Add a few subscription filters, and run "cronscripts/
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
132: E202 whitespace before ']'
./lib/lp/
433: want has trailing whitespace.
451: want has trailing whitespace.
Let's remove the distinct=True in the structural subscription code, as we discussed on IRC. It might have made some sense when we were not getting a result per filter, but does not now.
I asked for a test showing multiple filters and you said they existed in unit tests. I'm mostly OK with that as being sufficient here. :-)
Yay, thank you!