Merge lp:~danilo/launchpad/bug-720826-emails into lp:launchpad/db-devel
Status: | Merged |
---|---|
Approved by: | Graham Binns |
Approved revision: | no longer in the source branch. |
Merged at revision: | 10254 |
Proposed branch: | lp:~danilo/launchpad/bug-720826-emails |
Merge into: | lp:launchpad/db-devel |
Prerequisite: | lp:~danilo/launchpad/bug-720826 |
Diff against target: |
393 lines (+266/-11) 6 files modified
lib/lp/bugs/emailtemplates/bug-notification-verbose.txt (+1/-1) lib/lp/bugs/emailtemplates/bug-notification.txt (+1/-1) lib/lp/bugs/mail/bugnotificationbuilder.py (+6/-1) lib/lp/bugs/mail/tests/test_bugnotificationbuilder.py (+51/-0) lib/lp/bugs/scripts/bugnotification.py (+21/-6) lib/lp/bugs/scripts/tests/test_bugnotification.py (+186/-2) |
To merge this branch: | bzr merge lp:~danilo/launchpad/bug-720826-emails |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+51747@code.launchpad.net |
Commit message
[r=gmb][bug=720826][incr] Add headers/content describing filters that have caused an email notification to go off. Part of bug 720826 fix.
Description of the change
= Bug 720826: modify emails =
This is a part of work on 720826: adding headers and email body content
describing bug subscription filters which have caused that email to go off.
This branch adds the actual headers based on the BugNotification
table linking BugNotifications with BugSubscription
== Proposed fix ==
* BugNotification
* scripts/
== Implementation details ==
I'm also moving bug-notificatio
Rest of the bits are mostly lint fixes.
== Tests ==
bin/test -cvvt TestEmailNotifi
== Demo and Q/A ==
no-qa on it's own (as illustrated by tests, appropriate records do not get created automatically yet)
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
3: Line has trailing whitespace.
./lib/lp/
3: Line has trailing whitespace.