Merge lp:~danilo/launchpad/bug-718809 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Данило Шеган |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12399 |
Proposed branch: | lp:~danilo/launchpad/bug-718809 |
Merge into: | lp:launchpad |
Diff against target: |
166 lines (+35/-19) 8 files modified
lib/lp/bugs/doc/bugnotification-sending.txt (+14/-9) lib/lp/bugs/scripts/tests/test_bugnotification.py (+0/-4) lib/lp/bugs/tests/test_bugchanges.py (+3/-1) lib/lp/registry/interfaces/person.py (+1/-1) lib/lp/registry/model/person.py (+1/-1) lib/lp/registry/stories/person/xx-person-edit.txt (+2/-2) lib/lp/registry/tests/test_person.py (+6/-0) lib/lp/testing/factory.py (+8/-1) |
To merge this branch: | bzr merge lp:~danilo/launchpad/bug-718809 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Aaron Bentley (community) | Approve | ||
Review via email: mp+49950@code.launchpad.net |
Commit message
[r=abentley][bug=718809] For new users, default to not receiving self-generated bug mail.
Description of the change
= Bug 718809 =
Default to not receiving self-generated bug mail for new users.
== Proposed fix ==
Change interface and model column definitions, which basically changes the default. A separate branch (lp:~danilo/launchpad/db-bug-718809) will change the DB default, but that's mostly to avoid any confusion.
== Implementation details ==
I am sure many other tests which create Persons inline will start failing now, so I'll have to go and fix those as well. I am hoping the simple change to a call to makePerson will be sufficient.
Lint warning is because of a comment preceding class definition, number of blank lines is correct.
== Tests ==
bin/test -cvvt bugnotification
== Demo and Q/A ==
Register a new account and make sure the checkbox for "Send me bug notifications for changes I make" on https:/
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
604: E302 expected 2 blank lines, found 1
FWIW, no more test failures in lp.bugs module.