Merge lp:~danilo/launchpad/bug-580345-devel into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Данило Шеган | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 10894 | ||||
Proposed branch: | lp:~danilo/launchpad/bug-580345-devel | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
117 lines (+40/-7) 2 files modified
lib/canonical/buildd/generate-translation-templates (+17/-7) lib/canonical/buildd/pottery/generate_translation_templates.py (+23/-0) |
||||
To merge this branch: | bzr merge lp:~danilo/launchpad/bug-580345-devel | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Henning Eggers (community) | code | Approve | |
Review via email: mp+25597@code.launchpad.net |
Commit message
Add more logging to generate-
Description of the change
= Bug 580345 =
At the moment, we have very terse build job debug output. Considering how build farm (or at least translation jobs on it) works in such a way that we lose the log after a job completes, we should at least have an option of better output during build time (which we can track on launchpad.
After this branch lands, we need to prepare another canonical-buildd package and roll it out to build slaves (only LaMont can do it).
== Tests ==
bin/test -vvct translationtemp
== QA ==
QAd on dogfood (rubidium slave) by following https:/
Thanks for adding this!
<henninge> danilos: wasn't there some problem with 'debug_exec', too? CHROOT/ usr/bin/ python --version"
<danilos> henninge, it's fixed (original branch was against production-devel, but that doesn't make any difference for build slaves)
<danilos> henninge, I had a bashism ("function debug_func {" instead of "debug_func()" which works everywhere)
* deryck hat die Verbindung getrennt (Quit: Leaving)
<henninge> danilos: ah yes, I see.
<henninge> danilos: the python --version is pretty useless, though.
<henninge> danilos: you should use the python in the chroot. This script is still running outside of it.
<danilos> henninge, I know, but can't do that in the shell script :)
<henninge> not?
<danilos> henninge, well, chroot would first have to be set-up and that happens only at the end
<henninge> danilos: but python works from almost anywhere.
<henninge> let me try that ... ;)
<henninge> danilos: yup, works. Just do "$BUILD_
<danilos> henninge, sure