Merge lp:~danilo/launchpad/bug-487601 into lp:launchpad/db-devel

Proposed by Данило Шеган
Status: Merged
Approved by: Данило Шеган
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~danilo/launchpad/bug-487601
Merge into: lp:launchpad/db-devel
Diff against target: 29 lines (+10/-9)
1 file modified
lib/lp/translations/templates/object-templates.pt (+10/-9)
To merge this branch: bzr merge lp:~danilo/launchpad/bug-487601
Reviewer Review Type Date Requested Status
Māris Fogels (community) Approve
Review via email: mp+15210@code.launchpad.net

Commit message

Fix up JS for templates so the windmill test passes.

To post a comment you must log in.
Revision history for this message
Данило Шеган (danilo) wrote :

= Bug #487601 =

Fix broken JS so the failing test passes: just s/template_table/templates_table/ and setting event on the correct object: TR.template_row vs. div.template_links (as it was before YUI3 migration: r8693).

= Tests =

bin/test --layer=TranslationsWindmillLayer -vvt productseries_templates

= Demo & QA =

https://translations.launchpad.dev/evolution/trunk/+templates
https://translations.staging.launchpad.net/openobject-addons/trunk/+templates

Revision history for this message
Māris Fogels (mars) wrote :

Hi Danilo,

Looks good to me, r=mars.

Maris

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/translations/templates/object-templates.pt'
2--- lib/lp/translations/templates/object-templates.pt 2009-11-24 06:08:55 +0000
3+++ lib/lp/translations/templates/object-templates.pt 2009-11-24 19:33:13 +0000
4@@ -38,15 +38,16 @@
5 YUI().use('node-base', 'event-delegate', function(Y) {
6 Y.on('domready', function(e) {
7 Y.all('#templates_table .template_links').addClass(
8- 'inactive_links');
9-
10- Y.delegate('mouseover', function(e) {
11- this.removeClass('inactive_links');
12- }, '#templates_table tbody', '.template_links');
13-
14- Y.delegate('mouseout', function(e) {
15- this.addClass('inactive_links');
16- }, '#templates_table tbody', '.template_links');
17+ 'inactive_links');
18+ Y.all('#templates_table .template_row').each(function(row) {
19+ var template_links = row.one('.template_links');
20+ row.on('mouseover', function(e) {
21+ template_links.removeClass('inactive_links');
22+ });
23+ row.on('mouseout', function(e) {
24+ template_links.addClass('inactive_links');
25+ });
26+ });
27 });
28 });
29 </script>

Subscribers

People subscribed via source and target branches

to status/vote changes: