Merge lp:~danilo/launchpad/bug-474874 into lp:launchpad

[Данило Шеган]

[Данило Шеган (danilo)]

= Bug 474874 =

Add missing privileges to rosettaadmin DB user run the one-time script fix_translation_credits. Also provide a minimal test to make sure it works with the new permissions.

= Test =

bin/test -vvt fix_translation_credits

= Demo & QA =

Try re-running it on staging as `scripts/rosetta/fix_translation_credits.py -vvv` after security.cfg changes have been applied.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  database/schema/security.cfg
  lib/lp/translations/doc/fix_translation_credits.txt
  scripts/rosetta/fix_translation_credits.py

[Muharem Hrnjadovic (al-maisan)]

Looks good!

review: Approve

[Francis J. Lacoste (flacoste)]

review: Approve (release-critical)

=== modified file 'database/schema/security.cfg'
--- database/schema/security.cfg	2009-10-31 01:41:29 +0000
+++ database/schema/security.cfg	2009-11-05 00:25:25 +0000
@@ -1339,6 +1339,8 @@
 public.distribution                     = SELECT
 public.distroseries                     = SELECT
 public.distroserieslanguage             = SELECT, INSERT, UPDATE
+public.karma                            = SELECT, INSERT
+public.karmaaction                      = SELECT
 public.language                         = SELECT
 public.packaging                        = SELECT
 public.person                           = SELECT
@@ -1347,7 +1349,7 @@
 public.pomsgid                          = SELECT
 public.potemplate                       = SELECT, INSERT, DELETE
 public.potmsgset                        = SELECT, INSERT, DELETE
-public.potranslation                    = SELECT
+public.potranslation                    = SELECT, INSERT
 public.product                          = SELECT
 public.productseries                    = SELECT
 public.sourcepackagename                = SELECT
@@ -1356,6 +1358,7 @@
 public.translationmessage               = SELECT, INSERT, UPDATE, DELETE
 public.translationrelicensingagreement  = SELECT
 public.translationtemplateitem          = SELECT, INSERT, UPDATE, DELETE
+public.validpersoncache                 = SELECT
 
 [translationsbranchscanner]
 type=user

=== added file 'lib/lp/translations/doc/fix_translation_credits.txt'
--- lib/lp/translations/doc/fix_translation_credits.txt	1970-01-01 00:00:00 +0000
+++ lib/lp/translations/doc/fix_translation_credits.txt	2009-11-05 00:25:25 +0000
@@ -0,0 +1,17 @@
+Script `fix_translation_credits.py`
+====================================
+
+Marks all existing translation credits as translated.
+
+    >>> from canonical.launchpad.ftests.script import run_script
+    >>> (returncode, out, err) = run_script(
+    ...     'scripts/rosetta/fix_translation_credits.py')
+    >>> print returncode
+    0
+    >>> print err
+    INFO    creating lockfile
+    INFO    Figuring out POFiles that need fixing: this may take a while...
+    INFO    Marking up a total of 3 credits as translated.
+    INFO    Processed ...
+    INFO    Done.
+

=== modified file 'scripts/rosetta/fix_translation_credits.py'
--- scripts/rosetta/fix_translation_credits.py	2009-10-29 12:36:32 +0000
+++ scripts/rosetta/fix_translation_credits.py	2009-11-05 00:25:25 +0000
@@ -9,12 +9,12 @@
 
 import _pythonpath
 
-from lp.services.scripts.base import LaunchpadCronScript
+from lp.services.scripts.base import LaunchpadScript
 from lp.translations.scripts.fix_translation_credits import (
     FixTranslationCreditsProcess)
 
 
-class FixTranslationCredits(LaunchpadCronScript):
+class FixTranslationCredits(LaunchpadScript):
     """Go through all POFiles and mark translation credits as translated."""
 
     def main(self):