Merge lp:~danilo/launchpad/bug-417083 into lp:launchpad

[Данило Шеган]

[Данило Шеган (danilo)]

= Bug #417083 =

Migrate translation group listing pages to 3.0 layout.

  https://translations.edge.launchpad.net/+groups

== Proposed fix ==

We switch TranslationGroupSet pages to the new layout and fix the most
glaring issues that the page has:

  * Project links should use fmt:link (bug 149218)
  * We should only show a limited number of projects (full listing is
    available on the group overview page anyway)
  * Mention 'Launchpad Translators' in the introductory text and
    put it at the top of the list along with 'Ubuntu translators'
  * Show a number of languages each group has translators for.

Note that these have been done because they are suitably easy: the
changes are mechanical only so you can also see two XXXes introduced
with the above: we hard-code 'launchpad-translators' and
'ubuntu-translators' in the code for ordering the list, and the top
project lists doesn't care about actual translations karma for each of
the projects.

I also migrate the translationgroup-add.pt to use generic-edit.pt
instead, and introduce breadcrumbs on the page.

== Pre-implementation notes ==

UI has been reviewed by intellectronica and approved. I am still
working with mrevell on the best introductory paragraph.

More sampledata for playing with is available at

  http://pastebin.ubuntu.com/259236/

(apply it, then 'make schema': it modifies only the current-dev.sql, so tests should not be affected)

== Implementation details ==

model/translationgroup.py changes include introduction of top_projects
and number_of_remaining_projects properties on the TranslationGroup,
and changed ordering for the __iter__ in TranslationGroupSet utility.

browser/translationgroup.py introduces a breadcrumb class, and modifies
TranslationGroupAddView to provide required properties for
generic-edit.pt.

All the rest is template and test changes.

== Tests ==

bin/test -vvt translationgroup

== Demo and Q/A ==

 * https://translations.launchpad.dev/+groups
 * try using the 'Create a new translation group' link as well

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/translations/stories/translationgroups/05-add-translation-group.txt
  lib/lp/translations/browser/configure.zcml
  lib/canonical/launchpad/pagetitles.py
  lib/lp/translations/templates/translationgroups-index.pt
  lib/lp/translations/model/translationgroup.py
  lib/lp/translations/interfaces/translationgroup.py
  lib/lp/translations/configure.zcml
  lib/lp/translations/browser/translationgroup.py
  lib/lp/translations/doc/translationgroup.txt

[Graham Binns (gmb)]

review: Approve (code)