Merge lp:~danilo/launchpad/bug-1000642-drop into lp:launchpad/db-devel

[Данило Шеган]

Drop SpecificationFeedback table.

= Bug 1000642: drop the table to complete the bug fix =

I need a DB patch number assigned as well.

== LOC Rationale ==

This is part of our effort to implement https://dev.launchpad.net/Projects/WorkItems/ done solely for the LOC credit.

== Tests ==

Full test suite.

== Demo and Q/A ==

Full test suite.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  database/sampledata/current.sql
  database/sampledata/current-dev.sql
  database/schema/patch-2209-20-1.sql
  database/schema/comments.sql

[Stuart Bishop (stub)]

We are still running Slony and can't use DROP TABLE. Instead, you want to:

ALTER TABLE SpecificationFeedback DROP CONSTRAINT specificationfeedback_specification_fk;
ALTER TABLE SpecificationFeedback SET SCHEMA todrop;

The deployment scripts will then do the dance to remove the table from replication and drop it.

Fine for landing after you replace the DROP TABLE with the above.Patch 2209-20-1

review: Approve (db)

[Данило Шеган (danilo)]

Stuart, can you please land this for me (I don't want to approve it myself to land it)?

[Stuart Bishop (stub)]

With ec2

=== modified file 'database/sampledata/current-dev.sql'
--- database/sampledata/current-dev.sql	2012-06-26 10:19:37 +0000
+++ database/sampledata/current-dev.sql	2012-06-27 11:32:23 +0000
@@ -765,9 +765,6 @@
 
 
 
-
-
-
 SET SESSION AUTHORIZATION DEFAULT;
 
 ALTER TABLE account DISABLE TRIGGER ALL;
@@ -9636,19 +9633,6 @@
 ALTER TABLE specificationdependency ENABLE TRIGGER ALL;
 
 
-ALTER TABLE specificationfeedback DISABLE TRIGGER ALL;
-
-INSERT INTO specificationfeedback (id, specification, reviewer, requester, queuemsg, date_created) VALUES (1, 3, 13, 16, 'Please make sure this reflects your implementation plan.', '2006-10-16 18:31:52.861885');
-INSERT INTO specificationfeedback (id, specification, reviewer, requester, queuemsg, date_created) VALUES (2, 4, 16, 1, 'Please confirm this meets your requirements.', '2006-10-16 18:31:52.864486');
-INSERT INTO specificationfeedback (id, specification, reviewer, requester, queuemsg, date_created) VALUES (4, 6, 13, 1, 'sckj hsdkjhskdhdhsdkjf hsdf', '2006-10-16 18:31:52.865147');
-INSERT INTO specificationfeedback (id, specification, reviewer, requester, queuemsg, date_created) VALUES (5, 6, 1, 12, 'sfdjgdlfjgdlfjgdf glkdjf gldkfj glkdfj glkdjf', '2006-10-16 18:31:52.865733');
-INSERT INTO specificationfeedback (id, specification, reviewer, requester, queuemsg, date_created) VALUES (8, 3, 1, 1, 'foo bar baz xfhds fksd hfskdf slkd fksdhf sdkjhfksdf sdkfjh skdjfhsdkj fskjdhfj.d kjsdhfkjhds fs kjshdfkj.', '2006-10-16 18:31:52.866321');
-INSERT INTO specificationfeedback (id, specification, reviewer, requester, queuemsg, date_created) VALUES (9, 3, 1, 12, 'sdfjlksd jflsjdflskjd flksjd fksdjf lskjd flksdfslds lskjflkdss slkd slkfj sljdls kjds flslkdjfls.', '2006-10-16 18:31:52.866953');
-
-
-ALTER TABLE specificationfeedback ENABLE TRIGGER ALL;
-
-
 ALTER TABLE specificationmessage DISABLE TRIGGER ALL;
 
 

=== modified file 'database/sampledata/current.sql'
--- database/sampledata/current.sql	2012-06-22 06:12:53 +0000
+++ database/sampledata/current.sql	2012-06-27 11:32:23 +0000
@@ -765,9 +765,6 @@
 
 
 
-
-
-
 SET SESSION AUTHORIZATION DEFAULT;
 
 ALTER TABLE account DISABLE TRIGGER ALL;
@@ -9553,19 +9550,6 @@
 ALTER TABLE specificationdependency ENABLE TRIGGER ALL;
 
 
-ALTER TABLE specificationfeedback DISABLE TRIGGER ALL;
-
-INSERT INTO specificationfeedback (id, specification, reviewer, requester, queuemsg, date_created) VALUES (1, 3, 13, 16, 'Please make sure this reflects your implementation plan.', '2006-10-16 18:31:52.861885');
-INSERT INTO specificationfeedback (id, specification, reviewer, requester, queuemsg, date_created) VALUES (2, 4, 16, 1, 'Please confirm this meets your requirements.', '2006-10-16 18:31:52.864486');
-INSERT INTO specificationfeedback (id, specification, reviewer, requester, queuemsg, date_created) VALUES (4, 6, 13, 1, 'sckj hsdkjhskdhdhsdkjf hsdf', '2006-10-16 18:31:52.865147');
-INSERT INTO specificationfeedback (id, specification, reviewer, requester, queuemsg, date_created) VALUES (5, 6, 1, 12, 'sfdjgdlfjgdlfjgdf glkdjf gldkfj glkdfj glkdjf', '2006-10-16 18:31:52.865733');
-INSERT INTO specificationfeedback (id, specification, reviewer, requester, queuemsg, date_created) VALUES (8, 3, 1, 1, 'foo bar baz xfhds fksd hfskdf slkd fksdhf sdkjhfksdf sdkfjh skdjfhsdkj fskjdhfj.d kjsdhfkjhds fs kjshdfkj.', '2006-10-16 18:31:52.866321');
-INSERT INTO specificationfeedback (id, specification, reviewer, requester, queuemsg, date_created) VALUES (9, 3, 1, 12, 'sdfjlksd jflsjdflskjd flksjd fksdjf lskjd flksdfslds lskjflkdss slkd slkfj sljdls kjds flslkdjfls.', '2006-10-16 18:31:52.866953');
-
-
-ALTER TABLE specificationfeedback ENABLE TRIGGER ALL;
-
-
 ALTER TABLE specificationmessage DISABLE TRIGGER ALL;
 
 

=== modified file 'database/schema/comments.sql'
--- database/schema/comments.sql	2012-06-15 05:49:38 +0000
+++ database/schema/comments.sql	2012-06-27 11:32:23 +0000
@@ -1555,12 +1555,6 @@
 COMMENT ON CONSTRAINT specification_completion_fully_recorded_chk ON Specification IS 'A constraint that ensures, where we have a date_completed, that we also have a completer. This means that the resolution was fully recorded.';
 COMMENT ON COLUMN Specification.private IS 'Specification is private.';
 
--- SpecificationFeedback
-COMMENT ON TABLE SpecificationFeedback IS 'A table representing a review request of a specification, from one user to another, with an optional message.';
-COMMENT ON COLUMN SpecificationFeedback.reviewer IS 'The person who has been asked to do the review.';
-COMMENT ON COLUMN SpecificationFeedback.requester IS 'The person who made the request.';
-COMMENT ON COLUMN SpecificationFeedback.queuemsg IS 'An optional text message for the reviewer, from the requester.';
-
 -- SpecificationBranch
 COMMENT ON TABLE SpecificationBranch IS 'A branch related to a specification, most likely a branch for implementing the specification.  It is possible to have multiple branches for a given specification especially in the situation where the specification requires modifying multiple products.';
 COMMENT ON COLUMN SpecificationBranch.specification IS 'The specification associated with this branch.';

=== added file 'database/schema/patch-2209-20-1.sql'
--- database/schema/patch-2209-20-1.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-20-1.sql	2012-06-27 11:32:23 +0000
@@ -0,0 +1,9 @@
+-- Copyright 2012 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+ALTER TABLE SpecificationFeedback DROP CONSTRAINT specificationfeedback_specification_fk;
+ALTER TABLE SpecificationFeedback SET SCHEMA todrop;
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 20, 1);