Merge lp:~danilo/launchpad/branch-portlet-details-remove into lp:launchpad

Proposed by Данило Шеган
Status: Merged
Approved by: Данило Шеган
Approved revision: no longer in the source branch.
Merged at revision: 13321
Proposed branch: lp:~danilo/launchpad/branch-portlet-details-remove
Merge into: lp:launchpad
Diff against target: 56 lines (+0/-41)
2 files modified
lib/lp/code/browser/configure.zcml (+0/-3)
lib/lp/code/templates/branch-portlet-details.pt (+0/-38)
To merge this branch: bzr merge lp:~danilo/launchpad/branch-portlet-details-remove
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Approve
Review via email: mp+66117@code.launchpad.net

Commit message

[r=jtv][no-qa] Remove unused portlet IBranch:+portlet-details.

Description of the change

= Remove unused portlet code =

Kill the portlet which is not used anywhere.

== Demo and Q/A ==

If all tests pass, qa-ok.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/code/browser/configure.zcml

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/code/browser/configure.zcml'
2--- lib/lp/code/browser/configure.zcml 2011-05-27 21:03:22 +0000
3+++ lib/lp/code/browser/configure.zcml 2011-06-28 11:28:33 +0000
4@@ -414,9 +414,6 @@
5 name="+index"
6 template="../templates/branch-index.pt"/>
7 <browser:page
8- name="+portlet-details"
9- template="../templates/branch-portlet-details.pt"/>
10- <browser:page
11 name="++bug-links"
12 template="../templates/branch-bug-links.pt"/>
13
14
15=== removed file 'lib/lp/code/templates/branch-portlet-details.pt'
16--- lib/lp/code/templates/branch-portlet-details.pt 2009-07-17 17:59:07 +0000
17+++ lib/lp/code/templates/branch-portlet-details.pt 1970-01-01 00:00:00 +0000
18@@ -1,38 +0,0 @@
19-<div
20- xmlns:tal="http://xml.zope.org/namespaces/tal"
21- xmlns:metal="http://xml.zope.org/namespaces/metal"
22- xmlns:i18n="http://xml.zope.org/namespaces/i18n"
23- class="portlet" id="portlet-details">
24- <h2>Current details</h2>
25- <div class="portletBody portletContent">
26- <table>
27- <tbody>
28- <tr>
29- <th>Type:</th>
30- <td><tal:branch-type replace="context/branch_type/title" /></td>
31- </tr>
32- <tr tal:condition="not:view/owner_is_registrant">
33- <th>Registrant:</th>
34- <td>
35- <tal:registrant replace="structure context/registrant/fmt:link"/>
36- </td>
37- </tr>
38- <tr tal:condition="context/product">
39- <th>Project:</th>
40- <td>
41- <tal:link replace="structure context/product/fmt:link" />
42- </td>
43- </tr>
44- <tr>
45- <th>Status:</th>
46- <td>
47- <span id="branch-details-status-value"
48- tal:content="context/lifecycle_status/title"
49- tal:attributes="class string:branchstatus${context/lifecycle_status/name}"
50- >Experimental</span>
51- </td>
52- </tr>
53- </tbody>
54- </table>
55- </div>
56-</div>