Code review comment for lp:~danigm/bzr-email/branch-commit-to

Revision history for this message
danigm (danigm) wrote :

> On Thu, 2009-12-03 at 08:55 +0000, danigm wrote:
> > > Hi, thanks for this merge proposal.
> > >
> > > I don't understand why all this is needed, and you proposal doesn't
> > > explain either. There are a number of structural issues, such as using
> > > GlobalConfig directly, and using private variables, which I can't assess
> > > until I know the reason for the changes.
> > >
> > > Could you please explain in more detail what was wrong that you needed
> > > to change to make things work.
> > >
> >
> > When I use bazaar in my computer I have a lot of branch of a lot of
> projects. And if I set post_commit_to to an email, all branches send an email
> when I do commit, and I only want to send to different email accounts
> depending on wich branch I'm working.
> >
> > This branch add the option to configure a post_commit_to for each branch in
> your machine.
> >
> > I think that this resolve that bug #309560
>
> You should already be able to do that in branch.conf, are you saying
> that that doesn't work?
>
> -Rob

mmm... ok, that isn't documented... or it's... anyway I don't know nothing about branch.conf, I need to read about it. Today I learn something new.

Sorry, then this branch has no sense, and bug report is invalid too.

Thanks.

« Back to merge proposal