Code review comment for lp:~danigm/bzr-email/branch-commit-to

> > On Thu, 2009-12-03 at 08:55 +0000, danigm wrote:
> > > > Hi, thanks for this merge proposal.
> > > >
> > > > I don't understand why all this is needed, and you proposal doesn't
> > > > explain either. There are a number of structural issues, such as using
> > > > GlobalConfig directly, and using private variables, which I can't assess
> > > > until I know the reason for the changes.
> > > >
> > > > Could you please explain in more detail what was wrong that you needed
> > > > to change to make things work.
> > > >
> > >
> > > When I use bazaar in my computer I have a lot of branch of a lot of
> > projects. And if I set post_commit_to to an email, all branches send an
> email
> > when I do commit, and I only want to send to different email accounts
> > depending on wich branch I'm working.
> > >
> > > This branch add the option to configure a post_commit_to for each branch
> in
> > your machine.
> > >
> > > I think that this resolve that bug #309560
> >
> > You should already be able to do that in branch.conf, are you saying
> > that that doesn't work?

> mmm... ok, that isn't documented... or it's... anyway I don't know nothing
> about branch.conf, I need to read about it. Today I learn something new.
We should definitely improve the documentation for branch.conf - I agree it's not as clear at the moment as it could be.

Newer versions of bzr have a "bzr config" command which allows you to see and modify all relevant configuration options, both global and per-branch.

> Sorry, then this branch has no sense, and bug report is invalid too.
The bug report is about a repository-specific configuration (rather than a branch-specific configuration, which branch.conf is).

I'll mark this MP as rejected, since it overlaps with functionality we already have.