Merge lp:~daniellimws/unity-js-scopes/unity-js-scopes-bug1523595 into lp:unity-js-scopes
Proposed by
Daniel Lim
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Alexandre Abreu | ||||
Approved revision: | 126 | ||||
Merged at revision: | 123 | ||||
Proposed branch: | lp:~daniellimws/unity-js-scopes/unity-js-scopes-bug1523595 | ||||
Merge into: | lp:unity-js-scopes | ||||
Diff against target: |
55 lines (+11/-2) 3 files modified
examples/simple/simple.js (+1/-1) src/bindings/index.js (+8/-0) src/bindings/src/addon.cc (+2/-1) |
||||
To merge this branch: | bzr merge lp:~daniellimws/unity-js-scopes/unity-js-scopes-bug1523595 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexandre Abreu (community) | Approve | ||
Review via email: mp+281469@code.launchpad.net |
To post a comment you must log in.
Thank you for working on this!
This code doesn't build though, could you fix it?
also:
- could you remove the "no-op" changes (prob tab/space updates)? scopes: :ScopeMetadata: :results_ ttl_type returns an enum which is basically in integral type, but you declare it as strings in JS. It should be defined as integers matching the C++ values,
- unity::