Merge lp:~daniel-thewatkins/livecd-rootfs/ext4 into lp:livecd-rootfs

Proposed by Dan Watkins on 2016-02-22
Status: Merged
Merged at revision: 1319
Proposed branch: lp:~daniel-thewatkins/livecd-rootfs/ext4
Merge into: lp:livecd-rootfs
Diff against target: 57 lines (+19/-2)
3 files modified
debian/changelog (+8/-0)
live-build/auto/config (+8/-2)
live-build/ubuntu-cpc/hooks/030-root-tarball.binary (+3/-0)
To merge this branch: bzr merge lp:~daniel-thewatkins/livecd-rootfs/ext4
Reviewer Review Type Date Requested Status
Dimitri John Ledkov 2016-02-22 Approve on 2016-02-22
Review via email: mp+286809@code.launchpad.net

Description of the Change

slangasek changed us to producing a plain rootfs, because we don't use the ext4 rootfs _within_ the buildd. However, we have some external processing that does use it, so this reinstates it (though leaves the hardcoding, because that is a good idea).

To post a comment you must log in.
Dimitri John Ledkov (xnox) wrote :

¯\_(ツ)_/¯

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2016-02-18 13:44:01 +0000
3+++ debian/changelog 2016-02-22 14:44:24 +0000
4@@ -1,3 +1,11 @@
5+livecd-rootfs (2.380) UNRELEASED; urgency=medium
6+
7+ * Refactor ubuntu-cpc hooks to hard-code producing an 'ext4' rootfs, which
8+ is used outside of the livecd-rootfs build process (specifically for EC2
9+ publication).
10+
11+ -- Daniel Watkins <daniel.watkins@canonical.com> Mon, 22 Feb 2016 11:29:26 +0000
12+
13 livecd-rootfs (2.379) xenial; urgency=medium
14
15 * add /var/lib/systemd/rfkill to pre-created dirs to use as writable
16
17=== modified file 'live-build/auto/config'
18--- live-build/auto/config 2016-02-18 00:48:55 +0000
19+++ live-build/auto/config 2016-02-22 14:44:24 +0000
20@@ -103,7 +103,7 @@
21
22 case $PROJECT in
23 ubuntu-cpc)
24- IMAGEFORMAT=plain
25+ IMAGEFORMAT=ext4
26 ;;
27 esac
28
29@@ -117,7 +117,13 @@
30 COMPONENTS='main restricted universe multiverse'
31 ;;
32 *)
33- add_package live jasper
34+ case $PROJECT in
35+ ubuntu-cpc)
36+ ;;
37+ *)
38+ add_package live jasper
39+ ;;
40+ esac
41 ;;
42 esac
43 ;;
44
45=== modified file 'live-build/ubuntu-cpc/hooks/030-root-tarball.binary'
46--- live-build/ubuntu-cpc/hooks/030-root-tarball.binary 2016-02-10 17:30:48 +0000
47+++ live-build/ubuntu-cpc/hooks/030-root-tarball.binary 2016-02-22 14:44:24 +0000
48@@ -7,6 +7,9 @@
49
50 . /build/config/functions
51
52+mkdir binary/boot/filesystem.dir
53+cp -a chroot/* binary/boot/filesystem.dir
54+
55 setup_mountpoint binary/boot/filesystem.dir
56
57 chroot binary/boot/filesystem.dir dpkg-divert --local --rename /usr/sbin/grub-probe

Subscribers

People subscribed via source and target branches