Merge ~daniel-thewatkins/cloud-init/+git/cloud-init:pr_template into cloud-init:master

Proposed by Dan Watkins on 2019-08-15
Status: Merged
Approved by: Dan Watkins on 2019-08-19
Approved revision: 89d87b50b06daea409275ff258a6b63b39edc122
Merge reported by: Server Team CI bot
Merged at revision: not available
Proposed branch: ~daniel-thewatkins/cloud-init/+git/cloud-init:pr_template
Merge into: cloud-init:master
Diff against target: 15 lines (+9/-0)
1 file modified
.github/pull_request_template.md (+9/-0)
Reviewer Review Type Date Requested Status
Ryan Harper 2019-08-15 Approve on 2019-08-19
Server Team CI bot continuous-integration Approve on 2019-08-15
Review via email: mp+371350@code.launchpad.net

Commit message

Add GitHub pull request template to point people at hacking doc

This will hopefully avoid people submitting PRs against our mirror repo.

(Thanks to GitHub user @max06 for this suggestion!)

To post a comment you must log in.

PASSED: Continuous integration, rev:9e6b39a5aa58e1a247285cef237304b54298d28a
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1045/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    SUCCESS: Ubuntu LTS: Integration
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1045//rebuild

review: Approve (continuous-integration)
Ryan Harper (raharper) wrote :

Thanks for doing this one. Should we link to the Launchpad git repo as well?

Dan Watkins (daniel-thewatkins) wrote :

Good idea, done.

PASSED: Continuous integration, rev:89d87b50b06daea409275ff258a6b63b39edc122
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1050/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    SUCCESS: Ubuntu LTS: Integration
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1050//rebuild

review: Approve (continuous-integration)
Ryan Harper (raharper) wrote :

Looks Great!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
2new file mode 100644
3index 0000000..170a71e
4--- /dev/null
5+++ b/.github/pull_request_template.md
6@@ -0,0 +1,9 @@
7+***This GitHub repo is only a mirror. Do not submit pull requests
8+here!***
9+
10+Thank you for taking the time to write and submit a change to
11+cloud-init! Please follow [our hacking
12+guide](https://cloudinit.readthedocs.io/en/latest/topics/hacking.html)
13+to submit your change to cloud-init's [Launchpad git
14+repository](https://code.launchpad.net/cloud-init/), where cloud-init
15+development happens.

Subscribers

People subscribed via source and target branches