Juju Charms Collection
ubuntu-repository-cache package

Merge lp:~daniel-thewatkins/charms/trusty/ubuntu-repository-cache/fix_cron_path into lp:charms/trusty/ubuntu-repository-cache

  1. Trusty Tahr (14.04)
  2. fix_cron_path
  3. Merge into trunk
Proposed by Dan Watkins on 2015-06-01
Status: Merged
Merged at revision: 194
Proposed branch: lp:~daniel-thewatkins/charms/trusty/ubuntu-repository-cache/fix_cron_path
Merge into: lp:charms/trusty/ubuntu-repository-cache
Diff against target: 8 lines (+2/-1)
1 file modified
templates/cron/ubuntu-repository-cache_rsync.cron (+2/-1)
To merge this branch: bzr merge lp:~daniel-thewatkins/charms/trusty/ubuntu-repository-cache/fix_cron_path
Reviewer Review Type Date Requested Status
José Antonio Rey 2015-06-01 Approve on 2015-06-04
Robert C Jennings (community) 2015-06-03 Approve on 2015-06-04
Adam Israel Approve on 2015-06-04
Review via email: mp+260696@code.launchpad.net

Description of the Change

Sets PATH in the cronjob, as per bug 1455649.

To post a comment you must log in.
Adam Israel (aisrael) wrote :

Hi Daniel,

Thanks for your work on this. I had a chance to review the merge proposal and it looks good to me. +1.

review: Approve
Robert C Jennings (rcj) wrote :

Thanks Dan, the patch looks good. +1

review: Approve
José Antonio Rey (jose) wrote :

Hey Daniel!

Thanks a lot for this fix. I am merging this right ahead - looks good!

+1 LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'templates/cron/ubuntu-repository-cache_rsync.cron'
2--- templates/cron/ubuntu-repository-cache_rsync.cron 2014-09-18 18:55:16 +0000
3+++ templates/cron/ubuntu-repository-cache_rsync.cron 2015-06-01 10:17:05 +0000
4@@ -1,2 +1,3 @@
5-{{ Minutes }} * * * * www-sync /usr/local/bin/juju-run {{ UnitID }} /var/lib/juju/agents/{{ UnitPath }}/charm/hooks/ubuntu-repository-cache-sync
6+PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
7
8+{{ Minutes }} * * * * www-sync juju-run {{ UnitID }} /var/lib/juju/agents/{{ UnitPath }}/charm/hooks/ubuntu-repository-cache-sync

Subscribers

People subscribed via source and target branches

to all changes: