Juju Charms Collection
ubuntu-repository-cache package

Merge lp:~daniel-thewatkins/charms/trusty/ubuntu-repository-cache/fix-perms into lp:charms/trusty/ubuntu-repository-cache

  1. Trusty Tahr (14.04)
  2. fix-perms
  3. Merge into trunk
Proposed by Dan Watkins on 2015-08-03
Status: Merged
Merged at revision: 198
Proposed branch: lp:~daniel-thewatkins/charms/trusty/ubuntu-repository-cache/fix-perms
Merge into: lp:charms/trusty/ubuntu-repository-cache
Diff against target: 12 lines (+0/-2)
1 file modified
lib/ubuntu_repository_cache/storage.py (+0/-2)
To merge this branch: bzr merge lp:~daniel-thewatkins/charms/trusty/ubuntu-repository-cache/fix-perms
Reviewer Review Type Date Requested Status
José Antonio Rey 2015-08-03 Approve on 2015-08-03
Review via email: mp+266724@code.launchpad.net
To post a comment you must log in.
José Antonio Rey (jose) wrote :

Hey Dan,

Charm is now working as expected. Thanks a lot for the quick fix!

+1 LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/ubuntu_repository_cache/storage.py'
2--- lib/ubuntu_repository_cache/storage.py 2015-03-27 20:04:13 +0000
3+++ lib/ubuntu_repository_cache/storage.py 2015-08-03 14:14:25 +0000
4@@ -79,8 +79,6 @@
5 # Add the primary mount last for squid. This allocates it last
6 # and saves additional space for metadata mirrors
7 squid_cache = '/'.join((primary_mount, 'squid'))
8- _mkdir(os.path.dirname(squid_cache), owner='proxy', group='proxy',
9- perms=0o770)
10 _mkdir(squid_cache, owner='proxy', group='proxy', perms=0o770)
11 max_size = _disk_free(squid_cache)
12 # Reserve 8GB for metadata and 4GB for the OS

Subscribers

People subscribed via source and target branches

to all changes: