Merge lp:~dani-ds/openerp-spain/6.0 into lp:~openerp-spain-team/openerp-spain/6.0

Proposed by Daniel Campos (Avanzosc)
Status: Merged
Merged at revision: 361
Proposed branch: lp:~dani-ds/openerp-spain/6.0
Merge into: lp:~openerp-spain-team/openerp-spain/6.0
Diff against target: 74 lines (+22/-10)
2 files modified
account_financial_report_web/report/account_balance.py (+13/-7)
account_financial_report_web/report/general_ledger.py (+9/-3)
To merge this branch: bzr merge lp:~dani-ds/openerp-spain/6.0
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza code review Approve
Review via email: mp+218756@code.launchpad.net

Description of the change

A la hora de mostrar el informe de Libro Mayor y buscar el año fiscal puedes obtener un id en vez de una lista de ids

To post a comment you must log in.
Revision history for this message
Daniel Campos (Avanzosc) (dani-ds) wrote :

Si no hay ninguna objeción, procedo a realizar el merge.

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

De acuerdo, Dani, puedes proceder con ello, ¿tienes claro cómo hacerlo para que se quede todo cerrado?

Un saludo.

review: Approve (code review)
Revision history for this message
Daniel Campos (Avanzosc) (dani-ds) wrote :

Hola Pedro, si no hay problema.

lp:~dani-ds/openerp-spain/6.0 updated
361. By Daniel Campos (Avanzosc)

[FIX] A la hora de mostrar el informe del Libro Mayor y el Balance de Sumas y Saldos, al buscar el año fiscal puedes obtener un id en vez de una lista de ids

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_financial_report_web/report/account_balance.py'
2--- account_financial_report_web/report/account_balance.py 2014-02-28 13:09:11 +0000
3+++ account_financial_report_web/report/account_balance.py 2014-05-08 15:04:40 +0000
4@@ -72,10 +72,11 @@
5 fiscalyear_obj = self.pool.get('account.fiscalyear')
6 fiscalyear = None
7
8- if form.get('fiscalyear'):
9-
10- fiscalyear = fiscalyear_obj.browse(self.cr, self.uid, form['fiscalyear'][0])
11-
12+ if 'fiscalyear' in form:
13+ if isinstance(form['fiscalyear'], int):
14+ fiscalyear = fiscalyear_obj.browse(self.cr, self.uid, form['fiscalyear'])
15+ else:
16+ fiscalyear = fiscalyear_obj.browse(self.cr, self.uid, form['fiscalyear'][0])
17 return fiscalyear.name or fiscalyear.code
18 else:
19 fiscalyear = fiscalyear_obj.browse(self.cr, self.uid, fiscalyear_obj.find(self.cr, self.uid))
20@@ -89,7 +90,9 @@
21 period_obj = self.pool.get('account.period')
22 periods_str = None
23 fiscalyear_id = form['fiscalyear'] or fiscalyear_obj.find(self.cr, self.uid)
24- period_ids = period_obj.search(self.cr, self.uid, [('fiscalyear_id','=',fiscalyear_id[0]),('special','=',False)])
25+ if isinstance(fiscalyear_id, list):
26+ fiscalyear_id = fiscalyear_id[0]
27+ period_ids = period_obj.search(self.cr, self.uid, [('fiscalyear_id','=',fiscalyear_id),('special','=',False)])
28 if form['state'] in ['byperiod', 'all']:
29 period_ids = form['periods']
30 periods_str = ', '.join([period.name or period.code for period in period_obj.browse(self.cr, self.uid, period_ids)])
31@@ -133,8 +136,11 @@
32
33 # Get the fiscal year
34 fiscalyear = None
35- if form.get('fiscalyear'):
36- fiscalyear = fiscalyear_obj.browse(self.cr, self.uid, form['fiscalyear'][0])
37+ if 'fiscalyear' in form:
38+ if isinstance(form['fiscalyear'], int):
39+ fiscalyear = fiscalyear_obj.browse(self.cr, self.uid, form['fiscalyear'])
40+ else:
41+ fiscalyear = fiscalyear_obj.browse(self.cr, self.uid, form['fiscalyear'][0])
42 else:
43 fiscalyear = fiscalyear_obj.browse(self.cr, self.uid, fiscalyear_obj.find(self.cr, self.uid))
44
45
46=== modified file 'account_financial_report_web/report/general_ledger.py'
47--- account_financial_report_web/report/general_ledger.py 2014-02-28 13:09:11 +0000
48+++ account_financial_report_web/report/general_ledger.py 2014-05-08 15:04:40 +0000
49@@ -73,8 +73,11 @@
50
51 def get_fiscalyear(self, form):
52 res=[]
53- if form.has_key('fiscalyear'):
54- fisc_id = form['fiscalyear'][0]
55+ if 'fiscalyear' in form:
56+ if isinstance(form['fiscalyear'], int):
57+ fisc_id = form['fiscalyear']
58+ else:
59+ fisc_id = form['fiscalyear'][0]
60 if not (fisc_id):
61 return ''
62 self.cr.execute("SELECT name FROM account_fiscalyear WHERE id = %s" , (int(fisc_id),))
63@@ -148,7 +151,10 @@
64 # ctx: Context for the given date or period
65 ctx = self.context.copy()
66 if 'fiscalyear' in form and form['fiscalyear']:
67- ctx['fiscalyear'] = form['fiscalyear'][0]
68+ if isinstance(form['fiscalyear'], int):
69+ ctx['fiscalyear'] = form['fiscalyear']
70+ else:
71+ ctx['fiscalyear'] = form['fiscalyear'][0]
72 if form['state'] in ['byperiod', 'all']:
73 ctx['periods'] = form['periods']
74 if form['state'] in ['bydate', 'all']: