Merge lp:~dandrader/unity8/updateTestShellWithPin into lp:unity8

Proposed by Daniel d'Andrada on 2015-07-14
Status: Merged
Approved by: Albert Astals Cid on 2015-07-14
Approved revision: 1857
Merged at revision: 1860
Proposed branch: lp:~dandrader/unity8/updateTestShellWithPin
Merge into: lp:unity8
Diff against target: 12 lines (+1/-1)
1 file modified
tests/qmltests/tst_ShellWithPin.qml (+1/-1)
To merge this branch: bzr merge lp:~dandrader/unity8/updateTestShellWithPin
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing on 2015-07-14
Albert Astals Cid (community) 2015-07-14 Approve on 2015-07-14
Review via email: mp+264721@code.launchpad.net

Commit Message

Update tst_ShellWithPin

Spread is no longer enabled while the greeter is being shown.

Description of the Change

* Are there any related MPs required for this MP to build/function as expected? Please list.
No.

* Did you perform an exploratory manual test run of your code change and any related functionality?
Test passes now.

* Did you make sure that your branch does not contain spurious tags?
Yes.

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable.

* If you changed the UI, has there been a design review?
Not applicable.

To post a comment you must log in.
Albert Astals Cid (aacid) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes, test passes now, and makes sense

 * Did CI run pass?
Not yet, doesn't matter anyway since qmltests are nto run in CI at the moment

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/qmltests/tst_ShellWithPin.qml'
2--- tests/qmltests/tst_ShellWithPin.qml 2015-06-23 17:40:03 +0000
3+++ tests/qmltests/tst_ShellWithPin.qml 2015-07-14 14:49:25 +0000
4@@ -313,7 +313,7 @@
5 tryCompare(panel, "fullscreenMode", false)
6 tryCompare(indicators, "available", true)
7 tryCompare(launcher, "available", true)
8- tryCompare(stage, "spreadEnabled", true)
9+ tryCompare(stage, "spreadEnabled", false)
10 }
11
12 function test_emergencyCallCrash() {

Subscribers

People subscribed via source and target branches