Merge lp:~dandrader/unity8/unifyShellTests into lp:unity8

[Daniel d'Andrada]

Make tst_Shell absorb tst_TabletShell

Benefits:
  - less code duplication (the code beyond the test functions themselves, such as qml code and helper functions)
  - Enables one to try out and test all possible combinations involving shell, like tablet vs phone vs single user vs multi user. test_launchedAppHasActiveFocus being the first example. The same test is run against both phone and tablet shell configurations.
  - Sticks to the convention that all qml tests for a given component are run by "make testComponentName". For Shell they were spread around between tst_Shell, tst_TabletShell and tst_ShellWithPin (that last one remains for now).

* Are there any related MPs required for this MP to build/function as expected? Please list.
No, but it builds upon lp:~dandrader/unity8/stabilizeShellTest

* Did you perform an exploratory manual test run of your code change and any related functionality?
Not applicable.

* Did you make sure that your branch does not contain spurious tags?
Yes.

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable.

* If you changed the UI, has there been a design review?
Not applicable.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1637
http://jenkins.qa.ubuntu.com/job/unity8-ci/5361/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1534
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/525
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/526
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/526
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1365
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1532
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1532/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18353

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5361/rebuild

review: Needs Fixing (continuous-integration)

[Albert Astals Cid (aacid)]

Seems the new tests actually didn't pass

[lp:~dandrader/unity8/unifyShellTests]

1638. By Daniel d'Andrada on 2015-02-26

Wait for greeter to stabilize before running test and remove unused function

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1638
http://jenkins.qa.ubuntu.com/job/unity8-ci/5364/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1555
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/528
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/529
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/529
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1385
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1553
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1553/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18390

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5364/rebuild

review: Needs Fixing (continuous-integration)

[Daniel d'Andrada (dandrader)]

On 26/02/15 05:20, Albert Astals Cid wrote:
> Seems the new tests actually didn't pass
Fixed.

[Michael Terry (mterry)]

You dropped the following code during cleanup:
shell.indicatorProfile = "phone";

(It is property defined outside of Shell.qml, so reloading Shell.qml doesn't reset it. And it is modified by some tests, so we should clean it to a known-good value.)

review: Needs Fixing

[Michael Terry (mterry)]

Nope, I'm wrong. That property is defined in the sourceComponent. It's fine as is.

[Michael Terry (mterry)]

 * Did you perform an exploratory manual test run of the code change and any related functionality?
 Yes

 * Did CI run pass? If not, please explain why.
 Yesish, autopilot is it's own problem.

 * Did you make sure that the branch does not contain spurious tags?
 Yes

review: Approve

[lp:~dandrader/unity8/unifyShellTests]

1639. By Daniel d'Andrada on 2015-03-10

Merge trunk

[ Albert Astals ]
* Don't precache items that are outisde the 1.5*height buffering area
  (LP: #1410131)
[ Albert Astals Cid ]
* Don't precache items that are outisde the 1.5*height buffering area
  (LP: #1410131)
[ Chris Townsend ]
* Add a wrapper for handling the
  /org/gnome/SessionManager/EndSessionDialog DBus object used by
  indicator-session. This allows indicator-session to properly talk to
  the Unity 8 session management functions. (LP: #1392187)
* Allow for proper logout session management. This uses the
  EndSession() Upstart DBus method on the current session bus. (LP:
  #1360316)
* Make the Unity 8 session dialogs behave in the same fashion as Unity
  7. From indicator-session: Clicking "Log Out" will now present a
  dialog to "Lock", "Log Out", or "Cancel". Clicking "Shut Down" will
  now present a dialog to "Reboot", "Shut Down", or "Cancel". (LP:
  #1416074)
[ Daniel d'Andrada ]
* Add NO_TESTS cmake option to skip tests and therefore speed up
  builds
* Remove enums and properties that doesn't exist in the real
  ApplicationManager
* Stabilize some Shell qml tests
[ Josh Arenson ]
* Create a PhysicalKeyMapper to handle all physical/hardware keys (LP:
  #1390393)
[ Michael Terry ]
* Make the draggable part of the right edge (during the tutorial) a
  constant size, instead of having it grow and shrink as the spread
  peeks out from the side.
[ Michał Sawicz ]
* Create a PhysicalKeyMapper to handle all physical/hardware keys (LP:
  #1390393)
[ Robert Bruce Park ]
* Launchpad automatic translations update.
[ CI Train Bot ]
* New rebuild forced.
[ Pete Woods ]
* Only set scopes active when the screen is on (LP: #1422879)

=== modified file 'tests/qmltests/CMakeLists.txt'
--- tests/qmltests/CMakeLists.txt	2015-03-02 12:10:22 +0000
+++ tests/qmltests/CMakeLists.txt	2015-03-10 13:53:56 +0000
@@ -21,7 +21,6 @@
 
 add_qml_test(. Shell)
 add_qml_test(. ShellWithPin)
-add_qml_test(. TabletShell)
 add_qml_test(Components Background)
 add_qml_test(Components Carousel)
 add_qml_test(Components Dialogs)

=== modified file 'tests/qmltests/tst_Shell.qml'
--- tests/qmltests/tst_Shell.qml	2015-02-25 14:38:26 +0000
+++ tests/qmltests/tst_Shell.qml	2015-03-10 13:53:56 +0000
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013-2014 Canonical, Ltd.
+ * Copyright (C) 2013-2015 Canonical, Ltd.
  *
  * Authors:
  *   Daniel d'Andrada <[e-mail]>
@@ -34,9 +34,10 @@
 
 import "../../qml"
 
-Item {
+Rectangle {
     id: root
-    width: units.gu(60)
+    color: "grey"
+    width: units.gu(100) + controls.width
     height: units.gu(71)
 
     Component.onCompleted: {
@@ -62,12 +63,37 @@
         }
     }
 
-    Row {
-        anchors.fill: parent
+    Item {
+        anchors.left: root.left
+        anchors.right: controls.left
+        anchors.top: root.top
+        anchors.bottom: root.bottom
         Loader {
             id: shellLoader
             focus: true
 
+            anchors.centerIn: parent
+
+            state: "phone"
+            states: [
+                State {
+                    name: "phone"
+                    PropertyChanges {
+                        target: shellLoader
+                        width: units.gu(40)
+                        height: units.gu(71)
+                    }
+                },
+                State {
+                    name: "tablet"
+                    PropertyChanges {
+                        target: shellLoader
+                        width: units.gu(100)
+                        height: units.gu(71)
+                    }
+                }
+            ]
+
             active: false
             property bool itemDestroyed: false
             sourceComponent: Component {
@@ -80,42 +106,56 @@
                 }
             }
         }
-
-        Rectangle {
-            color: "darkgrey"
-            width: units.gu(30)
-            height: shellLoader.height
-
-            Column {
-                anchors { left: parent.left; right: parent.right; top: parent.top; margins: units.gu(1) }
-                spacing: units.gu(1)
-                Row {
-                    anchors { left: parent.left; right: parent.right }
-                    Button {
-                        text: "Show Greeter"
-                        activeFocusOnPress: false
-                        onClicked: {
-                            if (shellLoader.status !== Loader.Ready)
-                                return;
-
-                            var greeter = testCase.findChild(shellLoader.item, "greeter");
-                            if (!greeter.shown) {
-                                LightDM.Greeter.showGreeter();
-                            }
+    }
+
+    Rectangle {
+        id: controls
+        color: "darkgrey"
+        width: units.gu(30)
+        anchors.top: root.top
+        anchors.bottom: root.bottom
+        anchors.right: root.right
+
+        Column {
+            anchors { left: parent.left; right: parent.right; top: parent.top; margins: units.gu(1) }
+            spacing: units.gu(1)
+            Row {
+                anchors { left: parent.left; right: parent.right }
+                Button {
+                    text: "Show Greeter"
+                    activeFocusOnPress: false
+                    onClicked: {
+                        if (shellLoader.status !== Loader.Ready)
+                            return;
+
+                        var greeter = testCase.findChild(shellLoader.item, "greeter");
+                        if (!greeter.shown) {
+                            LightDM.Greeter.showGreeter();
                         }
                     }
                 }
-                ListItem.ItemSelector {
-                    anchors { left: parent.left; right: parent.right }
-                    activeFocusOnPress: false
-                    text: "LightDM mock mode"
-                    model: ["single", "single-passphrase", "single-pin"]
-                    onSelectedIndexChanged: {
-                        shellLoader.active = false;
-                        LightDM.Greeter.mockMode = model[selectedIndex];
-                        LightDM.Users.mockMode = model[selectedIndex];
-                        shellLoader.active = true;
-                    }
+            }
+            ListItem.ItemSelector {
+                anchors { left: parent.left; right: parent.right }
+                activeFocusOnPress: false
+                text: "LightDM mock mode"
+                model: ["single", "single-passphrase", "single-pin", "full"]
+                onSelectedIndexChanged: {
+                    shellLoader.active = false;
+                    LightDM.Greeter.mockMode = model[selectedIndex];
+                    LightDM.Users.mockMode = model[selectedIndex];
+                    shellLoader.active = true;
+                }
+            }
+            ListItem.ItemSelector {
+                anchors { left: parent.left; right: parent.right }
+                activeFocusOnPress: false
+                text: "Size"
+                model: ["phone", "tablet"]
+                onSelectedIndexChanged: {
+                    shellLoader.active = false;
+                    shellLoader.state = model[selectedIndex];
+                    shellLoader.active = true;
                 }
             }
         }
@@ -186,20 +226,49 @@
         property Item shell: shellLoader.status === Loader.Ready ? shellLoader.item : null
 
         function init() {
+            if (shellLoader.active) {
+                // happens for the very first test function as shell
+                // is loaded by default
+                tearDown();
+            }
+
+        }
+
+        function cleanup() {
+            tryCompare(shell, "enabled", true); // make sure greeter didn't leave us in disabled state
+            tearDown();
+        }
+
+        function loadShell(formFactor) {
+            shellLoader.state = formFactor;
+            shellLoader.active = true;
+            tryCompare(shellLoader, "status", Loader.Ready);
+            removeTimeConstraintsFromDirectionalDragAreas(shellLoader.item);
             tryCompare(shell, "enabled", true); // enabled by greeter when ready
-            shell.indicatorProfile = "phone";
-
-            swipeAwayGreeter();
 
             sessionSpy.target = findChild(shell, "greeter")
             dashCommunicatorSpy.target = findInvisibleChild(shell, "dashCommunicator");
 
             var launcher = findChild(shell, "launcher");
             launcherShowDashHomeSpy.target = launcher;
-        }
-
-        function cleanup() {
-            tryCompare(shell, "enabled", true); // make sure greeter didn't leave us in disabled state
+
+            waitForGreeterToStabilize();
+        }
+
+        function waitForGreeterToStabilize() {
+            var greeter = findChild(shell, "greeter");
+            verify(greeter);
+
+            var loginList = findChild(greeter, "loginList");
+            // Only present in WideView
+            if (loginList) {
+                var userList = findChild(loginList, "userList");
+                verify(userList);
+                tryCompare(userList, "movingInternally", false);
+            }
+        }
+
+        function tearDown() {
             launcherShowDashHomeSpy.target = null;
 
             shellLoader.itemDestroyed = false;
@@ -216,17 +285,17 @@
             // Shell instance gets destroyed.
             tryCompare(shellLoader, "itemDestroyed", true);
 
+            setLightDMMockMode("single"); // back to the default value
+
+            AccountsService.demoEdges = false;
+
             // kill all (fake) running apps
             killApps(ApplicationManager);
 
             unlockAllModemsSpy.clear()
             LightDM.Greeter.authenticate(""); // reset greeter
 
-            // reload our test subject to get it in a fresh state once again
-            shellLoader.active = true;
-
-            tryCompare(shellLoader, "status", Loader.Ready);
-            removeTimeConstraintsFromDirectionalDragAreas(shellLoader.item);
+            sessionSpy.clear();
         }
 
         function killApps() {
@@ -238,6 +307,8 @@
         }
 
         function test_snapDecisionDismissalReturnsFocus() {
+            loadShell("phone");
+            swipeAwayGreeter();
             var notifications = findChild(shell, "notificationList");
             var app = ApplicationManager.startApplication("camera-app");
             var stage = findChild(shell, "stage")
@@ -296,19 +367,41 @@
             mockNotificationsModel.append(n)
         }
 
-        function test_leftEdgeDrag_data() {
+        function test_phoneLeftEdgeDrag_data() {
             return [
-                {tag: "without launcher", revealLauncher: false, swipeLength: units.gu(27), appHides: true, focusedApp: "dialer-app", launcherHides: true, greeterShown: false},
-                {tag: "with launcher", revealLauncher: true, swipeLength: units.gu(27), appHides: true, focusedApp: "dialer-app", launcherHides: true, greeterShown: false},
-                {tag: "small swipe", revealLauncher: false, swipeLength: units.gu(25), appHides: false, focusedApp: "dialer-app", launcherHides: false, greeterShown: false},
-                {tag: "long swipe", revealLauncher: false, swipeLength: units.gu(27), appHides: true, focusedApp: "dialer-app", launcherHides: true, greeterShown: false},
-                {tag: "small swipe with greeter", revealLauncher: false, swipeLength: units.gu(25), appHides: false, focusedApp: "dialer-app", launcherHides: false, greeterShown: true},
-                {tag: "long swipe with greeter", revealLauncher: false, swipeLength: units.gu(27), appHides: true, focusedApp: "dialer-app", launcherHides: true, greeterShown: true},
-                {tag: "swipe over dash", revealLauncher: false, swipeLength: units.gu(27), appHides: true, focusedApp: "unity8-dash", launcherHides: false, greeterShown: false},
+                {tag: "without launcher",
+                 revealLauncher: false, swipeLength: units.gu(27), appHides: true, focusedApp: "dialer-app",
+                 launcherHides: true, greeterShown: false},
+
+                {tag: "with launcher",
+                 revealLauncher: true, swipeLength: units.gu(27), appHides: true, focusedApp: "dialer-app",
+                 launcherHides: true, greeterShown: false},
+
+                {tag: "small swipe",
+                 revealLauncher: false, swipeLength: units.gu(25), appHides: false, focusedApp: "dialer-app",
+                 launcherHides: false, greeterShown: false},
+
+                {tag: "long swipe",
+                 revealLauncher: false, swipeLength: units.gu(27), appHides: true, focusedApp: "dialer-app",
+                 launcherHides: true, greeterShown: false},
+
+                {tag: "small swipe with greeter",
+                 revealLauncher: false, swipeLength: units.gu(25), appHides: false, focusedApp: "dialer-app",
+                 launcherHides: false, greeterShown: true},
+
+                {tag: "long swipe with greeter",
+                 revealLauncher: false, swipeLength: units.gu(27), appHides: true, focusedApp: "dialer-app",
+                 launcherHides: true, greeterShown: true},
+
+                {tag: "swipe over dash",
+                 revealLauncher: false, swipeLength: units.gu(27), appHides: true, focusedApp: "unity8-dash",
+                 launcherHides: false, greeterShown: false},
             ];
         }
 
-        function test_leftEdgeDrag(data) {
+        function test_phoneLeftEdgeDrag(data) {
+            loadShell("phone");
+            swipeAwayGreeter();
             dragLauncherIntoView();
             tapOnAppIconInLauncher();
             waitUntilApplicationWindowIsFullyVisible();
@@ -341,7 +434,32 @@
             compare(animateTimer.nextState, "visible");
         }
 
+        function test_tabletLeftEdgeDrag_data() {
+            return [
+                {tag: "without password", user: "no-password", loggedIn: true, demo: false},
+                {tag: "with password", user: "has-password", loggedIn: false, demo: false},
+                {tag: "with demo", user: "has-password", loggedIn: true, demo: true},
+            ]
+        }
+
+        function test_tabletLeftEdgeDrag(data) {
+            setLightDMMockMode("full");
+            loadShell("tablet");
+
+            selectUser(data.user)
+
+            AccountsService.demoEdges = data.demo
+            var tutorial = findChild(shell, "tutorial");
+            tryCompare(tutorial, "running", data.demo);
+
+            swipeFromLeftEdge(shell.width * 0.75)
+            wait(500) // to give time to handle dash() signal from Launcher
+            confirmLoggedIn(data.loggedIn)
+        }
+
         function test_suspend() {
+            loadShell("phone");
+            swipeAwayGreeter();
             var greeter = findChild(shell, "greeter");
 
             // Launch an app from the launcher
@@ -401,6 +519,60 @@
             waitForRendering(greeter);
         }
 
+        function selectUserAtIndex(i) {
+            // We could be anywhere in list; find target index to know which direction
+            var greeter = findChild(shell, "greeter")
+            var userlist = findChild(greeter, "userList")
+            if (userlist.currentIndex == i)
+                keyClick(Qt.Key_Escape) // Reset state if we're not moving
+            while (userlist.currentIndex != i) {
+                var next = userlist.currentIndex + 1
+                if (userlist.currentIndex > i) {
+                    next = userlist.currentIndex - 1
+                }
+                tap(findChild(greeter, "username"+next));
+                tryCompare(userlist, "currentIndex", next)
+                tryCompare(userlist, "movingInternally", false)
+            }
+        }
+
+        function selectUser(name) {
+            // Find index of user with the right name
+            for (var i = 0; i < LightDM.Users.count; i++) {
+                if (LightDM.Users.data(i, LightDM.UserRoles.NameRole) == name) {
+                    break
+                }
+            }
+            if (i == LightDM.Users.count) {
+                fail("Didn't find name")
+                return -1
+            }
+            selectUserAtIndex(i)
+            return i
+        }
+
+        function clickPasswordInput(isButton) {
+            var greeter = findChild(shell, "greeter")
+            tryCompare(greeter, "fullyShown", true);
+
+            var passwordMouseArea = findChild(shell, "passwordMouseArea")
+            tryCompare(passwordMouseArea, "enabled", isButton)
+
+            var passwordInput = findChild(shell, "passwordInput")
+            mouseClick(passwordInput)
+        }
+
+        function confirmLoggedIn(loggedIn) {
+            var greeter = findChild(shell, "greeter");
+            tryCompare(greeter, "shown", loggedIn ? false : true);
+            verify(loggedIn ? sessionSpy.count > 0 : sessionSpy.count === 0);
+        }
+
+        function setLightDMMockMode(mode) {
+            LightDM.Greeter.mockMode = mode;
+            LightDM.Users.mockMode = mode;
+        }
+
         /*
           Regression test for bug https://bugs.launchpad.net/touch-preview-images/+bug/1193419
 
@@ -413,6 +585,8 @@
           - verify the setCurrentScope() D-Bus call to the dash has been called for the correct scope id.
          */
         function test_minimizingAppTakesToDashApps() {
+            loadShell("phone");
+            swipeAwayGreeter();
             dragLauncherIntoView();
 
             // Launch an app from the launcher
@@ -433,6 +607,8 @@
         }
 
         function test_showInputMethod() {
+            loadShell("phone");
+            swipeAwayGreeter();
             var item = findChild(shell, "inputMethod");
             var surface = SurfaceManager.inputMethodSurface();
 
@@ -471,6 +647,8 @@
         }
 
         function test_surfaceLosesActiveFocusWhilePanelIsOpen() {
+            loadShell("phone");
+            swipeAwayGreeter();
             var app = ApplicationManager.startApplication("dialer-app");
             waitUntilAppWindowIsFullyLoaded(app);
 
@@ -501,28 +679,26 @@
             tryCompare(app.session.surface, "activeFocus", true);
         }
 
-        function test_launchedAppHasActiveFocus() {
-            var dialerApp = ApplicationManager.startApplication("dialer-app");
+        function test_launchedAppHasActiveFocus_data() {
+            return [
+                {tag:"phone", formFactor:"phone"},
+                {tag:"tablet", formFactor:"tablet"},
+            ];
+        }
+
+        function test_launchedAppHasActiveFocus(data) {
+            loadShell(data.formFactor);
+            swipeAwayGreeter();
+
+            var dialerApp = ApplicationManager.startApplication("webbrowser-app");
             verify(dialerApp);
-            waitUntilAppSurfaceShowsUp("dialer-app")
+            waitUntilAppSurfaceShowsUp("webbrowser-app")
 
             verify(dialerApp.session.surface);
 
             tryCompare(dialerApp.session.surface, "activeFocus", true);
         }
 
-        // Wait for the whole UI to settle down
-        function waitForUIToSettle() {
-            var launcher = findChild(shell, "launcherPanel")
-            tryCompareFunction(function() {return launcher.x === 0 || launcher.x === -launcher.width;}, true);
-            if (launcher.x === 0) {
-                mouseClick(shell)
-            }
-            tryCompare(launcher, "x", -launcher.width)
-
-            waitForRendering(shell)
-        }
-
         function waitUntilAppSurfaceShowsUp(appId) {
             var appWindow = findChild(shell, "appWindow_" + appId);
             verify(appWindow);
@@ -615,6 +791,8 @@
         }
 
         function test_greeterDoesNotChangeIndicatorProfile() {
+            loadShell("phone");
+            swipeAwayGreeter();
             var panel = findChild(shell, "panel");
             tryCompare(panel.indicators.indicatorsModel, "profile", shell.indicatorProfile);
 
@@ -626,6 +804,8 @@
         }
 
         function test_shellProfileChangesReachIndicators() {
+            loadShell("phone");
+            swipeAwayGreeter();
             var panel = findChild(shell, "panel");
 
             shell.indicatorProfile = "test1";
@@ -642,6 +822,8 @@
         }
 
         function test_focusRequestedHidesGreeter() {
+            loadShell("phone");
+            swipeAwayGreeter();
             var greeter = findChild(shell, "greeter");
 
             var app = ApplicationManager.startApplication("dialer-app");
@@ -662,6 +844,8 @@
         }
 
         function test_focusRequestedHidesIndicators() {
+            loadShell("phone");
+            swipeAwayGreeter();
             var indicators = findChild(shell, "indicators");
 
             showIndicators();
@@ -674,6 +858,8 @@
         }
 
         function test_showAndHideGreeterDBusCalls() {
+            loadShell("phone");
+            swipeAwayGreeter();
             var greeter = findChild(shell, "greeter")
             tryCompare(greeter, "shown", false)
             waitForRendering(greeter);
@@ -685,6 +871,9 @@
         }
 
         function test_greeterLoginsAutomaticallyWhenNoPasswordSet() {
+            loadShell("phone");
+            swipeAwayGreeter();
+
             sessionSpy.clear();
             verify(sessionSpy.valid);
 
@@ -694,6 +883,8 @@
         }
 
         function test_fullscreen() {
+            loadShell("phone");
+            swipeAwayGreeter();
             var panel = findChild(shell, "panel");
             compare(panel.fullscreenMode, false);
             ApplicationManager.startApplication("camera-app");
@@ -707,6 +898,8 @@
         }
 
         function test_leftEdgeDragFullscreen() {
+            loadShell("phone");
+            swipeAwayGreeter();
             var panel = findChild(shell, "panel");
             tryCompare(panel, "fullscreenMode", false)
 
@@ -728,6 +921,8 @@
         }
 
         function test_unlockedProperties() {
+            loadShell("phone");
+            swipeAwayGreeter();
             // Confirm that various properties have the correct values when unlocked
             var greeter = findChild(shell, "greeter");
             tryCompare(greeter, "locked", false);
@@ -740,10 +935,14 @@
         }
 
         function test_unlockAllModemsOnBoot() {
+            loadShell("phone");
+            swipeAwayGreeter();
             tryCompare(unlockAllModemsSpy, "count", 1)
         }
 
         function test_tapOnRightEdgeReachesApplicationSurface() {
+            loadShell("phone");
+            swipeAwayGreeter();
             var topmostSpreadDelegate = findChild(shell, "appDelegate0");
             var topmostSurface = findChild(topmostSpreadDelegate, "surfaceContainer").surface;
             var rightEdgeDragArea = findChild(shell, "spreadDragArea");
@@ -766,6 +965,8 @@
             by the right-edge drag area)
          */
         function test_rightEdgeDragDoesNotReachApplicationSurface() {
+            loadShell("phone");
+            swipeAwayGreeter();
             var topmostSpreadDelegate = findChild(shell, "appDelegate0");
             var topmostSurface = findChild(topmostSpreadDelegate, "surfaceContainer").surface;
             var rightEdgeDragArea = findChild(shell, "spreadDragArea");
@@ -810,6 +1011,8 @@
         }
 
         function test_tapUbuntuIconInLauncherOverAppSpread() {
+            loadShell("phone");
+            swipeAwayGreeter();
 
             waitUntilFocusedApplicationIsShowingItsSurface();
 
@@ -856,19 +1059,75 @@
         function test_background_data() {
             return [
                 {tag: "color", accounts: Qt.resolvedUrl("data:image/svg+xml,<svg><rect width='100%' height='100%' fill='#dd4814'/></svg>"), gsettings: "", output: Qt.resolvedUrl("data:image/svg+xml,<svg><rect width='100%' height='100%' fill='#dd4814'/></svg>")},
-                {tag: "empty", accounts: "", gsettings: "", output: shell.defaultBackground},
+                {tag: "empty", accounts: "", gsettings: "", output: "defaultBackground"},
                 {tag: "as-specified", accounts: Qt.resolvedUrl("../data/unity/backgrounds/blue.png"), gsettings: "", output: Qt.resolvedUrl("../data/unity/backgrounds/blue.png")},
                 {tag: "gs-specified", accounts: "", gsettings: Qt.resolvedUrl("../data/unity/backgrounds/red.png"), output: Qt.resolvedUrl("../data/unity/backgrounds/red.png")},
                 {tag: "both-specified", accounts: Qt.resolvedUrl("../data/unity/backgrounds/blue.png"), gsettings: Qt.resolvedUrl("../data/unity/backgrounds/red.png"), output: Qt.resolvedUrl("../data/unity/backgrounds/blue.png")},
                 {tag: "invalid-as", accounts: Qt.resolvedUrl("../data/unity/backgrounds/nope.png"), gsettings: Qt.resolvedUrl("../data/unity/backgrounds/red.png"), output: Qt.resolvedUrl("../data/unity/backgrounds/red.png")},
-                {tag: "invalid-both", accounts: Qt.resolvedUrl("../data/unity/backgrounds/nope.png"), gsettings: Qt.resolvedUrl("../data/unity/backgrounds/stillnope.png"), output: shell.defaultBackground},
+                {tag: "invalid-both", accounts: Qt.resolvedUrl("../data/unity/backgrounds/nope.png"), gsettings: Qt.resolvedUrl("../data/unity/backgrounds/stillnope.png"), output: "defaultBackground"},
             ]
         }
         function test_background(data) {
+            loadShell("phone");
+            swipeAwayGreeter();
             AccountsService.backgroundFile = data.accounts;
             var backgroundSettings = findInvisibleChild(shell, "backgroundSettings");
             backgroundSettings.pictureUri = data.gsettings;
-            tryCompare(shell, "background", data.output);
+
+            if (data.output === "defaultBackground") {
+                tryCompare(shell, "background", shell.defaultBackground);
+            } else {
+                tryCompare(shell, "background", data.output);
+            }
+        }
+
+        function test_tabletLogin_data() {
+            return [
+                {tag: "auth error", user: "auth-error", loggedIn: false, password: ""},
+                {tag: "with password", user: "has-password", loggedIn: true, password: "password"},
+                {tag: "without password", user: "no-password", loggedIn: true, password: ""},
+            ]
+        }
+
+        function test_tabletLogin(data) {
+            setLightDMMockMode("full");
+            loadShell("tablet");
+
+            selectUser(data.user);
+
+            clickPasswordInput(data.password === "" /* isButton */);
+
+            if (data.password !== "") {
+                typeString(data.password);
+                keyClick(Qt.Key_Enter);
+            }
+
+            confirmLoggedIn(data.loggedIn);
+        }
+
+        function test_appLaunchDuringGreeter_data() {
+            return [
+                {tag: "auth error", user: "auth-error", loggedIn: false, passwordFocus: false},
+                {tag: "without password", user: "no-password", loggedIn: true, passwordFocus: false},
+                {tag: "with password", user: "has-password", loggedIn: false, passwordFocus: true},
+            ]
+        }
+
+        function test_appLaunchDuringGreeter(data) {
+            setLightDMMockMode("full");
+            loadShell("tablet");
+
+            selectUser(data.user)
+
+            var greeter = findChild(shell, "greeter")
+            var app = ApplicationManager.startApplication("dialer-app")
+
+            confirmLoggedIn(data.loggedIn)
+
+            if (data.passwordFocus) {
+                var passwordInput = findChild(greeter, "passwordInput")
+                tryCompare(passwordInput, "focus", true)
+            }
         }
     }
 }

=== removed file 'tests/qmltests/tst_TabletShell.qml'
--- tests/qmltests/tst_TabletShell.qml	2015-02-09 15:24:48 +0000
+++ tests/qmltests/tst_TabletShell.qml	1970-01-01 00:00:00 +0000
@@ -1,304 +0,0 @@
-/*
- * Copyright (C) 2013,2014 Canonical, Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 3.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- */
-
-import QtQuick 2.0
-import QtTest 1.0
-import AccountsService 0.1
-import GSettings 1.0
-import LightDM 0.1 as LightDM
-import Ubuntu.Components 1.1
-import Ubuntu.Telephony 0.1 as Telephony
-import Unity.Application 0.1
-import Unity.Connectivity 0.1
-import Unity.Test 0.1 as UT
-import Powerd 0.1
-
-import "../../qml"
-
-Item {
-    id: root
-    width: units.gu(120)
-    height: units.gu(80)
-
-    Component.onCompleted: {
-        // must set the mock mode before loading the Shell
-        LightDM.Greeter.mockMode = "full";
-        LightDM.Users.mockMode = "full";
-        shellLoader.active = true;
-    }
-
-    QtObject {
-        id: applicationArguments
-
-        function hasGeometry() {
-            return false
-        }
-
-        function width() {
-            return 0
-        }
-
-        function height() {
-            return 0
-        }
-    }
-
-    Row {
-        anchors.fill: parent
-        Loader {
-            id: shellLoader
-
-            active: false
-            width: units.gu(100)
-            height: parent.height
-
-            property bool itemDestroyed: false
-            sourceComponent: Component {
-                Shell {
-                    property string indicatorProfile: "phone"
-
-                    Component.onDestruction: {
-                        shellLoader.itemDestroyed = true
-                    }
-                }
-            }
-        }
-
-        Rectangle {
-            color: "white"
-            width: units.gu(20)
-            height: parent.height
-
-            Column {
-                anchors { left: parent.left; right: parent.right; top: parent.top; margins: units.gu(1) }
-                spacing: units.gu(1)
-                Button {
-                    text: "Show Greeter"
-                    onClicked: {
-                        if (shellLoader.status !== Loader.Ready)
-                            return
-
-                        var greeter = testCase.findChild(shellLoader.item, "greeter")
-                        if (!greeter.shown) {
-                            greeter.show()
-                        }
-                    }
-                }
-                Button {
-                    text: "Demo edges"
-                    onClicked: {
-                        AccountsService.demoEdges = true;
-                    }
-                }
-            }
-        }
-    }
-
-    SignalSpy {
-        id: sessionSpy
-        signalName: "sessionStarted"
-    }
-
-    SignalSpy {
-        id: dashCommunicatorSpy
-        signalName: "setCurrentScopeCalled"
-    }
-
-    SignalSpy {
-        id: unlockAllModemsSpy
-        target: Connectivity
-        signalName: "unlockingAllModems"
-    }
-
-    Telephony.CallEntry {
-        id: phoneCall
-        phoneNumber: "[phone]"
-    }
-
-    UT.UnityTestCase {
-        id: testCase
-        name: "TabletShell"
-        when: windowShown
-
-        property Item shell: shellLoader.status === Loader.Ready ? shellLoader.item : null
-
-        function init() {
-            tryCompare(shell, "enabled", true); // will be enabled when greeter is all ready
-            var userList = findChild(shell, "userList");
-            tryCompare(userList, "movingInternally", false);
-            sessionSpy.clear()
-            sessionSpy.target = findChild(shell, "greeter")
-            dashCommunicatorSpy.target = findInvisibleChild(shell, "dashCommunicator")
-        }
-
-        function cleanup() {
-            tryCompare(shell, "enabled", true); // make sure greeter didn't leave us in disabled state
-
-            shellLoader.itemDestroyed = false
-
-            shellLoader.active = false
-
-            tryCompare(shellLoader, "status", Loader.Null)
-            tryCompare(shellLoader, "item", null)
-            // Loader.status might be Loader.Null and Loader.item might be null but the Loader
-            // item might still be alive. So if we set Loader.active back to true
-            // again right now we will get the very same Shell instance back. So no reload
-            // actually took place. Likely because Loader waits until the next event loop
-            // iteration to do its work. So to ensure the reload, we will wait until the
-            // Shell instance gets destroyed.
-            tryCompare(shellLoader, "itemDestroyed", true)
-
-            // kill all (fake) running apps
-            killApps()
-
-            unlockAllModemsSpy.clear()
-            AccountsService.demoEdges = false
-            LightDM.Greeter.authenticate(""); // reset greeter
-
-            // reload our test subject to get it in a fresh state once again
-            shellLoader.active = true
-
-            tryCompare(shellLoader, "status", Loader.Ready)
-            removeTimeConstraintsFromDirectionalDragAreas(shellLoader.item)
-        }
-
-        function killApps() {
-            while (ApplicationManager.count > 1) {
-                var appIndex = ApplicationManager.get(0).appId == "unity8-dash" ? 1 : 0
-                ApplicationManager.stopApplication(ApplicationManager.get(appIndex).appId)
-            }
-            compare(ApplicationManager.count, 1)
-        }
-
-        function selectIndex(i) {
-            // We could be anywhere in list; find target index to know which direction
-            var greeter = findChild(shell, "greeter")
-            var userlist = findChild(greeter, "userList")
-            if (userlist.currentIndex == i)
-                keyClick(Qt.Key_Escape) // Reset state if we're not moving
-            while (userlist.currentIndex != i) {
-                var next = userlist.currentIndex + 1
-                if (userlist.currentIndex > i) {
-                    next = userlist.currentIndex - 1
-                }
-                tap(findChild(greeter, "username"+next));
-                tryCompare(userlist, "currentIndex", next)
-                tryCompare(userlist, "movingInternally", false)
-            }
-        }
-
-        function selectUser(name) {
-            // Find index of user with the right name
-            for (var i = 0; i < LightDM.Users.count; i++) {
-                if (LightDM.Users.data(i, LightDM.UserRoles.NameRole) == name) {
-                    break
-                }
-            }
-            if (i == LightDM.Users.count) {
-                fail("Didn't find name")
-                return -1
-            }
-            selectIndex(i)
-            return i
-        }
-
-        function clickPasswordInput(isButton) {
-            var greeter = findChild(shell, "greeter")
-            tryCompare(greeter, "fullyShown", true);
-
-            var passwordMouseArea = findChild(shell, "passwordMouseArea")
-            tryCompare(passwordMouseArea, "enabled", isButton)
-
-            var passwordInput = findChild(shell, "passwordInput")
-            mouseClick(passwordInput)
-        }
-
-        function confirmLoggedIn(loggedIn) {
-            var greeter = findChild(shell, "greeter");
-            tryCompare(greeter, "shown", loggedIn ? false : true);
-            verify(loggedIn ? sessionSpy.count > 0 : sessionSpy.count === 0);
-        }
-
-        function swipeFromLeftEdge(swipeLength) {
-            var touchStartX = 2
-            var touchStartY = shell.height / 2
-            touchFlick(shell, touchStartX, touchStartY, swipeLength, touchStartY)
-        }
-
-        function test_login_data() {
-            return [
-                {tag: "auth error", user: "auth-error", loggedIn: false, password: ""},
-                {tag: "with password", user: "has-password", loggedIn: true, password: "password"},
-                {tag: "without password", user: "no-password", loggedIn: true, password: ""},
-            ]
-        }
-
-        function test_login(data) {
-            selectUser(data.user)
-
-            clickPasswordInput(data.password === "")
-
-            if (data.password !== "") {
-                typeString(data.password)
-                keyClick(Qt.Key_Enter)
-            }
-
-            confirmLoggedIn(data.loggedIn)
-        }
-
-        function test_appLaunchDuringGreeter_data() {
-            return [
-                {tag: "auth error", user: "auth-error", loggedIn: false, passwordFocus: false},
-                {tag: "without password", user: "no-password", loggedIn: true, passwordFocus: false},
-                {tag: "with password", user: "has-password", loggedIn: false, passwordFocus: true},
-            ]
-        }
-
-        function test_appLaunchDuringGreeter(data) {
-            selectUser(data.user)
-
-            var greeter = findChild(shell, "greeter")
-            var app = ApplicationManager.startApplication("dialer-app")
-
-            confirmLoggedIn(data.loggedIn)
-
-            if (data.passwordFocus) {
-                var passwordInput = findChild(greeter, "passwordInput")
-                tryCompare(passwordInput, "focus", true)
-            }
-        }
-
-        function test_leftEdgeDrag_data() {
-            return [
-                {tag: "without password", user: "no-password", loggedIn: true, demo: false},
-                {tag: "with password", user: "has-password", loggedIn: false, demo: false},
-                {tag: "with demo", user: "has-password", loggedIn: true, demo: true},
-            ]
-        }
-
-        function test_leftEdgeDrag(data) {
-            selectUser(data.user)
-
-            AccountsService.demoEdges = data.demo
-            var tutorial = findChild(shell, "tutorial");
-            tryCompare(tutorial, "running", data.demo);
-
-            swipeFromLeftEdge(shell.width * 0.75)
-            wait(500) // to give time to handle dash() signal from Launcher
-            confirmLoggedIn(data.loggedIn)
-        }
-    }
-}