Merge lp:~dandrader/unity8/surfaceItemFillMode into lp:unity8
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Michał Sawicz | ||||
Approved revision: | 2076 | ||||
Merged at revision: | 2080 | ||||
Proposed branch: | lp:~dandrader/unity8/surfaceItemFillMode | ||||
Merge into: | lp:unity8 | ||||
Diff against target: |
93 lines (+18/-4) 5 files modified
CMakeLists.txt (+1/-1) debian/control (+3/-3) qml/Stages/SurfaceContainer.qml (+1/-0) tests/mocks/Unity/Application/MirSurfaceItem.cpp (+8/-0) tests/mocks/Unity/Application/MirSurfaceItem.h (+5/-0) |
||||
To merge this branch: | bzr merge lp:~dandrader/unity8/surfaceItemFillMode | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michał Sawicz | Approve | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Review via email:
|
Commit message
MirSurfaceItem got a new property: fillMode
And put it to use in SurfaceContainer. That's the final piece to finally get rid of stretched windows
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
https:/
https:/
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable
* If you changed the UI, has there been a design review?
Not applicable
FAILED: Continuous integration, rev:2075 jenkins. qa.ubuntu. com/job/ unity8- ci/6843/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 5502/console jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- xenial- touch/258/ console jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- vivid/1554/ console jenkins. qa.ubuntu. com/job/ unity8- qmluitest- xenial- amd64/257/ console jenkins. qa.ubuntu. com/job/ unity8- vivid-amd64- ci/1449/ console jenkins. qa.ubuntu. com/job/ unity8- vivid-i386- ci/1449/ console jenkins. qa.ubuntu. com/job/ unity8- xenial- amd64-ci/ 256/console jenkins. qa.ubuntu. com/job/ unity8- xenial- i386-ci/ 255/console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 5516/console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- xenial- armhf/257/ console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/6843/ rebuild
http://