Merge lp:~dandrader/unity8/stopAnimatedSprite into lp:unity8
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Albert Astals Cid | ||||||||
Approved revision: | 2442 | ||||||||
Merged at revision: | 2501 | ||||||||
Proposed branch: | lp:~dandrader/unity8/stopAnimatedSprite | ||||||||
Merge into: | lp:unity8 | ||||||||
Diff against target: |
59 lines (+29/-14) 1 file modified
plugins/Cursor/Cursor.qml (+29/-14) |
||||||||
To merge this branch: | bzr merge lp:~dandrader/unity8/stopAnimatedSprite | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Unity8 CI Bot | continuous-integration | Approve | |
Albert Astals Cid (community) | Approve | ||
Lukáš Tinkl (community) | Needs Information | ||
Review via email:
|
Commit message
Cursor: Let AnimatedSprite run only on animated cursors and while the display is on
That awesome component would keep running even on single-frame animations (ie,
on non-animated cursors) triggering redraws or otherwise keeping CPU busy for nothing.
Also optimize things by using a regular and bug-free Image component to display
non-animated (single-frame) cursors.
A second optimization is to only load the cursor image at all if the device
has a mouse/touchpad in the first place.
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable
* If you changed the UI, has there been a design review?
Not applicable
FAILED: Continuous integration, rev:2442 /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/1492/ /unity8- jenkins. ubuntu. com/job/ build/1988/ console /unity8- jenkins. ubuntu. com/job/ build-0- fetch/2014/ console
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild: /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/1492/ rebuild
https:/