Unity 8

Merge lp:~dandrader/unity8/runningApps_lp1193419 into lp:unity8

  1. runningApps_lp1193419
  2. Merge into trunk
Proposed by Daniel d'Andrada
Status: Rejected
Rejected by: Daniel d'Andrada
Proposed branch: lp:~dandrader/unity8/runningApps_lp1193419
Merge into: lp:unity8
Prerequisite: lp:~dandrader/unity8/lp1116207
Diff against target: 160 lines (+81/-1)
6 files modified
Dash/DashApps.qml (+1/-0)
Dash/DashContent.qml (+1/-0)
Dash/GenericScopeView.qml (+3/-0)
Shell.qml (+1/-1)
tests/mocks/Unity/fake_applications_scope.cpp (+7/-0)
tests/qmltests/tst_Shell.qml (+68/-0)
To merge this branch: bzr merge lp:~dandrader/unity8/runningApps_lp1193419
Reviewer Review Type Date Requested Status
Michael Zanetti (community) Needs Fixing
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+177630@code.launchpad.net

This proposal supersedes a proposal from 2013-07-19.

Commit message

Reset apps scope when returning from app to dash (LP #1193419)

If an app is on foreground and you perform a long left-edge swipe to minimize it,
and therefore return to the dash, the dash should be in the Applications scope
and showing the running/recents applications.

Description of the change

Fixes bug #1193419.

The fix is a single line change. All the rest is about its regression test.

And no, it should not be an autopilot test. There's no need to have a fully-fledged, live, system to test this bug.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:130
http://jenkins.qa.ubuntu.com/job/unity8-ci/342/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1349/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/711/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/342/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/342/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1353/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/342/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:130
http://jenkins.qa.ubuntu.com/job/unity8-ci/344/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1353/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/714/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/344/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/344/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1357/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/344/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:130
http://jenkins.qa.ubuntu.com/job/unity8-ci/355/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1423/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/729/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/355/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/355/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1427/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/355/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:135
http://jenkins.qa.ubuntu.com/job/unity8-ci/410/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1563
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/794
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/410
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/410/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/410
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1567
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1567/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1321

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/410/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:135
http://jenkins.qa.ubuntu.com/job/unity8-ci/411/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1565
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/795
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/411
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/411/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/411
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1569
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1569/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1322

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/411/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:136
http://jenkins.qa.ubuntu.com/job/unity8-ci/414/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1579
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/802
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/414
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/414/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/414
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1583
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1583/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1336

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/414/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:136
http://jenkins.qa.ubuntu.com/job/unity8-ci/416/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1585
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/804
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/416
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/416/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/416
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1589
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1589/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1340

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/416/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:137
http://jenkins.qa.ubuntu.com/job/unity8-ci/419/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1592
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/807
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/419
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/419/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/419
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1596
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1596/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1347

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/419/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:136
http://jenkins.qa.ubuntu.com/job/unity8-ci/427/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1624
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/822
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/427
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/427/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/427
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1628
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1628/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1374

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/427/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:136
http://jenkins.qa.ubuntu.com/job/unity8-ci/433/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1636
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/832
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/433
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/433/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/433
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1640
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1640/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1386

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/433/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:136
http://jenkins.qa.ubuntu.com/job/unity8-ci/441/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1720
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/842
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/442
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/442/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/441/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1724
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1724/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1464

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/441/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:136
http://jenkins.qa.ubuntu.com/job/unity8-ci/448/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1743
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/850
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/449
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/449/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/448
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1747
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1747/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1485

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/448/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:137
http://jenkins.qa.ubuntu.com/job/unity8-ci/450/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1748
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/853
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/451
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/451/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/450/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1752
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1752/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1489

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/450/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:137
http://jenkins.qa.ubuntu.com/job/unity8-ci/506/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1925/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/931
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/507
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/507/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/506
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1930
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1930/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1644/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/506/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:137
http://jenkins.qa.ubuntu.com/job/unity8-ci/515/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1947
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/942
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/516
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/516/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/515
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1952
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1952/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1665

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/515/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:137
http://jenkins.qa.ubuntu.com/job/unity8-ci/621/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2209
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1072
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/622
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/622/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/621
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2215
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2215/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1879

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/621/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:137
http://jenkins.qa.ubuntu.com/job/unity8-ci/631/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2233
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1087/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/632
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/632/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/631
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2239
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2239/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1898

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/631/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:137
http://jenkins.qa.ubuntu.com/job/unity8-ci/743/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2538/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/187/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1270/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/744/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/743/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2544/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/189/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/743/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

lgtm

review: Approve
Revision history for this message
Michael Zanetti (mzanetti) wrote :

has conflicts tho...

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:137
http://jenkins.qa.ubuntu.com/job/unity8-ci/881/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2979/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/543/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1498/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/882/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/881/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/2985/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/545/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/881/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> has conflicts tho...

Updated.

Revision history for this message
Michael Zanetti (mzanetti) wrote :

lgtm

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:302
http://jenkins.qa.ubuntu.com/job/unity8-ci/926/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3088/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/649/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1566
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/927
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/927/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/926
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3094
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3094/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/651
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/651/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/926/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity8-autolanding/394/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/generic-cleanup-mbs/2048
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3124
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/685
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1583
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-autolanding/393
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-autolanding/393/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-autolanding/394
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3130
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3130/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2621
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/687
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/687/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/560
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/571

review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Re-approving to get a clean run after today's jenkins issues.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity8-autolanding/400/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/generic-cleanup-mbs/2056
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3131
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/692
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1589
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-autolanding/399
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-autolanding/399/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-autolanding/400
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3137
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3137/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2628
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/694
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/694/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/567
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/578

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity8-autolanding/410/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/generic-cleanup-mbs/2066
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3141
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/702
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1599
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-autolanding/409
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-autolanding/409/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-autolanding/410
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3147
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3147/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2638
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/704
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/704/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/576
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/587

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:308
http://jenkins.qa.ubuntu.com/job/unity8-ci/949/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3180
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/741
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1613
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/950
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/950/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/949
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3186
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3186/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2674
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/743
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/743/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/610
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/621

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/949/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

Merge has been reverted as it introduces a crash:

Launch an app and minimize it by swiping from the left edge to reproduce.

Also, as this crash only happens when NOT running with --fake, it did not get caught by our tests. Should we add an autopilot test for this?

review: Needs Fixing
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Made obsolete by https://code.launchpad.net/~aacid/unity8/unrevertlp1193419/+merge/188377

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Dash/DashApps.qml'
2--- Dash/DashApps.qml 2013-08-19 09:54:10 +0000
3+++ Dash/DashApps.qml 2013-09-09 14:42:27 +0000
4@@ -24,6 +24,7 @@
5
6 GenericScopeView {
7 id: scopeView
8+ objectName: "DashApps"
9
10 // FIXME: a way to aggregate these models would be ideal
11 property var mainStageApplicationsModel: shell.applicationManager.mainStageApplications
12
13=== modified file 'Dash/DashContent.qml'
14--- Dash/DashContent.qml 2013-07-23 09:28:14 +0000
15+++ Dash/DashContent.qml 2013-09-09 14:42:27 +0000
16@@ -114,6 +114,7 @@
17 height: ListView.view.height
18 asynchronous: true
19 source: scopeMapper.map(scope.id)
20+ objectName: scope.id + " loader"
21
22 // these are needed for autopilot tests
23 readonly property string scopeId: scope.id
24
25=== modified file 'Dash/GenericScopeView.qml'
26--- Dash/GenericScopeView.qml 2013-09-06 09:36:53 +0000
27+++ Dash/GenericScopeView.qml 2013-09-09 14:42:27 +0000
28@@ -29,6 +29,8 @@
29
30 onMovementStarted: categoryView.showHeader()
31
32+ onPositionedAtBeginning: categoryView.positionAtBeginning()
33+
34 Binding {
35 target: scopeView.scope
36 property: "searchQuery"
37@@ -45,6 +47,7 @@
38
39 ScopeListView {
40 id: categoryView
41+ objectName: "categoryListView"
42 anchors.fill: parent
43 model: scopeView.categories
44 forceNoClip: previewLoader.onScreen
45
46=== modified file 'Shell.qml'
47--- Shell.qml 2013-09-05 17:36:18 +0000
48+++ Shell.qml 2013-09-09 14:42:27 +0000
49@@ -640,7 +640,7 @@
50 }
51 onDash: {
52 if (stages.shown) {
53- dash.setCurrentScope("applications.scope", true, false)
54+ dash.setCurrentScope("applications.scope", true /* animate */, true /* reset */)
55 stages.hide();
56 launcher.hide();
57 }
58
59=== modified file 'tests/mocks/Unity/fake_applications_scope.cpp'
60--- tests/mocks/Unity/fake_applications_scope.cpp 2013-09-02 20:34:05 +0000
61+++ tests/mocks/Unity/fake_applications_scope.cpp 2013-09-09 14:42:27 +0000
62@@ -64,5 +64,12 @@
63 "grid",
64 hints);
65
66+ dee_model_append(category_model,
67+ "outdated",
68+ "Outdaded",
69+ "gtk-apply",
70+ "grid",
71+ hints);
72+
73 return category_model;
74 }
75
76=== modified file 'tests/qmltests/tst_Shell.qml'
77--- tests/qmltests/tst_Shell.qml 2013-08-20 22:43:13 +0000
78+++ tests/qmltests/tst_Shell.qml 2013-09-09 14:42:27 +0000
79@@ -56,6 +56,18 @@
80
81 function initTestCase() {
82 swipeAwayGreeter();
83+
84+ // Ensure DashHome is loaded before continuing
85+ var dashContentList = findChild(shell, "dashContentList");
86+ waitForRendering(dashContentList);
87+ var homeLoader = findChild(dashContentList, "home.scope loader");
88+ verify(homeLoader);
89+ tryCompareFunction(function() {return homeLoader.item !== undefined;}, true);
90+
91+ // FIXME: Desperate measure to ensure Jenkins has the scene graph fully loaded
92+ // before it calls the test functions (otherwise findChild calls will fail).
93+ // The code above just didn't solve it.
94+ wait(2000);
95 }
96
97 function cleanup() {
98@@ -213,6 +225,62 @@
99 tryCompare(dash, "visible", false);
100 }
101
102+ /*
103+ Regression test for bug https://bugs.launchpad.net/touch-preview-images/+bug/1193419
104+
105+ When the user minimizes an application (left-edge swipe) he should always end up in the "Running Apps"
106+ category of the "Applications" scope view.
107+
108+ Steps:
109+ - go to apps lens
110+ - scroll to the bottom
111+ - reveal launcher and launch an app
112+ - perform long left edge swipe to go minimize the app and go back to the dash.
113+
114+ Expected Results
115+ - apps lens shown and Running Apps visible on screen
116+ */
117+ function test_minimizingAppTakesToRunningApps() {
118+ var dashApps = findChild(shell, "DashApps");
119+
120+ swipeUntilScopeViewIsReached(dashApps);
121+
122+ // swipe finger up until the running/recent apps section (which we assume
123+ // it's the first one) is as far from view as possible.
124+ // We also assume that DashApps is tall enough that it's scrollable
125+ var appsCategoryListView = findChild(dashApps, "categoryListView");
126+ while (!appsCategoryListView.atYEnd) {
127+ swipeUpFromCenter();
128+ tryCompare(appsCategoryListView, "moving", false);
129+ }
130+
131+ // Switch away from the Applications scope.
132+ swipeRightFromCenter();
133+ waitUntilItemStopsMoving(dashApps);
134+ verify(!itemIsOnScreen(dashApps));
135+
136+ dragLauncherIntoView();
137+
138+ // Launch an app from the launcher
139+ tapOnAppIconInLauncher();
140+
141+ waitUntilApplicationWindowIsFullyVisible();
142+
143+ // Minimize the application we just launched
144+ swipeFromLeftEdge();
145+
146+ // Wait for the whole UI to settle down
147+ waitUntilApplicationWindowIsFullyHidden();
148+ waitUntilItemStopsMoving(dashApps);
149+ tryCompare(appsCategoryListView, "moving", false);
150+
151+ verify(itemIsOnScreen(dashApps));
152+
153+ var runningApplicationsGrid = findChild(appsCategoryListView, "recent");
154+ verify(runningApplicationsGrid);
155+ verify(itemIsOnScreen(runningApplicationsGrid));
156+ }
157+
158 // Wait for the whole UI to settle down
159 function waitForUIToSettle() {
160 waitUntilApplicationWindowIsFullyHidden();

Subscribers

People subscribed via source and target branches