Merge lp:~dandrader/unity8/outOfSourceTreeCardTests into lp:unity8

Proposed by Daniel d'Andrada
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 1234
Merged at revision: 1268
Proposed branch: lp:~dandrader/unity8/outOfSourceTreeCardTests
Merge into: lp:unity8
Diff against target: 16 lines (+3/-3)
1 file modified
tests/qmltests/Dash/tst_Card.qml (+3/-3)
To merge this branch: bzr merge lp:~dandrader/unity8/outOfSourceTreeCardTests
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Andrea Cimitan (community) Approve
Review via email: mp+233383@code.launchpad.net

Commit message

Make tst_Card work from outside the source tree (LP:1359201)

Currently it only works if you buid&run them from inside a subdir
of the unity8 source tree (ie, ./build).

If you build&run from a sibling directory it would not find the image
files and would therefore fail.

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.
No

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

* Did you make sure that your branch does not contain spurious tags?
Yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable

* If you changed the UI, has there been a design review?
Not applicable

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
y
* Did CI run pass? If not, please explain why.

Y

Tested, works fine

review: Approve
Revision history for this message
MichaƂ Sawicz (saviq) wrote :

Please run http://people.canonical.com/~msawicz/unity8/strip-u8-tags.py on this branch and any local checkouts you might have.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/qmltests/Dash/tst_Card.qml'
2--- tests/qmltests/Dash/tst_Card.qml 2014-08-22 14:43:02 +0000
3+++ tests/qmltests/Dash/tst_Card.qml 2014-09-04 15:47:06 +0000
4@@ -29,9 +29,9 @@
5
6 property string cardData: '
7 {
8- "art": "../../../tests/qmltests/Dash/artwork/music-player-design.png",
9- "mascot": "../../../tests/qmltests/Dash/artwork/avatar.png",
10- "emblem": "../../../tests/qmltests/Dash/artwork/emblem.png",
11+ "art": "'+Qt.resolvedUrl("artwork/music-player-design.png").toString()+'",
12+ "mascot": "'+Qt.resolvedUrl("artwork/avatar.png").toString()+'",
13+ "emblem": "'+Qt.resolvedUrl("artwork/emblem.png").toString()+'",
14 "title": "foo",
15 "subtitle": "bar",
16 "summary": "Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",

Subscribers

People subscribed via source and target branches