Merge lp:~dandrader/unity8/miral into lp:unity8

[Daniel d'Andrada]

Let the model deal with some window management decisions

eg: which window to focus, whether to change surface state

unity8 requests and reacts to changes in the model instead of applying them

Prereq-archive: ppa:ci-train-ppa-service/2160

For the upcoming, miral-powered, qtmir.

One notable introduction is the Window object, which is a sligthly higher level abstraction of a MirSurface (and a drop-in replacement for it) to be used by Stage.qml. Window always exists in a TopLevelWindowModel entry so that QML code no longer has to if(){}else{} for the existence of a MirSurface (because of the splash screen case)

* Are there any related MPs required for this MP to build/function as expected? Please list.

https://code.launchpad.net/~unity-team/unity-api/miral/+merge/309938
https://code.launchpad.net/~unity-team/qtmir/miral-qt-integration/+merge/312244

It's all in this silo: https://bileto.ubuntu.com/#/ticket/2160

* Did you perform an exploratory manual test run of your code change and any related functionality?

Yes.

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable

* If you changed the UI, has there been a design review?
Not applicable

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2674
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2465/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3241/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3269
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3123/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3123/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3123/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3123/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3123/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3123/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3123/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3123/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3123/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2465/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2675
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2476/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3265/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3293
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3147/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3147/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3147/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3147/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3147/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3147/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3147/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3147/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3147/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2476/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2697
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2485/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3277/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3305
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3159/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3159/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3159/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3159/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3159/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3159/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3159/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3159/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3159/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2485/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2697
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2487/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3279/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3307
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3161/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3161
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3161/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3161
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3161/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3161/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3161
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3161/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3161
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3161/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3161/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3161
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3161/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3161
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3161/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2487/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

* See a bunch of inline comments

* I think we should not give up on the differntiation between claimFocus() and requestFocus(). One of them says the stage wants to actually focus something *now* while the other indicates that the app requested focus on its own (or perhaps u-a-l did). IMO claimFocus() should not be dropped and still do the raisId() call on the model. requestfocus() instead should end up in the shell, and if the shell is ok with doing so, it should call claimFocus() itself.

* IMO you're exaggerating with the debug messages. unity8.toplevelsurfacelist was already very annoying and this seems to have even more prints. Sure, you can argue that I could turn them off with the debug filter, which is what I do, but then I get none any more while the most important ones like raise() added() and removed() would still make sense.

This has been a code review for the code up until the mocks. Still needs review for tests/mocks and especially in depth testing.

review: Needs Fixing

[Michael Zanetti (mzanetti)]

Not yet sure if just an issue in the mocks or not, but this breaks:

- open an app
- click the minimize button in the window decoration
- click the app again in the launcher to restore it
- now click the minimize button again
=> button doesn't work any more

review: Needs Fixing

[Daniel d'Andrada (dandrader)]

On 18/11/2016 12:29, Michael Zanetti wrote:
> * IMO you're exaggerating with the debug messages. unity8.toplevelsurfacelist was already very annoying and this seems to have even more prints. Sure, you can argue that I could turn them off with the debug filter, which is what I do, but then I get none any more while the most important ones like raise() added() and removed() would still make sense.

Reduced the logging output. Should be the way you prefer now.

[Michael Zanetti (mzanetti)]

- have 3 apps (a, b and c), make them overlap a bit for better visibility
- focus a by clicking it
- focus b by clicking it
- focus c by clicking it
- minimize c
=> a will be focused

expected: after minimizing c, b should be focused

review: Needs Fixing

[Daniel d'Andrada (dandrader)]

On 18/11/2016 12:29, Michael Zanetti wrote:
> * I think we should not give up on the differntiation between claimFocus() and requestFocus(). One of them says the stage wants to actually focus something*now* while the other indicates that the app requested focus on its own (or perhaps u-a-l did). IMO claimFocus() should not be dropped and still do the raisId() call on the model. requestfocus() instead should end up in the shell, and if the shell is ok with doing so, it should call claimFocus() itself.

What you are explaining effectively is that: leave things as they are
currently with regards to focus. Which means focus lives in unity8 and
miral has no say over it.

The whole point of this miral effort is exactly to move such window
management decisions down to Mir, as dictated by our high-profile
stakeholder.

On the bright side, focus requests made by unity8 should naturally
always be sensible (since it knows the situation pretty well) and
therefore miral should always swiftly comply. So in terms of end
results, those requests will work just like imperative assignments.

Focus is a central piece of window management and if miral is to do
anything useful it has to have a say in it. And we cannot have two
entities making decisions on focus (unity8 and miral) as it will
inevitably be racy and conflictive.

As for the origin of the focus change request (shell vs. application),
it doesn't matter from miral's standpoint. It will comply to either as
long the change is valid and makes sense. Eg.: it should never allow a
window blocked by a child modal dialog to be focused. So it's mostly
sanity checking. I don't see miral ignoring requests on a whim. :)

Besides, having two separate code paths would make unity8 code more
complex. Eg: Having both code that sets surface state and code that
responds to surface state changes. "If surface state change was done in
response my your own set(), do nothing, else, ponder and respond."

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2698
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2512/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3317/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3345
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3197/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3197
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3197/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3197
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3197/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3197/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3197
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3197/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3197
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3197/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3197/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3197
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3197/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3197
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3197/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2512/rebuild

review: Needs Fixing (continuous-integration)

[Daniel d'Andrada (dandrader)]

On 18/11/2016 12:29, Michael Zanetti wrote:
>> +int TopLevelWindowModel::nextFreeId(int candidateId)
>> >+{
>> >+ if (candidateId > m_maxId) {
>> >+ return nextFreeId(1);
>> >+ } else {
>> >+ if (indexForId(candidateId) == -1) {
>> >+ // it's indeed free
>> >+ return candidateId;
>> >+ } else {
>> >+ return nextFreeId(candidateId + 1);
>> >+ }
>> >+ }
>> >+}
> In the very unlikely event that we'd run out of free ids, this would crash with a stack overflow. Think it makes sense to write this in a non-recursive manner and perhaps add some way to actually handle failures?
>
If we run out of free ids it's because there's already a bug somewhere.
There's no way there's a valid situation where we would have literally a
million windows lying around.

But a non-recursive version is indeed lighter-weight on resources if it
ever has to traverse a long stretch of taken ids. Done.

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2699
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2513/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3318/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3346
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3198/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3198
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3198/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3198
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3198/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3198/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3198
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3198/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3198
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3198/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3198/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3198
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3198/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3198
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3198/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2513/rebuild

review: Needs Fixing (continuous-integration)

[Daniel d'Andrada (dandrader)]

On 18/11/2016 12:29, Michael Zanetti wrote:
>> +QString TopLevelWindowModel::toString()
>> >+{
>> >+ QString str;
>> >+ for (int i = 0; i < m_windowModel.count(); ++i) {
>> >+ auto item = m_windowModel.at(i);
>> >+
>> >+ QString itemStr = QString("(index=%1,appId=%2,surface=0x%3,id=%4)")
>> >+ .arg(i)
>> >+ .arg(item.application->appId())
>> >+ .arg((qintptr)item.window->surface(), 0, 16)
>> >+ .arg(item.window->id());
> it would be slightly more performant if you'd use QString::arg(QString, QString, QSttring, QString) instead as it has to walk the string only once with that...
>
Done.

[Daniel d'Andrada (dandrader)]

On 18/11/2016 12:29, Michael Zanetti wrote:
>> +public Q_SLOTS:
>> >+ /**
>> >+ * @brief Returns the surface at the given index
>> >+ *
>> >+ * It will be a nullptr if the application is still starting up and thus hasn't yet created
>> >+ * and drawn into a surface.
>> >+ *
>> >+ * Same as windowAt(index).surface()
>> >+ */
>> >+ unity::shell::application::MirSurfaceInterface *surfaceAt(int index) const;
>> >+
>> >+ /**
>> >+ * @brief Returns the window at the given index
>> >+ *
>> >+ * Will always be valid
>> >+ */
>> >+ Window *windowAt(int index) const;
>> >+
>> >+ /**
>> >+ * @brief Returns the application at the given index
>> >+ */
>> >+ unity::shell::application::ApplicationInfoInterface *applicationAt(int index) const;
>> >+
>> >+ /**
>> >+ * @brief Returns the unique id of the element at the given index
>> >+ */
>> >+ int idAt(int index) const;
>> >+
>> >+ /**
>> >+ * @brief Returns the index where the row with the given id is located
>> >+ *
>> >+ * Returns -1 if there's no row with the given id.
>> >+ */
>> >+ int indexForId(int id) const;
> slots with return value are weird. All the above should be public Q_INVOKABLE instead IMO.

Which uglifies the header file. Not great either.

Done.

>
>> >+
>> >+ /**
>> >+ * @brief Raises the row with the given id to the top of the window stack (index == count-1)
>> >+ */
>> >+ void raiseId(int id);
> this makes sense as slot indeed
>
But it's only a slot so it can be called from QML. Made it a Q_INVOKABLE
as well to match the others.

[Daniel d'Andrada (dandrader)]

On 18/11/2016 12:29, Michael Zanetti wrote:
>> +Window::Window(int id)
>> >+ : QObject(nullptr)
>> >+ , m_id(id)
>> >+{
>> >+ DEBUG_MSG << "()";
>> >+ QQmlEngine::setObjectOwnership(this, QQmlEngine::CppOwnership);
> is there a reason why you can't use QObject's parent instead?

Laziness. Done.

>
> Would make sense in any case to parent the Window objects properly IMO
>
Yes, that's a nice safety net.

[Daniel d'Andrada (dandrader)]

On 18/11/2016 12:29, Michael Zanetti wrote:
>> +QString Window::toString() const
>> >+{
>> >+ if (surface()) {
>> >+ return QString("Window[0x%1, id=%2, MirSurface[0x%3,\"%4\"]]")
>> >+ .arg((quintptr)this, 0, 16)
>> >+ .arg(id())
>> >+ .arg((quintptr)surface(), 0, 16)
>> >+ .arg(surface()->name());
> same here... if this is only ever executed in certain debug modes, ok with me, but if this is executed in production code too, please use the single .arg(..., ..., ...) call for better performance.
>
Done.

[Daniel d'Andrada (dandrader)]

On 18/11/2016 12:29, Michael Zanetti wrote:
>> + Q_PROPERTY(unity::shell::application::MirSurfaceInterface* surface READ surface NOTIFY surfaceChanged)
> gah I despise this overly excessive namespacing...

Me too! Nested namespaces are an eyesore.

> IMO you could just do "using namespace unity::shell::application;" and be done with this, really... It's not like we'd ever have a conflicting MirSurfaceInterface class somewhere else...
>
Not in a header file though. I think that's bad form. A .cpp file
#including this header would inadvertently get the
unity::shell::application namespace included in their main one.

I'm also scared of doing namespace manipulations in Qt macros. That
might go wrong.

[Daniel d'Andrada (dandrader)]

On 18/11/2016 12:29, Michael Zanetti wrote:
>> + qRegisterMetaType<Window*>("Window*");
> think it would make sense to qmlRegisterUncreatableType<Window>(...) too? Seems it would be useful API to be able to access Window from QML
>

Not sure. qmlRegisterUncreatableType() documentation says: "This is
useful where the type is only intended for providing attached properties
or enum values."
Not the case here.

[Daniel d'Andrada (dandrader)]

On 18/11/2016 12:29, Michael Zanetti wrote:
>> - onMinimizeClicked: root.minimizeClicked();
>> >+ onMinimizeClicked: {
>> >+ if (applicationWindow.surface) {
>> >+ applicationWindow.surface.requestState(Mir.MinimizedState);
>> >+ }
>> >+ }
> this seems odd... why would you refactor DecoratedWindow to not directly operate on the data any more but instead pass everything outside with signals in a earlier branch, but now start introducing this somewhat messy behavior here again? IMO this should also be passed to outside to the Stage, and only the stage being in charge to actually execute things on the surfaces.
>
That's some old change that pre-dates that branch you mentioned.
Reverted.

[Daniel d'Andrada (dandrader)]

On 18/11/2016 12:29, Michael Zanetti wrote:
>> - function focusNext() {
> same as I mentioned earlier. I'm still a bit scared of dropping control over this from the qml part, but lets see how it works... At least now that the model is part of unity8 again, it seems easier to change that back or modify in yet another way if we need to.
>
This is a perfect case where it makes sense to delegate to the C++
model. Choosing the next window do be focused when the current one is
minimized is a bunch of imperative code (and WM policy) that fits better
in C++ and not mixed with animation code in QML.

Particularly now that the model knows everything (who's focused and the
position and state of all surfaces).

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2700
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2514/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3319/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3347
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3199/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3199
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3199/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3199
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3199/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3199/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3199
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3199/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3199
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3199/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3199/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3199
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3199/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3199
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3199/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2514/rebuild

review: Needs Fixing (continuous-integration)

[Daniel d'Andrada (dandrader)]

On 18/11/2016 12:29, Michael Zanetti wrote:
>> if (!shown && priv.mainStageDelegate && !root.spreadShown) {
>> >- priv.mainStageDelegate.claimFocus();
>> >+ priv.mainStageDelegate.requestFocus();
> ok... given that requestFocus() effectively does claimFocus() now, this change totally makes sense... but we're losing the distinction between "the stage wants to focus something" and "an app requests focus by itsel (or something else than the stage)".
>
> Can you think of a way to keep that separation perhaps?
>
Heh, I actually think it is a good thing to handle them the same way (as
I said in some other comment).

[Daniel d'Andrada (dandrader)]

On 18/11/2016 12:29, Michael Zanetti wrote:
>> + function updateQmlFocusFromMirSurfaceFocus() {
>> >+ if (model.window.focused) {
>> > claimFocus();
>> >+ priv.focusedAppDelegate = appDelegate;
>> >+ //} else if (priv.focusedAppDelegate === appDelegate && root.state != "spread") {
>> >+ // priv.focusedAppDelegate = null;
> leftover?
>
Yes, removed.

[Daniel d'Andrada (dandrader)]

On 18/11/2016 12:29, Michael Zanetti wrote:
>> + onMaximizeHorizontallyClicked: {
>> >+ if (appDelegate.maximizedHorizontally)
>> >+ appDelegate.requestRestore();
>> >+ else
>> >+ appDelegate.requestMaximizeHorizontally();
>> >+ }
> {} missing
>
>> >+ onMaximizeVerticallyClicked: {
>> >+ if (appDelegate.maximizedVertically)
>> >+ appDelegate.requestRestore();
>> >+ else
>> >+ appDelegate.requestMaximizeVertically();
>> >+ }
> {} missing
>

Not sure if that's in our coding style but ok, added.

[Daniel d'Andrada (dandrader)]

On 18/11/2016 14:16, Michael Zanetti wrote:
> Review: Needs Fixing
>
> Not yet sure if just an issue in the mocks or not, but this breaks:
>
> - open an app
> - click the minimize button in the window decoration
> - click the app again in the launcher to restore it
> - now click the minimize button again
> => button doesn't work any more

Bug in the mock. Works with qtmir.

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2705
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2515/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3320/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3348
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3200/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3200
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3200/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3200
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3200/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3200/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3200
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3200/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3200
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3200/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3200/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3200
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3200/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3200
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3200/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2515/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2706
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2516/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3321/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3349
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3201/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3201
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3201/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3201
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3201/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3201/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3201
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3201/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3201
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3201/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3201/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3201
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3201/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3201
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3201/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2516/rebuild

review: Needs Fixing (continuous-integration)

[Michał Sawicz (saviq)]

>>>> - priv.mainStageDelegate.claimFocus();
>>>> >> >+ priv.mainStageDelegate.requestFocus();
>> > ok... given that requestFocus() effectively does claimFocus() now, this change totally makes sense... but we're losing the distinction between "the stage wants to focus something" and "an app requests focus by itsel (or something else than the stage)".
>> >
>> > Can you think of a way to keep that separation perhaps?
>> >
> Heh, I actually think it is a good thing to handle them the same way (as
> I said in some other comment).

How does focus stealing prevention come into play here? I believe the
plan was to only grant focus to apps that send along a ~MirCookie based
on a timestamp. I believe it's described here:

https://docs.google.com/document/d/1L85DdfDd3lDbvchYbgQ45C_lJ1IeTMG4uc7Nuq_XdAE/edit#heading=h.nlenkblnkaqq

[Michael Zanetti (mzanetti)]

On 18.11.2016 21:09, Daniel d'Andrada wrote:
> On 18/11/2016 12:29, Michael Zanetti wrote:
>>> + qRegisterMetaType<Window*>("Window*");
>> think it would make sense to qmlRegisterUncreatableType<Window>(...) too? Seems it would be useful API to be able to access Window from QML
>>
>
> Not sure. qmlRegisterUncreatableType() documentation says: "This is
> useful where the type is only intended for providing attached properties
> or enum values."
> Not the case here.

I'm more thinking about being able to access the Window type in QML
altogether. Not really about providing attached properties etc, but it
could make sense to do pass the Window object to somewhere in QML and
access its property there without having access to the model.

[Michael Zanetti (mzanetti)]

> On 18/11/2016 12:29, Michael Zanetti wrote:
> > * I think we should not give up on the differntiation between claimFocus()
> and requestFocus(). One of them says the stage wants to actually focus
> something*now* while the other indicates that the app requested focus on its
> own (or perhaps u-a-l did). IMO claimFocus() should not be dropped and still
> do the raisId() call on the model. requestfocus() instead should end up in the
> shell, and if the shell is ok with doing so, it should call claimFocus()
> itself.
>
> What you are explaining effectively is that: leave things as they are
> currently with regards to focus. Which means focus lives in unity8 and
> miral has no say over it.
>
> The whole point of this miral effort is exactly to move such window
> management decisions down to Mir, as dictated by our high-profile
> stakeholder.

There's a bunch of other stakeholders though that want to have it pixel perfect when it comes to animations and transitions. I am not saying miral should not have any say, but miral should send a requestFocus() to the shell and the shell will do it.
What I'm saying is that miral can tell unity to change the focus, and unity will follow that (unless it's in the middle of a transition or something). What you're proposing is that miral has all the say on when to change focus, and unity8 cannot do any course correction if the moment is bad.

> Focus is a central piece of window management and if miral is to do
> anything useful it has to have a say in it. And we cannot have two
> entities making decisions on focus (unity8 and miral) as it will
> inevitably be racy and conflictive.

which is exactly what we have now... unity8 thinks it is in charge, but miral can just jump in and trash it. I'm really just trying to avoid that.

>
> As for the origin of the focus change request (shell vs. application),
> it doesn't matter from miral's standpoint. It will comply to either as
> long the change is valid and makes sense. Eg.: it should never allow a
> window blocked by a child modal dialog to be focused. So it's mostly
> sanity checking. I don't see miral ignoring requests on a whim. :)
>
> Besides, having two separate code paths would make unity8 code more
> complex. Eg: Having both code that sets surface state and code that
> responds to surface state changes. "If surface state change was done in
> response my your own set(), do nothing, else, ponder and respond."

And I'm also not talking about 2 separate code paths. I'm saying the one code path should go through unity8 and not just manipulate the model at random.

Therefore I think only unity8 should manipulate the model, taking miral as consultant on how to manipulate it. This current approach is really the one that creates multiple entities fighting over the state of the model.

[Daniel d'Andrada (dandrader)]

On 18/11/2016 14:21, Michael Zanetti wrote:
> Review: Needs Fixing
>
> - have 3 apps (a, b and c), make them overlap a bit for better visibility
> - focus a by clicking it
> - focus b by clicking it
> - focus c by clicking it
> - minimize c
> => a will be focused
>
> expected: after minimizing c, b should be focused

Can't reproduce in "make tryDesktopStage". Need more specific steps
(like exact test and apps launched).

[Daniel d'Andrada (dandrader)]

On 21/11/2016 07:27, Michael Zanetti wrote:
>
> On 18.11.2016 21:09, Daniel d'Andrada wrote:
>> On 18/11/2016 12:29, Michael Zanetti wrote:
>>>> + qRegisterMetaType<Window*>("Window*");
>>> think it would make sense to qmlRegisterUncreatableType<Window>(...) too? Seems it would be useful API to be able to access Window from QML
>>>
>> Not sure. qmlRegisterUncreatableType() documentation says: "This is
>> useful where the type is only intended for providing attached properties
>> or enum values."
>> Not the case here.
> I'm more thinking about being able to access the Window type in QML
> altogether. Not really about providing attached properties etc, but it
> could make sense to do pass the Window object to somewhere in QML and
> access its property there without having access to the model.
>
>
This already happens in Stage.qml:

"""
x: model.window.position.x - decoratedWindow.contentX
y: model.window.position.y - decoratedWindow.contentY
"""

Looks like qmlRegisterUncreatableType() is not needed for that. If think
you only need it for Window.foo type of constructs.

[Daniel d'Andrada (dandrader)]

On 21/11/2016 06:48, Michał Sawicz wrote:
>>>>> - priv.mainStageDelegate.claimFocus();
>>>>>>>> + priv.mainStageDelegate.requestFocus();
>>>> ok... given that requestFocus() effectively does claimFocus() now, this change totally makes sense... but we're losing the distinction between "the stage wants to focus something" and "an app requests focus by itsel (or something else than the stage)".
>>>>
>>>> Can you think of a way to keep that separation perhaps?
>>>>
>> Heh, I actually think it is a good thing to handle them the same way (as
>> I said in some other comment).
> How does focus stealing prevention come into play here? I believe the
> plan was to only grant focus to apps that send along a ~MirCookie based
> on a timestamp. I believe it's described here:
>
> https://docs.google.com/document/d/1L85DdfDd3lDbvchYbgQ45C_lJ1IeTMG4uc7Nuq_XdAE/edit#heading=h.nlenkblnkaqq
>
>
This happens at a level lower than unity8. All unity8 knows and cares
about is that some surface in the model got focus.

[Michael Zanetti (mzanetti)]

On 21.11.2016 12:09, Daniel d'Andrada wrote:
> On 21/11/2016 07:27, Michael Zanetti wrote:
>>
>> On 18.11.2016 21:09, Daniel d'Andrada wrote:
>>> On 18/11/2016 12:29, Michael Zanetti wrote:
>>>>> + qRegisterMetaType<Window*>("Window*");
>>>> think it would make sense to qmlRegisterUncreatableType<Window>(...) too? Seems it would be useful API to be able to access Window from QML
>>>>
>>> Not sure. qmlRegisterUncreatableType() documentation says: "This is
>>> useful where the type is only intended for providing attached properties
>>> or enum values."
>>> Not the case here.
>> I'm more thinking about being able to access the Window type in QML
>> altogether. Not really about providing attached properties etc, but it
>> could make sense to do pass the Window object to somewhere in QML and
>> access its property there without having access to the model.
>>
>>
> This already happens in Stage.qml:
>
> """
> x: model.window.position.x - decoratedWindow.contentX
> y: model.window.position.y - decoratedWindow.contentY
> """
>
> Looks like qmlRegisterUncreatableType() is not needed for that. If think
> you only need it for Window.foo type of constructs.

Hmm, ok... fine then.

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2707
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2517/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3322/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3350
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3202/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3202
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3202/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3202
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3202/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3202/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3202
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3202/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3202
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3202/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3202/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3202
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3202/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3202
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3202/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2517/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

> On 18/11/2016 14:21, Michael Zanetti wrote:
> > Review: Needs Fixing
> >
> > - have 3 apps (a, b and c), make them overlap a bit for better visibility
> > - focus a by clicking it
> > - focus b by clicking it
> > - focus c by clicking it
> > - minimize c
> > => a will be focused
> >
> > expected: after minimizing c, b should be focused
>
>
> Can't reproduce in "make tryDesktopStage". Need more specific steps
> (like exact test and apps launched).

Hmm... I can't reproduce it any more either after your latest changes.

[Michael Zanetti (mzanetti)]

> On 18/11/2016 14:16, Michael Zanetti wrote:
> > Review: Needs Fixing
> >
> > Not yet sure if just an issue in the mocks or not, but this breaks:
> >
> > - open an app
> > - click the minimize button in the window decoration
> > - click the app again in the launcher to restore it
> > - now click the minimize button again
> > => button doesn't work any more
>
> Bug in the mock. Works with qtmir.

This is really why I think we need to move all those models to unity8, put unity8 in control of them and mock things at a lower level. All our tests regarding window management are just useless right now... they can perfectly pass while the real thing can be broken really badly.

[Daniel d'Andrada (dandrader)]

On 21/11/2016 10:08, Michael Zanetti wrote:
>> On 18/11/2016 14:16, Michael Zanetti wrote:
>>> Review: Needs Fixing
>>>
>>> Not yet sure if just an issue in the mocks or not, but this breaks:
>>>
>>> - open an app
>>> - click the minimize button in the window decoration
>>> - click the app again in the launcher to restore it
>>> - now click the minimize button again
>>> => button doesn't work any more
>> Bug in the mock. Works with qtmir.
> This is really why I think we need to move all those models to unity8, put unity8 in control of them and mock things at a lower level. All our tests regarding window management are just useless right now... they can perfectly pass while the real thing can be broken really badly.

Window management policy things like "if currently focused window gets
minimized, focus the most recently focused window that is not hidden or
minimized" will now belong to a lower level (miral) and as such they get
mock implementations in our tests.

Thus qml tests that strictly check window management policy will indeed
get redundant. Test of this nature now belong to miral's own test suite.

[Michael Zanetti (mzanetti)]

> On 21/11/2016 10:08, Michael Zanetti wrote:
> >> On 18/11/2016 14:16, Michael Zanetti wrote:
> >>> Review: Needs Fixing
> >>>
> >>> Not yet sure if just an issue in the mocks or not, but this breaks:
> >>>
> >>> - open an app
> >>> - click the minimize button in the window decoration
> >>> - click the app again in the launcher to restore it
> >>> - now click the minimize button again
> >>> => button doesn't work any more
> >> Bug in the mock. Works with qtmir.
> > This is really why I think we need to move all those models to unity8, put
> unity8 in control of them and mock things at a lower level. All our tests
> regarding window management are just useless right now... they can perfectly
> pass while the real thing can be broken really badly.
>
>
> Window management policy things like "if currently focused window gets
> minimized, focus the most recently focused window that is not hidden or
> minimized" will now belong to a lower level (miral) and as such they get
> mock implementations in our tests.
>
> Thus qml tests that strictly check window management policy will indeed
> get redundant. Test of this nature now belong to miral's own test suite.

Right, but we would still need tests that make sure that the QML part works together with the model as we expect it. And right now we don't have such tests... Anyhow, this is a different discussion than this particular merge proposal. It just once again popped up here. Also this isn't a new problem, we already had this since forever, but as long as we only had the one ApplicationManager model which would not even do much except moving things when unity8 said so, it was still easy enough to keep the mock close enough to the real thing. Now this seems to grow out of a manageable size.

[Gerry Boland (gerboland)]

> > On 18/11/2016 12:29, Michael Zanetti wrote:
> > > * I think we should not give up on the differntiation between claimFocus()
> > and requestFocus(). One of them says the stage wants to actually focus
> > something*now* while the other indicates that the app requested focus on
> its
> > own (or perhaps u-a-l did). IMO claimFocus() should not be dropped and still
> > do the raisId() call on the model. requestfocus() instead should end up in
> the
> > shell, and if the shell is ok with doing so, it should call claimFocus()
> > itself.
> >
> > What you are explaining effectively is that: leave things as they are
> > currently with regards to focus. Which means focus lives in unity8 and
> > miral has no say over it.
> >
> > The whole point of this miral effort is exactly to move such window
> > management decisions down to Mir, as dictated by our high-profile
> > stakeholder.
>
> There's a bunch of other stakeholders though that want to have it pixel
> perfect when it comes to animations and transitions. I am not saying miral
> should not have any say, but miral should send a requestFocus() to the shell
> and the shell will do it.
> What I'm saying is that miral can tell unity to change the focus, and unity
> will follow that (unless it's in the middle of a transition or something).
> What you're proposing is that miral has all the say on when to change focus,
> and unity8 cannot do any course correction if the moment is bad.
>
> > Focus is a central piece of window management and if miral is to do
> > anything useful it has to have a say in it. And we cannot have two
> > entities making decisions on focus (unity8 and miral) as it will
> > inevitably be racy and conflictive.
>
> which is exactly what we have now... unity8 thinks it is in charge, but miral
> can just jump in and trash it. I'm really just trying to avoid that.
>
> >
> > As for the origin of the focus change request (shell vs. application),
> > it doesn't matter from miral's standpoint. It will comply to either as
> > long the change is valid and makes sense. Eg.: it should never allow a
> > window blocked by a child modal dialog to be focused. So it's mostly
> > sanity checking. I don't see miral ignoring requests on a whim. :)
> >
> > Besides, having two separate code paths would make unity8 code more
> > complex. Eg: Having both code that sets surface state and code that
> > responds to surface state changes. "If surface state change was done in
> > response my your own set(), do nothing, else, ponder and respond."
>
> And I'm also not talking about 2 separate code paths. I'm saying the one code
> path should go through unity8 and not just manipulate the model at random.
>
> Therefore I think only unity8 should manipulate the model, taking miral as
> consultant on how to manipulate it. This current approach is really the one
> that creates multiple entities fighting over the state of the model.

This is a valid concern. The model must only have one owner. I think it safest that Unity8 has total ownership of the model and uses MirAL's recommendations only when it can.

MirAL has no concept of intermediary-states (like transitions/animations cause), so cannot advise Unit...

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2708
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2522/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3327/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3355
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3207/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3207/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3207/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3207/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3207/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3207/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3207/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3207/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3207/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2522/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2709
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2523/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3328/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3356
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3208/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3208/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3208/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3208/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3208/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3208/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3208/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3208/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3208/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2523/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2711
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2525/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3330/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3358
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3210/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3210/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3210/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3210/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3210/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3210/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3210/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3210/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3210/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2525/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

Thanks a lot for the activate() thing. Makes me feel much more comfy with the whole thing.

One minor thing (see inline comments) which I missed last time.

I'll give it another test with the latest changes, but it looks like we're getting close to an approval now.

review: Needs Fixing

[Daniel d'Andrada (dandrader)]

On 23/11/2016 09:24, Michael Zanetti wrote:
>> readonly property Item clientAreaItem: applicationWindow
>> >
>> >+ readonly property real contentX: applicationWindow.x
>> >+ readonly property real contentY: applicationWindow.y
> afaict, you're only using that for knowing how much to add/remove for the decoration height. There is already a property "decorationHeight" you can use so this would be not needed, esp as applicationWindow.y will always be 0 at this point too.
>
Actually I can just use the existing clientAreaItem property right above
them. Fixed.

[Daniel d'Andrada (dandrader)]

On 23/11/2016 09:24, Michael Zanetti wrote:
> Qt.point(appDelegate.requestedX + decoratedWindow.decorationHeight, appDelegate.requestedY)
>
> should be enough

I would rather not assume that decorations only affect the Y coordinate.

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2712
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2527/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3333/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3361
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3213/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3213/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3213/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3213/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3213/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3213/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3213/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3213/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3213/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2527/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2712
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2529/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3335/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3363
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3215/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3215/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3215/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3215/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3215/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3215/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3215/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3215/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3215/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2529/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2713
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2540/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3346/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3374
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3226/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3226/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3226/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3226/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3226/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3226/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3226/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3226/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3226/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2540/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2714
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2544/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3351/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3379
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3230/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3230/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3230/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3230/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3230/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3230/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3230/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3230/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3230/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2544/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2715
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2558/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3369/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3397
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3248/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3248/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3248/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3248/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3248
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3248/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3248
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3248/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3248/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3248/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3248/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2558/rebuild

review: Needs Fixing (continuous-integration)

[Lukáš Tinkl (lukas-kde)]

New instances of the same app do not cascade:

0. make tryShell
1. Launch dialer
2. Click the "+" button to launch a second instance
3. The new window doesn't cascade

review: Needs Fixing

[Lukáš Tinkl (lukas-kde)]

If you add a trust prompt to a window and launch a second instance of the same app, the newly created window is not focused

review: Needs Fixing

[Lukáš Tinkl (lukas-kde)]

Windows are not restored properly:

1. Maximize dash
2. Minimize it
3. Click the bfb icon
4. The dash window is restored to "normal" size, not to the maximized from step 1.

review: Needs Fixing

[Daniel d'Andrada (dandrader)]

On 29/11/2016 15:35, Lukáš Tinkl wrote:
> Review: Needs Fixing
>
> New instances of the same app do not cascade:
>
> 0. make tryShell
> 1. Launch dialer
> 2. Click the "+" button to launch a second instance
> 3. The new window doesn't cascade

Same happens in trunk

[Lukáš Tinkl (lukas-kde)]

Double click to maximize breaks:

1. Double click the dash decoration to maximize the window
2. Drag it down from the panel to restore it
3. Double click again to maximize -> no longer works

review: Needs Fixing

[Lukáš Tinkl (lukas-kde)]

In tablet mode, if you put a fullscreen app into side stage (like camera), the main app (dash usually) has its decoration cut at the top.

review: Needs Fixing

[Michael Zanetti (mzanetti)]

> In tablet mode, if you put a fullscreen app into side stage (like camera), the
> main app (dash usually) has its decoration cut at the top.

This happens in trunk too

[Daniel d'Andrada (dandrader)]

On 29/11/2016 15:37, Lukáš Tinkl wrote:
> Review: Needs Fixing
>
> If you add a trust prompt to a window and launch a second instance of the same app, the newly created window is not focused

Fixed. Bug in the Unity.Application mock.

[Daniel d'Andrada (dandrader)]

On 29/11/2016 15:39, Lukáš Tinkl wrote:
> Review: Needs Fixing
>
> Windows are not restored properly:
>
> 1. Maximize dash
> 2. Minimize it
> 3. Click the bfb icon
> 4. The dash window is restored to "normal" size, not to the maximized from step 1.

That's due to the simplicity of the Unity.Application mock. It doesn't
have a full blown implementation of the window management bits/policy
that have been now moved to a lower level, behind
Unity.Application/qtmir API. This use case works with the real
Unity.Application/qtmir.

Unfortunately this means that right now we can no longer test everything
window management related in our qmltests. For some things untiy8 just
sits back and expects to get the correct changes to the model for free,
which it will then respond to by updating the qml items and animating
the qml scene (the view).

To be more specific, in response to the click on step 3 unity8 just
calls MirSurface->activate(). qtmir/miral will take care of noticing
that this surface is minimized and will restore it to its previous state
before finally focusing and raising it.

[Daniel d'Andrada (dandrader)]

On 29/11/2016 15:50, Lukáš Tinkl wrote:
> Review: Needs Fixing
>
> Double click to maximize breaks:
>
> 1. Double click the dash decoration to maximize the window
> 2. Drag it down from the panel to restore it
> 3. Double click again to maximize -> no longer works

Fixed.

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2727
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2608/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3434/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3462
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3309/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3309/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3309/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3309/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3309/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3309/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2608/rebuild

review: Needs Fixing (continuous-integration)

[Lukáš Tinkl (lukas-kde)]

Doesn't compile any more (or run), need this patch: https://pastebin.kde.org/pipwxeqjp

review: Needs Fixing

[lp:~dandrader/unity8/miral]

2726. By Launchpad Translations on behalf of unity-team on 2016-12-01

Launchpad automatic translations update.

[Daniel d'Andrada (dandrader)]

On 30/11/2016 18:55, Lukáš Tinkl wrote:
> Review: Needs Fixing
>
> Doesn't compile any more (or run), need this patch: https://pastebin.kde.org/pipwxeqjp

Ooops! Fixed, thanks.

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2728
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2613/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3440/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3468
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3315/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3315/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3315
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3315/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3315
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3315/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3315/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3315/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2613/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2728
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2619/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3449/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3477
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3324/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3324
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3324/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3324/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3324
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3324/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3324/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3324
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3324/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2619/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2729
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2621/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3451/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3479
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3326/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3326
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3326/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3326/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3326
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3326/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3326/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3326
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3326/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2621/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2729
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2624/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3456/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3484
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3331/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3331/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3331/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3331/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3331/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3331/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2624/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2729
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2625/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3457
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1981
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/1981
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3485
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3332
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3332/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3332
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3332/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3332
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3332/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3332
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3332/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3332
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3332/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3332
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3332/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2625/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2730
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2626/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3458
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1982
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/1982
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3486
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3333
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3333/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3333
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3333/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3333
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3333/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3333
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3333/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3333
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3333/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3333
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3333/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2626/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2733
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2634/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3466
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1989
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/1989
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3494
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3341
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3341/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3341
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3341/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3341
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3341/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3341
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3341/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3341
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3341/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3341
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3341/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2634/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2734
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2637/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3469
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1991
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/1991
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3497
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3344
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3344/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3344
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3344/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3344
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3344/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3344
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3344/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3344
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3344/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3344
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3344/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2637/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2736
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2638/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3470
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1992
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/1992
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3498
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3345
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3345/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3345
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3345/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3345
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3345/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3345
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3345/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3345
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3345/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3345
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3345/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2638/rebuild

review: Needs Fixing (continuous-integration)

[Emanuele Antonio Faraone (emanueleant03)]

review: Approve

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2737
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2641/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3473
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1995
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/1995
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3501
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3348
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3348/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3348
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3348/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3348
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3348/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3348
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3348/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3348
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3348/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3348
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3348/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2641/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2738
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2643/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3475
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1997
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/1997
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3503
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3350
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3350/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3350
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3350/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3350
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3350/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3350
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3350/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3350
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3350/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3350
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3350/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2643/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2742
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2646/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2646/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2742
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2645/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3477
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1999
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/1999
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3505
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3352
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3352/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3352
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3352/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3352
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3352/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3352
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3352/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3352
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3352/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3352
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3352/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2645/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2743
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2648/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3481
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2001
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2001
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3509
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3356
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3356/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3356
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3356/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3356
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3356/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3356
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3356/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3356
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3356/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3356
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3356/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2648/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2744
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2651/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2651/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:2744
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2650/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3483
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2003
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2003
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3511
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3358
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3358/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3358
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3358/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3358
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3358/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3358
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3358/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3358
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3358/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3358
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3358/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2650/rebuild

review: Approve (continuous-integration)

[Lukáš Tinkl (lukas-kde)]

Looking good except this hard to track focus related issue:

https://imgur.com/a/ZcR0A

It can happen when an application is taking a long time to start up, and you close it before it does. At that point, the focus chain is broken and the user is left with no app/window focused at all (as can be seen from the empty window title in the top panel)

review: Needs Fixing

[Daniel d'Andrada (dandrader)]

> Looking good except this hard to track focus related issue:
>
> https://imgur.com/a/ZcR0A
>
> It can happen when an application is taking a long time to start up, and you
> close it before it does. At that point, the focus chain is broken and the user
> is left with no app/window focused at all (as can be seen from the empty
> window title in the top panel)

Fixed, thanks.

[Lukáš Tinkl (lukas-kde)]

In QString Window::toString() const:

I think what you're really after is this: http://doc.qt.io/qt-5/qdebug.html#writing-custom-types-to-a-stream

review: Needs Information

[Daniel d'Andrada (dandrader)]

On 06/12/2016 12:57, Lukáš Tinkl wrote:
> Review: Needs Information
>
> In QString Window::toString() const:
>
> I think what you're really after is this: http://doc.qt.io/qt-5/qdebug.html#writing-custom-types-to-a-stream

Already have it. It uses toString() in its implementation.

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2746
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2659/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3493
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2010
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2010
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3521
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3368
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3368/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3368
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3368/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3368
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3368/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3368
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3368/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3368
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3368/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3368
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3368/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2659/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2746
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2663/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3497/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3525
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3372
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3372/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3372
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3372/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3372
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3372/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3372
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3372/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3372
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3372/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3372/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2663/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:2746
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2665/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3499
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2015
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2015
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3527
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3374
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3374/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3374
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3374/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3374
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3374/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3374
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3374/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3374
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3374/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3374
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3374/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2665/rebuild

review: Approve (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2747
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2669/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3505/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3533
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3380/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3380/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3380/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3380/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3380/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3380/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2669/rebuild

review: Needs Fixing (continuous-integration)

[Lukáš Tinkl (lukas-kde)]

* Did you perform an exploratory manual test run of the code change and any related functionality?

Yes

* Did CI run pass? If not, please explain why.

Yes (they will again once the silo gets rebuilt)

review: Approve

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2748
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2670/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/3507/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3535
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3382/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3382/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3382/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3382/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3382/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3382/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2670/rebuild

review: Needs Fixing (continuous-integration)

[lp:~dandrader/unity8/miral]

2727. By Lukáš Tinkl on 2016-12-07

Fix the Super key not invoking the dash scope home (LP: #1607427)

Approved by: Daniel d'Andrada, Unity8 CI Bot

2728. By Albert Astals Cid on 2016-12-07

Add the Wsuggest-override flag to gcc

While at it mark system includes as such so we don't get warnings we can not fix

Approved by: Michael Zanetti, Unity8 CI Bot

2729. By Albert Astals Cid on 2016-12-07

Add support for compiler sanitizers via ECM

2730. By Albert Astals Cid on 2016-12-07

Use timeStep as delay time

Passing iterations / speed didn't make much sense since that parameter is a delay in milliseconds and the default parameters would give a value of 5 / units.gu(10) that is smaller than 1 millisecond.

Qt 5.7 calculation for velocity was very unhappy if we moved things so fast in less than 1ms and ignored the movements, so this also makes tests pass on Qt 5.7 (LP: #1642919)

Approved by: Josh Arenson, Unity8 CI Bot

2731. By Michael Zanetti on 2016-12-07

Add the ApplicationDrawer

Approved by: Lukáš Tinkl, Unity8 CI Bot

2732. By Michael Zanetti on 2016-12-07

tune right edge push

make it less intrusive when accidentally hitting the edge with the mouse
tweak visuals for the mouse case (LP: #1646094)

Approved by: Unity8 CI Bot

2733. By Michael Zanetti on 2016-12-07

improve close button visiblity when hovering with the mouse

Approved by: Albert Astals Cid, Unity8 CI Bot

2734. By Albert Astals Cid on 2016-12-07

Bring back fix for 1517830

Now with autotest \o/ (LP: #1517830)

Approved by: Andrea Cimitan, Unity8 CI Bot

2735. By Daniel d'Andrada on 2016-12-07

Fix "make tryApplicationWindow"

No surface was showing up on the screen
Also remove outdated button (feature is no longer there)

Approved by: Albert Astals Cid, Unity8 CI Bot

2736. By Albert Astals Cid on 2016-12-07

Fix compile warnings in mocks

Approved by: Daniel d'Andrada, Unity8 CI Bot

2737. By Josh Arenson on 2016-12-07

Enable the greeter to remember which session the user last logged into

This also fixes a small issue with how the default session was handled. (LP: #1631365)

Approved by: Albert Astals Cid, Unity8 CI Bot

2738. By Daniel d'Andrada on 2016-12-07

Take save/restore functions out of WindowResizeArea

They've no relationship with resizing whatsoever.

Approved by: Lukáš Tinkl, Unity8 CI Bot

2739. By Michael Zanetti on 2016-12-07

Update virtual touchpad visuals and add a tutorial. (LP: #1585220)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2740. By Albert Astals Cid on 2016-12-07

Do not hide panel when launching an application if the mouse is on the panel

Need Functions.itemUnderMouse because MouseArea.containsMouse returns true when tapping (i.e. no mouse used) on it.

Unfortunately the QML testlib do not set the proper value when issueing a mouseMove so i can't add a test that proofs it works, i'll try to propose something upstream and then add the test at a later MR (LP: #1591311)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2741. By Pete Woods on 2016-12-07

MenuItemFactory: Add subtitle support to SwitchItem widget

Approved by: Marco Trevisan (Treviño), Michał Sawicz, Unity8 CI Bot

2742. By CI Train Bot Account on 2016-12-07

Releasing 8.15+17.04.20161207.1-0ubuntu1

2743. By Daniel d'Andrada on 2016-12-12

Let the model deal with some window management decisions

eg: which window to focus, whether to change surface state

unit8 requests and reacts to changes in the model instead of applying them

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2016-10-24 11:34:08 +0000
+++ CMakeLists.txt	2016-12-12 16:49:02 +0000
@@ -40,6 +40,19 @@
   ENABLE_COVERAGE_REPORT(TARGETS ${SHELL_APP} FILTER /usr/include ${CMAKE_SOURCE_DIR}/tests/* ${CMAKE_BINARY_DIR}/*)
 endif()
 
+find_package (ECM 1.7.0 QUIET NO_MODULE)
+if (ECM_FOUND)
+    # Provides us with -DECM_ENABLE_SANITIZERS='X'
+    # Where X can be address, thread, memory, leak, undefined
+    include("${ECM_MODULE_DIR}/ECMEnableSanitizers.cmake")
+endif()
+
+if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+  if (NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS "5.0.0")
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsuggest-override" )
+  endif()
+endif()
+
 # Make sure we have all the needed symbols
 set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs")
 set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -Wl,-z,defs")
@@ -57,7 +70,7 @@
 find_package(Qt5Concurrent 5.4 REQUIRED)
 find_package(Qt5Sql 5.4 REQUIRED)
 
-pkg_check_modules(APPLICATION_API REQUIRED unity-shell-application=22)
+pkg_check_modules(APPLICATION_API REQUIRED unity-shell-application=23)
 pkg_check_modules(GEONAMES REQUIRED geonames>=0.2)
 pkg_check_modules(GIO REQUIRED gio-2.0>=2.32)
 pkg_check_modules(GLIB REQUIRED glib-2.0>=2.32)

=== modified file 'data/com.canonical.Unity8.gschema.xml'
--- data/com.canonical.Unity8.gschema.xml	2016-11-16 05:54:50 +0000
+++ data/com.canonical.Unity8.gschema.xml	2016-12-12 16:49:02 +0000
@@ -12,7 +12,7 @@
       <description>The usage mode chosen will affect the Window Management behaviour.</description>
     </key>
     <key type="y" name="edge-barrier-sensitivity">
-      <default>35</default>
+      <default>50</default>
       <range min="1" max="100"/>
       <summary>Sensitivity of screen edge barriers for the mouse pointer.</summary>
       <description>Some UI actions like revealing the launcher or the applications spread are triggered by pushing the mouse pointer against a screen edge. This key defines how much you have to push in order to trigger the associated action.</description>
@@ -23,7 +23,7 @@
       <description>How much you have to push  (in grid units)the mouse against an edge barrier when sensibility is 100.</description>
     </key>
     <key type="u" name="edge-barrier-max-push">
-      <default>60</default>
+      <default>120</default>
       <summary>Maximum push needed to overcome edge barrier</summary>
       <description>How much you have to push (in grid units) the mouse against an edge barrier when sensibility is 1.</description>
     </key>

=== modified file 'debian/changelog'
--- debian/changelog	2016-11-29 09:43:33 +0000
+++ debian/changelog	2016-12-12 16:49:02 +0000
@@ -1,3 +1,36 @@
+unity8 (8.15+17.04.20161207.1-0ubuntu1) zesty; urgency=medium
+
+  [ Albert Astals Cid ]
+  * Add the Wsuggest-override flag to gcc
+  * Add support for compiler sanitizers via ECM
+  * Use timeStep as delay time (LP: #1642919)
+  * Bring back fix for 1517830 (LP: #1517830)
+  * Fix compile warnings in mocks
+  * Do not hide panel when launching an application if the mouse is on
+    the panel (LP: #1591311)
+
+  [ Daniel d'Andrada ]
+  * Fix "make tryApplicationWindow"
+  * Take save/restore functions out of WindowResizeArea
+
+  [ Josh Arenson ]
+  * Enable the greeter to remember which session the user last logged
+    into (LP: #1631365)
+
+  [ Lukáš Tinkl ]
+  * Fix the Super key not invoking the dash scope home (LP: #1607427)
+
+  [ Michael Zanetti ]
+  * Add the ApplicationDrawer
+  * tune right edge push (LP: #1646094)
+  * improve close button visiblity when hovering with the mouse
+  * Update virtual touchpad visuals and add a tutorial. (LP: #1585220)
+
+  [ Pete Woods ]
+  * MenuItemFactory: Add subtitle support to SwitchItem widget
+
+ -- Michał Sawicz <[e-mail]>  Wed, 07 Dec 2016 13:49:24 +0000
+
 unity8 (8.15+17.04.20161129-0ubuntu1) zesty; urgency=medium
 
   [ Albert Astals Cid ]

=== modified file 'debian/control'
--- debian/control	2016-11-29 09:40:16 +0000
+++ debian/control	2016-12-12 16:49:02 +0000
@@ -38,7 +38,7 @@
                libubuntugestures5-private-dev (>= 1.3.2030),
                libudev-dev,
                libudm-common-dev,
-               libunity-api-dev (>= 7.120),
+               libunity-api-dev (>= 8.0),
                libusermetricsoutput1-dev,
 # Need those X11 libs touch emulation from mouse events in manual QML tests on a X11 desktop
                libx11-dev[!arm64 !armhf],
@@ -49,6 +49,7 @@
                python3-all:any,
                python3-setuptools,
                qml-module-qt-labs-folderlistmodel,
+               qml-module-qt-labs-settings,
                qml-module-qtqml-statemachine,
                qml-module-qtmultimedia (>= 5.4.1-1ubuntu19~overlay2),
                qml-module-qtquick-layouts,
@@ -122,6 +123,7 @@
          qmenumodel-qml (>= 0.2.10),
          qml-module-biometryd,
          qml-module-qt-labs-folderlistmodel,
+         qml-module-qt-labs-settings,
          qml-module-qtqml-statemachine,
          qml-module-qtquick-xmllistmodel,
          qml-module-qtsysteminfo,
@@ -160,7 +162,7 @@
          qttranslations5-l10n,
          ubuntu-thumbnailer-impl-0,
          ubuntu-wallpapers,
-         unity-application-impl-22,
+         unity-application-impl-23,
          unity-notifications-impl-3,
          unity-plugin-scopes | unity-scopes-impl,
          unity-scopes-impl-12,
@@ -206,7 +208,7 @@
 Depends: ${misc:Depends},
          ${shlibs:Depends},
 Provides: unity-application-impl,
-          unity-application-impl-22,
+          unity-application-impl-23,
 Replaces: unity8-autopilot (<< 8.02+15.04.20150422-0ubuntu1)
 Description: Fake environment for running Unity 8 shell
  Provides fake implementations of some QML modules used by Unity 8 shell

=== modified file 'plugins/Greeter/Unity/Launcher/CMakeLists.txt'
--- plugins/Greeter/Unity/Launcher/CMakeLists.txt	2016-10-28 12:08:59 +0000
+++ plugins/Greeter/Unity/Launcher/CMakeLists.txt	2016-12-12 16:49:02 +0000
@@ -1,4 +1,4 @@
-pkg_check_modules(LAUNCHER_API REQUIRED unity-shell-launcher=10)
+pkg_check_modules(LAUNCHER_API REQUIRED unity-shell-launcher=11)
 pkg_check_modules(GSETTINGS_QT REQUIRED gsettings-qt)
 
 add_definitions(-DSM_BUSNAME=systemBus)

=== modified file 'plugins/Greeter/Unity/Launcher/launcheritem.cpp'
--- plugins/Greeter/Unity/Launcher/launcheritem.cpp	2016-05-10 16:23:34 +0000
+++ plugins/Greeter/Unity/Launcher/launcheritem.cpp	2016-12-12 16:49:02 +0000
@@ -76,6 +76,19 @@
     }
 }
 
+QStringList LauncherItem::keywords() const
+{
+    return m_keywords;
+}
+
+void LauncherItem::setKeywords(const QStringList &keywords)
+{
+    if (m_keywords != keywords) {
+        m_keywords = keywords;
+        Q_EMIT keywordsChanged(keywords);
+    }
+}
+
 bool LauncherItem::pinned() const
 {
     return m_pinned;

=== modified file 'plugins/Greeter/Unity/Launcher/launcheritem.h'
--- plugins/Greeter/Unity/Launcher/launcheritem.h	2016-05-10 15:51:00 +0000
+++ plugins/Greeter/Unity/Launcher/launcheritem.h	2016-12-12 16:49:02 +0000
@@ -34,6 +34,7 @@
     QString appId() const override;
     QString name() const override;
     QString icon() const override;
+    QStringList keywords() const override;
     bool pinned() const override;
     bool running() const override;
     bool recent() const override;
@@ -49,6 +50,7 @@
 private:
     void setName(const QString &name);
     void setIcon(const QString &icon);
+    void setKeywords(const QStringList &keywords);
     void setPinned(bool pinned);
     void setRunning(bool running);
     void setRecent(bool recent);
@@ -63,6 +65,7 @@
     QString m_appId;
     QString m_name;
     QString m_icon;
+    QStringList m_keywords;
     bool m_pinned;
     bool m_running;
     bool m_recent;

=== modified file 'plugins/LightDM/FullLightDM/CMakeLists.txt'
--- plugins/LightDM/FullLightDM/CMakeLists.txt	2016-07-08 15:44:53 +0000
+++ plugins/LightDM/FullLightDM/CMakeLists.txt	2016-12-12 16:49:02 +0000
@@ -6,8 +6,12 @@
 
 include_directories(
     ../
+    ${CMAKE_CURRENT_BINARY_DIR}
+    )
+
+include_directories(
+    SYSTEM
     ${LIBLIGHTDM_INCLUDE_DIRS}
-    ${CMAKE_CURRENT_BINARY_DIR}
     )
 
 foreach(source_file ${QMLPLUGIN_SRC})

=== modified file 'plugins/Unity/Indicators/CMakeLists.txt'
--- plugins/Unity/Indicators/CMakeLists.txt	2016-06-02 09:32:33 +0000
+++ plugins/Unity/Indicators/CMakeLists.txt	2016-12-12 16:49:02 +0000
@@ -11,6 +11,9 @@
 include_directories(
     SYSTEM
     ${GLIB_INCLUDE_DIRS}
+)
+include_directories(
+    SYSTEM
     ${GIO_INCLUDE_DIRS}
     ${QMENUMODEL_INCLUDE_DIRS}
 )

=== modified file 'plugins/Unity/Launcher/CMakeLists.txt'
--- plugins/Unity/Launcher/CMakeLists.txt	2016-10-28 12:08:59 +0000
+++ plugins/Unity/Launcher/CMakeLists.txt	2016-12-12 16:49:02 +0000
@@ -1,4 +1,4 @@
-pkg_check_modules(LAUNCHER_API REQUIRED unity-shell-launcher=10)
+pkg_check_modules(LAUNCHER_API REQUIRED unity-shell-launcher=11)
 pkg_check_modules(GSETTINGS_QT REQUIRED gsettings-qt)
 
 add_definitions(-DSM_BUSNAME=systemBus)
@@ -25,6 +25,8 @@
     dbusinterface.cpp
     gsettings.cpp
     asadapter.cpp
+    appdrawermodel.cpp
+    ualwrapper.cpp
     ${CMAKE_SOURCE_DIR}/plugins/AccountsService/AccountsServiceDBusAdaptor.cpp
     ${APPLICATION_API_INCLUDEDIR}/unity/shell/application/ApplicationManagerInterface.h
     ${APPLICATION_API_INCLUDEDIR}/unity/shell/application/ApplicationInfoInterface.h
@@ -32,6 +34,7 @@
     ${LAUNCHER_API_INCLUDEDIR}/unity/shell/launcher/LauncherItemInterface.h
     ${LAUNCHER_API_INCLUDEDIR}/unity/shell/launcher/LauncherModelInterface.h
     ${LAUNCHER_API_INCLUDEDIR}/unity/shell/launcher/QuickListModelInterface.h
+    ${LAUNCHER_API_INCLUDEDIR}/unity/shell/launcher/AppDrawerModelInterface.h
     )
 
 add_library(UnityLauncher-qml MODULE

=== added file 'plugins/Unity/Launcher/appdrawermodel.cpp'
--- plugins/Unity/Launcher/appdrawermodel.cpp	1970-01-01 00:00:00 +0000
+++ plugins/Unity/Launcher/appdrawermodel.cpp	2016-12-12 16:49:02 +0000
@@ -0,0 +1,62 @@
+/*
+ * Copyright (C) 2016 Canonical, Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "appdrawermodel.h"
+#include "ualwrapper.h"
+
+#include <QDebug>
+#include <QDateTime>
+
+AppDrawerModel::AppDrawerModel(QObject *parent):
+    AppDrawerModelInterface(parent)
+{
+    Q_FOREACH (const QString &appId, UalWrapper::installedApps()) {
+        UalWrapper::AppInfo info = UalWrapper::getApplicationInfo(appId);
+        if (!info.valid) {
+            qWarning() << "Failed to get app info for app" << appId;
+            continue;
+        }
+        m_list.append(new LauncherItem(appId, info.name, info.icon, this));
+        m_list.last()->setKeywords(info.keywords);
+    }
+    qsrand(QDateTime::currentMSecsSinceEpoch() / 100);
+}
+
+int AppDrawerModel::rowCount(const QModelIndex &parent) const
+{
+    Q_UNUSED(parent)
+    return m_list.count();
+}
+
+QVariant AppDrawerModel::data(const QModelIndex &index, int role) const
+{
+    switch (role) {
+    case RoleAppId:
+        return m_list.at(index.row())->appId();
+    case RoleName:
+        return m_list.at(index.row())->name();
+    case RoleIcon:
+        return m_list.at(index.row())->icon();
+    case RoleKeywords:
+        return m_list.at(index.row())->keywords();
+    case RoleUsage:
+        // FIXME: u-a-l needs to provide API for usage stats.
+        // don't forget to drop the qsrand() call in the ctor when dropping this.
+        return qrand();
+    }
+
+    return QVariant();
+}

=== added file 'plugins/Unity/Launcher/appdrawermodel.h'
--- plugins/Unity/Launcher/appdrawermodel.h	1970-01-01 00:00:00 +0000
+++ plugins/Unity/Launcher/appdrawermodel.h	2016-12-12 16:49:02 +0000
@@ -0,0 +1,33 @@
+/*
+ * Copyright (C) 2016 Canonical, Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+
+#include <unity/shell/launcher/AppDrawerModelInterface.h>
+
+#include "launcheritem.h"
+
+class AppDrawerModel: public AppDrawerModelInterface
+{
+    Q_OBJECT
+public:
+    AppDrawerModel(QObject* parent = nullptr);
+
+    int rowCount(const QModelIndex &parent) const override;
+    QVariant data(const QModelIndex &index, int role) const override;
+
+private:
+    QList<LauncherItem*> m_list;
+};

=== modified file 'plugins/Unity/Launcher/launcheritem.cpp'
--- plugins/Unity/Launcher/launcheritem.cpp	2016-10-28 11:54:16 +0000
+++ plugins/Unity/Launcher/launcheritem.cpp	2016-12-12 16:49:02 +0000
@@ -90,6 +90,19 @@
     }
 }
 
+QStringList LauncherItem::keywords() const
+{
+    return m_keywords;
+}
+
+void LauncherItem::setKeywords(const QStringList &keywords)
+{
+    if (m_keywords != keywords) {
+        m_keywords = keywords;
+        Q_EMIT keywordsChanged(keywords);
+    }
+}
+
 bool LauncherItem::pinned() const
 {
     return m_pinned;

=== modified file 'plugins/Unity/Launcher/launcheritem.h'
--- plugins/Unity/Launcher/launcheritem.h	2016-05-10 15:51:00 +0000
+++ plugins/Unity/Launcher/launcheritem.h	2016-12-12 16:49:02 +0000
@@ -37,6 +37,7 @@
     QString appId() const override;
     QString name() const override;
     QString icon() const override;
+    QStringList keywords() const override;
     bool pinned() const override;
     bool running() const override;
     bool recent() const override;
@@ -52,6 +53,7 @@
 private:
     void setName(const QString &name);
     void setIcon(const QString &icon);
+    void setKeywords(const QStringList &keywords);
     void setPinned(bool pinned);
     void setRunning(bool running);
     void setRecent(bool recent);
@@ -66,6 +68,7 @@
     QString m_appId;
     QString m_name;
     QString m_icon;
+    QStringList m_keywords;
     bool m_pinned;
     bool m_running;
     bool m_recent;
@@ -79,6 +82,7 @@
     QuickListEntry m_quitAction;
 
     friend class LauncherModel;
+    friend class AppDrawerModel;
 };
 
 #endif // LAUNCHERITEM_H

=== modified file 'plugins/Unity/Launcher/launchermodel.cpp'
--- plugins/Unity/Launcher/launchermodel.cpp	2016-09-23 15:10:26 +0000
+++ plugins/Unity/Launcher/launchermodel.cpp	2016-12-12 16:49:02 +0000
@@ -19,18 +19,14 @@
 #include "gsettings.h"
 #include "dbusinterface.h"
 #include "asadapter.h"
+#include "ualwrapper.h"
 
-#include <ubuntu-app-launch/appid.h>
-#include <ubuntu-app-launch/application.h>
-#include <ubuntu-app-launch/registry.h>
 #include <unity/shell/application/ApplicationInfoInterface.h>
 #include <unity/shell/application/MirSurfaceListInterface.h>
 
 #include <QDesktopServices>
 #include <QDebug>
 
-namespace ual = ubuntu::app_launch;
-
 using namespace unity::shell::application;
 
 LauncherModel::LauncherModel(QObject *parent):
@@ -38,8 +34,7 @@
     m_settings(new GSettings(this)),
     m_dbusIface(new DBusInterface(this)),
     m_asAdapter(new ASAdapter()),
-    m_appManager(nullptr),
-    m_ualRegistry(std::make_shared<ual::Registry>())
+    m_appManager(nullptr)
 {
     connect(m_dbusIface, &DBusInterface::countChanged, this, &LauncherModel::countChanged);
     connect(m_dbusIface, &DBusInterface::countVisibleChanged, this, &LauncherModel::countVisibleChanged);
@@ -159,7 +154,7 @@
             index = m_list.count();
         }
 
-        auto appInfo = getApplicationInfo(appId);
+        UalWrapper::AppInfo appInfo = UalWrapper::getApplicationInfo(appId);
         if (!appInfo.valid) {
             qWarning() << "Can't pin application, appId not found:" << appId;
             return;
@@ -335,32 +330,6 @@
     return -1;
 }
 
-LauncherModel::AppInfo LauncherModel::getApplicationInfo(const QString &appId)
-{
-    AppInfo info;
-
-    ual::AppID ualAppId = ual::AppID::find(m_ualRegistry, appId.toStdString());
-    if (ualAppId.empty()) {
-        return info;
-    }
-
-    std::shared_ptr<ual::Application> ualApp;
-    try
-    {
-        ualApp = ual::Application::create(ualAppId, m_ualRegistry);
-    }
-    catch (std::runtime_error &e)
-    {
-        qWarning() << "Couldn't find application info for" << appId << "-" << e.what();
-        return info;
-    }
-
-    info.valid = true;
-    info.name = QString::fromStdString(ualApp->info()->name());
-    info.icon = QString::fromStdString(ualApp->info()->iconPath());
-    return info;
-}
-
 void LauncherModel::progressChanged(const QString &appId, int progress)
 {
     const int idx = findApplication(appId);
@@ -408,7 +377,7 @@
         }
     } else {
         // Need to create a new LauncherItem and show the highlight
-        auto appInfo = getApplicationInfo(appId);
+        UalWrapper::AppInfo appInfo = UalWrapper::getApplicationInfo(appId);
         if (countVisible && appInfo.valid) {
             LauncherItem *item = new LauncherItem(appId,
                                                   appInfo.name,
@@ -428,7 +397,7 @@
     // First walk through all the existing items and see if we need to remove something
     QList<LauncherItem*> toBeRemoved;
     Q_FOREACH (LauncherItem* item, m_list) {
-        auto appInfo = getApplicationInfo(item->appId());
+        UalWrapper::AppInfo appInfo = UalWrapper::getApplicationInfo(item->appId());
         if (!appInfo.valid) {
             // Application no longer available => drop it!
             toBeRemoved << item;
@@ -480,7 +449,7 @@
         if (itemIndex == -1) {
             // Need to add it. Just add it into the addedIndex to keep same ordering as the list
             // in the settings.
-            auto appInfo = getApplicationInfo(entry);
+            UalWrapper::AppInfo appInfo = UalWrapper::getApplicationInfo(entry);
             if (!appInfo.valid) {
                 continue;
             }

=== modified file 'plugins/Unity/Launcher/launchermodel.h'
--- plugins/Unity/Launcher/launchermodel.h	2016-09-23 14:44:26 +0000
+++ plugins/Unity/Launcher/launchermodel.h	2016-12-12 16:49:02 +0000
@@ -27,12 +27,6 @@
 class DBusInterface;
 class ASAdapter;
 
-namespace ubuntu {
-    namespace app_launch {
-        class Registry;
-    }
-}
-
 using namespace unity::shell::launcher;
 using namespace unity::shell::application;
 
@@ -73,13 +67,6 @@
 
     void unpin(const QString &appId);
 
-    struct AppInfo {
-        bool valid = false;
-        QString name;
-        QString icon;
-    };
-    AppInfo getApplicationInfo(const QString &appId);
-
 private Q_SLOTS:
     void countChanged(const QString &appId, int count);
     void countVisibleChanged(const QString &appId, bool count);
@@ -98,7 +85,6 @@
     ASAdapter *m_asAdapter;
 
     ApplicationManagerInterface *m_appManager;
-    std::shared_ptr<ubuntu::app_launch::Registry> m_ualRegistry;
 
     friend class LauncherModelTest;
 };

=== modified file 'plugins/Unity/Launcher/plugin.cpp'
--- plugins/Unity/Launcher/plugin.cpp	2015-09-14 09:11:08 +0000
+++ plugins/Unity/Launcher/plugin.cpp	2016-12-12 16:49:02 +0000
@@ -26,7 +26,7 @@
 // local
 #include "launchermodel.h"
 #include "launcheritem.h"
-
+#include "appdrawermodel.h"
 
 using namespace unity::shell::launcher;
 
@@ -46,4 +46,5 @@
     qmlRegisterSingletonType<LauncherModel>(uri, 0, 1, "LauncherModel", modelProvider);
     qmlRegisterUncreatableType<LauncherItem>(uri, 0, 1, "LauncherItem", QStringLiteral("Can't create new Launcher Items in QML. Get them from the LauncherModel."));
     qmlRegisterUncreatableType<QuickListModel>(uri, 0, 1, "QuickListModel", QStringLiteral("Can't create a QuickListModel in QML. Get them from the LauncherItems."));
+    qmlRegisterType<AppDrawerModel>(uri, 0, 1, "AppDrawerModel");
 }

=== added file 'plugins/Unity/Launcher/ualwrapper.cpp'
--- plugins/Unity/Launcher/ualwrapper.cpp	1970-01-01 00:00:00 +0000
+++ plugins/Unity/Launcher/ualwrapper.cpp	2016-12-12 16:49:02 +0000
@@ -0,0 +1,73 @@
+/*
+ * Copyright (C) 2016 Canonical, Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <QDebug>
+
+#include "ualwrapper.h"
+
+#include <ubuntu-app-launch/registry.h>
+using namespace ubuntu::app_launch;
+
+UalWrapper::UalWrapper(QObject *parent):
+    QObject(parent)
+{
+
+}
+
+QStringList UalWrapper::installedApps()
+{
+    QStringList appIds;
+    try {
+        for (const std::shared_ptr<Application> &app : Registry::installedApps()) {
+            if (!app->appId().package.value().empty()) {
+                appIds << QString::fromStdString(app->appId().package.value() + "_" + app->appId().appname.value());
+            } else {
+                appIds << QString::fromStdString(app->appId().appname);
+            }
+        }
+    } catch (const std::runtime_error &e) {
+        qWarning() << "ubuntu-all-launch threw an exception listing apps:" << e.what();
+    }
+
+    return appIds;
+}
+
+UalWrapper::AppInfo UalWrapper::getApplicationInfo(const QString &appId)
+{
+    AppInfo info;
+
+    try {
+        AppID ualAppId = AppID::find(appId.toStdString());
+        if (ualAppId.empty()) {
+            qWarning() << "Empty ualAppId result for" << appId;
+            return info;
+        }
+
+        std::shared_ptr<Application> ualApp;
+        ualApp = Application::create(ualAppId, Registry::getDefault());
+
+        info.name = QString::fromStdString(ualApp->info()->name());
+        info.icon = QString::fromStdString(ualApp->info()->iconPath());
+        for (const std::string &keyword : ualApp->info()->keywords().value()) {
+            info.keywords << QString::fromStdString(keyword);
+        }
+        info.valid = true;
+    } catch (const std::runtime_error &e) {
+        qWarning() << "ubuntu-app-launch threw an exception getting app info for appId:" << appId << ":" << e.what();
+    }
+
+    return info;
+}

=== added file 'plugins/Unity/Launcher/ualwrapper.h'
--- plugins/Unity/Launcher/ualwrapper.h	1970-01-01 00:00:00 +0000
+++ plugins/Unity/Launcher/ualwrapper.h	2016-12-12 16:49:02 +0000
@@ -0,0 +1,35 @@
+/*
+ * Copyright (C) 2016 Canonical, Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <QObject>
+
+class UalWrapper: public QObject
+{
+    Q_OBJECT
+public:
+    struct AppInfo {
+        bool valid = false;
+        QString name;
+        QString icon;
+        QStringList keywords;
+    };
+
+    UalWrapper(QObject* parent = nullptr);
+
+    static QStringList installedApps();
+    static AppInfo getApplicationInfo(const QString &appId);
+
+};

=== modified file 'plugins/Utils/CMakeLists.txt'
--- plugins/Utils/CMakeLists.txt	2016-06-29 18:05:44 +0000
+++ plugins/Utils/CMakeLists.txt	2016-12-12 16:49:02 +0000
@@ -15,6 +15,10 @@
     ${APPLICATION_API_INCLUDEDIR}/unity/shell/application/ApplicationManagerInterface.h
     ${APPLICATION_API_INCLUDEDIR}/unity/shell/application/ApplicationInfoInterface.h
     applicationsfiltermodel.cpp
+    ${LAUNCHER_API_INCLUDEDIR}/unity/shell/launcher/AppDrawerModelInterface.h
+    ${LAUNCHER_API_INCLUDEDIR}/unity/shell/launcher/LauncherItemInterface.h
+    ${LAUNCHER_API_INCLUDEDIR}/unity/shell/launcher/LauncherModelInterface.h
+    appdrawerproxymodel.cpp
     constants.cpp
     WindowInputMonitor.cpp
     inputwatcher.cpp

=== modified file 'plugins/Utils/ElapsedTimer.h'
--- plugins/Utils/ElapsedTimer.h	2015-04-22 10:40:54 +0000
+++ plugins/Utils/ElapsedTimer.h	2016-12-12 16:49:02 +0000
@@ -41,7 +41,7 @@
 public:
     void start() override { m_timer.start(); }
     qint64 msecsSinceReference() const override { return m_timer.msecsSinceReference(); }
-    qint64 elapsed() const override { return m_timer.elapsed(); }
+    qint64 elapsed() const override { return m_timer.isValid() ? m_timer.elapsed() : 0; }
 private:
     QElapsedTimer m_timer;
 };

=== modified file 'plugins/Utils/Timer.cpp'
--- plugins/Utils/Timer.cpp	2015-04-22 10:40:54 +0000
+++ plugins/Utils/Timer.cpp	2016-12-12 16:49:02 +0000
@@ -37,13 +37,16 @@
 void Timer::start()
 {
     m_timer.start();
-    AbstractTimer::start();
 }
 
 void Timer::stop()
 {
     m_timer.stop();
-    AbstractTimer::stop();
+}
+
+bool Timer::isRunning() const
+{
+    return m_timer.isActive();
 }
 
 bool Timer::isSingleShot() const

=== modified file 'plugins/Utils/Timer.h'
--- plugins/Utils/Timer.h	2015-04-22 10:40:54 +0000
+++ plugins/Utils/Timer.h	2016-12-12 16:49:02 +0000
@@ -30,18 +30,16 @@
 {
     Q_OBJECT
 public:
-    AbstractTimer(QObject *parent) : QObject(parent), m_isRunning(false) {}
+    AbstractTimer(QObject *parent) : QObject(parent) {}
     virtual int interval() const = 0;
     virtual void setInterval(int msecs) = 0;
-    virtual void start() { m_isRunning = true; }
-    virtual void stop() { m_isRunning = false; }
-    bool isRunning() const { return m_isRunning; }
+    virtual void start() = 0;
+    virtual void stop() = 0;
+    virtual bool isRunning() const = 0;
     virtual bool isSingleShot() const = 0;
     virtual void setSingleShot(bool value) = 0;
 Q_SIGNALS:
     void timeout();
-private:
-    bool m_isRunning;
 };
 
 /** A QTimer wrapper */
@@ -55,6 +53,7 @@
     void setInterval(int msecs) override;
     void start() override;
     void stop() override;
+    bool isRunning() const override;
     bool isSingleShot() const override;
     void setSingleShot(bool value) override;
 private:

=== added file 'plugins/Utils/appdrawerproxymodel.cpp'
--- plugins/Utils/appdrawerproxymodel.cpp	1970-01-01 00:00:00 +0000
+++ plugins/Utils/appdrawerproxymodel.cpp	2016-12-12 16:49:02 +0000
@@ -0,0 +1,189 @@
+/*
+ * Copyright (C) 2016 Canonical, Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "appdrawerproxymodel.h"
+
+#include <unity/shell/launcher/LauncherItemInterface.h>
+
+#include <QDebug>
+
+AppDrawerProxyModel::AppDrawerProxyModel(QObject *parent):
+    QSortFilterProxyModel(parent)
+{
+    setSortRole(AppDrawerModelInterface::RoleName);
+    setSortLocaleAware(true);
+    sort(0);
+
+    connect(this, &QAbstractListModel::rowsInserted, this, &AppDrawerProxyModel::countChanged);
+    connect(this, &QAbstractListModel::rowsRemoved, this, &AppDrawerProxyModel::countChanged);
+    connect(this, &QAbstractListModel::layoutChanged, this, &AppDrawerProxyModel::countChanged);
+}
+
+QAbstractItemModel *AppDrawerProxyModel::source() const
+{
+    return m_source;
+}
+
+void AppDrawerProxyModel::setSource(QAbstractItemModel *source)
+{
+    if (m_source != source) {
+        m_source = source;
+        setSourceModel(m_source);
+        setSortRole(m_sortBy == SortByAToZ ? AppDrawerModelInterface::RoleName : AppDrawerModelInterface::RoleUsage);
+        connect(m_source, &QAbstractItemModel::rowsRemoved, this, &AppDrawerProxyModel::invalidateFilter);
+        connect(m_source, &QAbstractItemModel::rowsInserted, this, &AppDrawerProxyModel::invalidateFilter);
+        Q_EMIT sourceChanged();
+    }
+}
+
+AppDrawerProxyModel::GroupBy AppDrawerProxyModel::group() const
+{
+    return m_group;
+}
+
+void AppDrawerProxyModel::setGroup(AppDrawerProxyModel::GroupBy group)
+{
+    if (m_group != group) {
+        m_group = group;
+        Q_EMIT groupChanged();
+        invalidateFilter();
+    }
+}
+
+QString AppDrawerProxyModel::filterLetter() const
+{
+    return m_filterLetter;
+}
+
+void AppDrawerProxyModel::setFilterLetter(const QString &filterLetter)
+{
+    if (m_filterLetter != filterLetter) {
+        m_filterLetter = filterLetter;
+        Q_EMIT filterLetterChanged();
+        invalidateFilter();
+    }
+}
+
+QString AppDrawerProxyModel::filterString() const
+{
+    return m_filterString;
+}
+
+void AppDrawerProxyModel::setFilterString(const QString &filterString)
+{
+    if (m_filterString != filterString) {
+        m_filterString = filterString;
+        Q_EMIT filterStringChanged();
+        invalidateFilter();
+    }
+}
+
+AppDrawerProxyModel::SortBy AppDrawerProxyModel::sortBy() const
+{
+    return m_sortBy;
+}
+
+void AppDrawerProxyModel::setSortBy(AppDrawerProxyModel::SortBy sortBy)
+{
+    if (m_sortBy != sortBy) {
+        m_sortBy = sortBy;
+        Q_EMIT sortByChanged();
+        setSortRole(m_sortBy == SortByAToZ ? AppDrawerModelInterface::RoleName : AppDrawerModelInterface::RoleUsage);
+        sort(0);
+    }
+}
+
+int AppDrawerProxyModel::count() const
+{
+    return rowCount();
+}
+
+QVariant AppDrawerProxyModel::data(const QModelIndex &index, int role) const
+{
+    QModelIndex idx = mapToSource(index);
+    if (role == Qt::UserRole) {
+        QString name = m_source->data(idx, AppDrawerModelInterface::RoleName).toString();
+        return name.length() > 0 ? QString(name.at(0)).toUpper() : QChar();
+    }
+    return m_source->data(idx, role);
+}
+
+QHash<int, QByteArray> AppDrawerProxyModel::roleNames() const
+{
+    if (m_source) {
+        QHash<int, QByteArray> roles = m_source->roleNames();
+        roles.insert(Qt::UserRole, "letter");
+        return roles;
+    }
+    return QHash<int, QByteArray>();
+}
+
+bool AppDrawerProxyModel::filterAcceptsRow(int source_row, const QModelIndex &source_parent) const
+{
+    Q_UNUSED(source_parent)
+
+    if (m_group == GroupByAToZ && source_row > 0) {
+        QString currentName = m_source->data(m_source->index(source_row, 0), AppDrawerModelInterface::RoleName).toString();
+        QChar currentLetter = currentName.length() > 0 ? currentName.at(0) : QChar();
+        QString previousName = m_source->data(m_source->index(source_row - 1,0 ), AppDrawerModelInterface::RoleName).toString();
+        QChar previousLetter = previousName.length() > 0 ? previousName.at(0) : QChar();
+        if (currentLetter.toLower() == previousLetter.toLower()) {
+            return false;
+        }
+    } else if(m_group == GroupByAll && source_row > 0) {
+        return false;
+    }
+    if (!m_filterLetter.isEmpty()) {
+        QString currentName = m_source->data(m_source->index(source_row, 0), AppDrawerModelInterface::RoleName).toString();
+        QString currentLetter = currentName.length() > 0 ? QString(currentName.at(0)) : QString();
+        if (currentLetter.toLower() != m_filterLetter.toLower()) {
+            return false;
+        }
+    }
+    if (!m_filterString.isEmpty()) {
+        QStringList allWords = m_source->data(m_source->index(source_row, 0), AppDrawerModelInterface::RoleKeywords).toStringList();
+        allWords.prepend(m_source->data(m_source->index(source_row, 0), AppDrawerModelInterface::RoleName).toString());
+        bool found = false;
+        Q_FOREACH (const QString currentWord, allWords) {
+            if (currentWord.toLower().startsWith(m_filterString.toLower())) {
+                found = true;
+                break;
+            }
+        }
+        if (!found) {
+            return false;
+        }
+    }
+    return true;
+}
+
+QString AppDrawerProxyModel::appId(int index) const
+{
+    if (index >= 0 && index < rowCount()) {
+        QModelIndex sourceIndex = mapToSource(this->index(index, 0));
+
+        AppDrawerModelInterface* adm = dynamic_cast<AppDrawerModelInterface*>(m_source);
+        if (adm) {
+            return adm->data(sourceIndex, AppDrawerModelInterface::RoleAppId).toString();
+        }
+
+        AppDrawerProxyModel* adpm = qobject_cast<AppDrawerProxyModel*>(m_source);
+        if (adpm) {
+            return adpm->appId(sourceIndex.row());
+        }
+    }
+    return nullptr;
+}

=== added file 'plugins/Utils/appdrawerproxymodel.h'
--- plugins/Utils/appdrawerproxymodel.h	1970-01-01 00:00:00 +0000
+++ plugins/Utils/appdrawerproxymodel.h	2016-12-12 16:49:02 +0000
@@ -0,0 +1,87 @@
+/*
+ * Copyright (C) 2016 Canonical, Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <QSortFilterProxyModel>
+
+#include <unity/shell/launcher/AppDrawerModelInterface.h>
+
+using namespace unity::shell::launcher;
+
+class AppDrawerProxyModel: public QSortFilterProxyModel
+{
+    Q_OBJECT
+    Q_ENUMS(GroupBy)
+    Q_ENUMS(SortBy)
+    Q_PROPERTY(QAbstractItemModel* source READ source WRITE setSource NOTIFY sourceChanged)
+    Q_PROPERTY(GroupBy group READ group WRITE setGroup NOTIFY groupChanged)
+    Q_PROPERTY(QString filterLetter READ filterLetter WRITE setFilterLetter NOTIFY filterLetterChanged)
+    Q_PROPERTY(QString filterString READ filterString WRITE setFilterString NOTIFY filterStringChanged)
+    Q_PROPERTY(SortBy sortBy READ sortBy WRITE setSortBy NOTIFY sortByChanged)
+    Q_PROPERTY(int count READ count NOTIFY countChanged)
+
+public:
+    enum GroupBy {
+        GroupByNone,
+        GroupByAll,
+        GroupByAToZ
+    };
+    enum SortBy {
+        SortByAToZ,
+        SortByUsage
+    };
+
+    AppDrawerProxyModel(QObject* parent = nullptr);
+
+    QAbstractItemModel* source() const;
+    void setSource(QAbstractItemModel* source);
+
+    GroupBy group() const;
+    void setGroup(GroupBy group);
+
+    QString filterLetter() const;
+    void setFilterLetter(const QString &filterLetter);
+
+    QString filterString() const;
+    void setFilterString(const QString &filterString);
+
+    SortBy sortBy() const;
+    void setSortBy(SortBy sortBy);
+
+    int count() const;
+
+    QVariant data(const QModelIndex &index, int role) const override;
+    QHash<int, QByteArray> roleNames() const override;
+
+    Q_INVOKABLE QString appId(int index) const;
+
+protected:
+    bool filterAcceptsRow(int source_row, const QModelIndex &source_parent) const override;
+
+Q_SIGNALS:
+    void sourceChanged();
+    void groupChanged();
+    void filterLetterChanged();
+    void filterStringChanged();
+    void sortByChanged();
+    void countChanged();
+
+private:
+    QAbstractItemModel* m_source = nullptr;
+    GroupBy m_group = GroupByNone;
+    QString m_filterLetter;
+    QString m_filterString;
+    SortBy m_sortBy = SortByAToZ;
+};

=== modified file 'plugins/Utils/globalfunctions.cpp'
--- plugins/Utils/globalfunctions.cpp	2016-06-02 09:32:33 +0000
+++ plugins/Utils/globalfunctions.cpp	2016-12-12 16:49:02 +0000
@@ -51,3 +51,8 @@
     }
     return nullptr;
 }
+
+bool GlobalFunctions::itemUnderMouse(QQuickItem* item)
+{
+    return item && item->isUnderMouse();
+}

=== modified file 'plugins/Utils/globalfunctions.h'
--- plugins/Utils/globalfunctions.h	2016-03-11 20:18:12 +0000
+++ plugins/Utils/globalfunctions.h	2016-12-12 16:49:02 +0000
@@ -37,6 +37,8 @@
                                           int x,
                                           int y,
                                           QJSValue matcher);
+
+    static Q_INVOKABLE bool itemUnderMouse(QQuickItem* item);
 };
 
 #endif // GLOBALFUNCTIONS_H

=== modified file 'plugins/Utils/plugin.cpp'
--- plugins/Utils/plugin.cpp	2016-06-28 20:38:00 +0000
+++ plugins/Utils/plugin.cpp	2016-12-12 16:49:02 +0000
@@ -39,6 +39,7 @@
 #include "deviceconfigparser.h"
 #include "globalfunctions.h"
 #include "URLDispatcher.h"
+#include "appdrawerproxymodel.h"
 
 static QObject *createWindowStateStorage(QQmlEngine *engine, QJSEngine *scriptEngine)
 {
@@ -82,4 +83,5 @@
     qmlRegisterType<DeviceConfigParser>(uri, 0, 1, "DeviceConfigParser");
     qmlRegisterSingletonType<GlobalFunctions>(uri, 0, 1, "Functions", createGlobalFunctions);
     qmlRegisterType<URLDispatcher>(uri, 0, 1, "URLDispatcher");
+    qmlRegisterType<AppDrawerProxyModel>(uri, 0, 1, "AppDrawerProxyModel");
 }

=== modified file 'plugins/Utils/windowstatestorage.cpp'
--- plugins/Utils/windowstatestorage.cpp	2016-08-23 13:53:07 +0000
+++ plugins/Utils/windowstatestorage.cpp	2016-12-12 16:49:02 +0000
@@ -189,3 +189,26 @@
     }
     return query;
 }
+
+Mir::State WindowStateStorage::toMirState(WindowState state) const
+{
+    // assumes a single state (not an OR of several)
+    switch (state) {
+        case WindowStateMaximized:             return Mir::MaximizedState;
+        case WindowStateMinimized:             return Mir::MinimizedState;
+        case WindowStateFullscreen:            return Mir::FullscreenState;
+        case WindowStateMaximizedLeft:         return Mir::MaximizedLeftState;
+        case WindowStateMaximizedRight:        return Mir::MaximizedRightState;
+        case WindowStateMaximizedHorizontally: return Mir::HorizMaximizedState;
+        case WindowStateMaximizedVertically:   return Mir::VertMaximizedState;
+        case WindowStateMaximizedTopLeft:      return Mir::MaximizedTopLeftState;
+        case WindowStateMaximizedTopRight:     return Mir::MaximizedTopRightState;
+        case WindowStateMaximizedBottomLeft:   return Mir::MaximizedBottomLeftState;
+        case WindowStateMaximizedBottomRight:  return Mir::MaximizedBottomRightState;
+
+        case WindowStateNormal:
+        case WindowStateRestored:
+        default:
+            return Mir::RestoredState;
+    }
+}

=== modified file 'plugins/Utils/windowstatestorage.h'
--- plugins/Utils/windowstatestorage.h	2016-08-23 13:53:07 +0000
+++ plugins/Utils/windowstatestorage.h	2016-12-12 16:49:02 +0000
@@ -19,6 +19,9 @@
 #include <QMutex>
 #include <QFuture>
 
+// unity-api
+#include <unity/shell/application/Mir.h>
+
 class WindowStateStorage: public QObject
 {
     Q_OBJECT
@@ -56,6 +59,8 @@
     Q_INVOKABLE void saveStage(const QString &appId, int stage);
     Q_INVOKABLE int getStage(const QString &appId, int defaultValue) const;
 
+    Q_INVOKABLE Mir::State toMirState(WindowState state) const;
+
 private:
     void initdb();
 

=== modified file 'plugins/WindowManager/CMakeLists.txt'
--- plugins/WindowManager/CMakeLists.txt	2016-06-20 09:43:38 +0000
+++ plugins/WindowManager/CMakeLists.txt	2016-12-12 16:49:02 +0000
@@ -1,10 +1,12 @@
 set(WINDOWMANAGER_SRC
-    TopLevelSurfaceList.cpp
+    TopLevelWindowModel.cpp
+    Window.cpp
     WindowManagerPlugin.cpp
     ${APPLICATION_API_INCLUDEDIR}/unity/shell/application/ApplicationInfoInterface.h
     ${APPLICATION_API_INCLUDEDIR}/unity/shell/application/Mir.h
     ${APPLICATION_API_INCLUDEDIR}/unity/shell/application/MirSurfaceInterface.h
     ${APPLICATION_API_INCLUDEDIR}/unity/shell/application/MirSurfaceListInterface.h
+    ${APPLICATION_API_INCLUDEDIR}/unity/shell/application/SurfaceManagerInterface.h
    )
 
 add_library(windowmanager-qml SHARED ${WINDOWMANAGER_SRC})

=== removed file 'plugins/WindowManager/TopLevelSurfaceList.cpp'
--- plugins/WindowManager/TopLevelSurfaceList.cpp	2016-09-14 15:02:01 +0000
+++ plugins/WindowManager/TopLevelSurfaceList.cpp	1970-01-01 00:00:00 +0000
@@ -1,481 +0,0 @@
-/*
- * Copyright (C) 2016 Canonical, Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 3.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- */
-
-#include "TopLevelSurfaceList.h"
-
-// unity-api
-#include <unity/shell/application/ApplicationInfoInterface.h>
-#include <unity/shell/application/MirSurfaceInterface.h>
-#include <unity/shell/application/MirSurfaceListInterface.h>
-
-#include <QMetaObject>
-
-Q_LOGGING_CATEGORY(UNITY_TOPSURFACELIST, "unity.topsurfacelist", QtDebugMsg)
-
-#define DEBUG_MSG qCDebug(UNITY_TOPSURFACELIST).nospace().noquote() << __func__
-
-using namespace unity::shell::application;
-
-TopLevelSurfaceList::TopLevelSurfaceList(QObject *parent) :
-    QAbstractListModel(parent)
-{
-    DEBUG_MSG << "()";
-}
-
-TopLevelSurfaceList::~TopLevelSurfaceList()
-{
-    DEBUG_MSG << "()";
-}
-
-int TopLevelSurfaceList::rowCount(const QModelIndex &parent) const
-{
-    return !parent.isValid() ? m_surfaceList.size() : 0;
-}
-
-QVariant TopLevelSurfaceList::data(const QModelIndex& index, int role) const
-{
-    if (index.row() < 0 || index.row() >= m_surfaceList.size())
-        return QVariant();
-
-    if (role == SurfaceRole) {
-        MirSurfaceInterface *surface = m_surfaceList.at(index.row()).surface;
-        return QVariant::fromValue(surface);
-    } else if (role == ApplicationRole) {
-        return QVariant::fromValue(m_surfaceList.at(index.row()).application);
-    } else if (role == IdRole) {
-        return QVariant::fromValue(m_surfaceList.at(index.row()).id);
-    } else {
-        return QVariant();
-    }
-}
-
-void TopLevelSurfaceList::raise(MirSurfaceInterface *surface)
-{
-    if (!surface)
-        return;
-
-    DEBUG_MSG << "(MirSurface[" << (void*)surface << "])";
-
-    int i = indexOf(surface);
-    if (i != -1) {
-        raiseId(m_surfaceList.at(i).id);
-    }
-}
-
-void TopLevelSurfaceList::appendPlaceholder(ApplicationInfoInterface *application)
-{
-    DEBUG_MSG << "(" << application->appId() << ")";
-
-    appendSurfaceHelper(nullptr, application);
-}
-
-void TopLevelSurfaceList::appendSurface(MirSurfaceInterface *surface, ApplicationInfoInterface *application)
-{
-    Q_ASSERT(surface != nullptr);
-
-    bool filledPlaceholder = false;
-    for (int i = 0; i < m_surfaceList.count() && !filledPlaceholder; ++i) {
-        ModelEntry &entry = m_surfaceList[i];
-        if (entry.application == application && entry.surface == nullptr) {
-            entry.surface = surface;
-            connectSurface(surface);
-            DEBUG_MSG << " appId=" << application->appId() << " surface=" << surface
-                      << ", filling out placeholder. after: " << toString();
-            Q_EMIT dataChanged(index(i) /* topLeft */, index(i) /* bottomRight */, QVector<int>() << SurfaceRole);
-            filledPlaceholder = true;
-        }
-    }
-
-    if (!filledPlaceholder) {
-        DEBUG_MSG << " appId=" << application->appId() << " surface=" << surface << ", adding new row";
-        appendSurfaceHelper(surface, application);
-    }
-}
-
-void TopLevelSurfaceList::appendSurfaceHelper(MirSurfaceInterface *surface, ApplicationInfoInterface *application)
-{
-    if (m_modelState == IdleState) {
-        m_modelState = InsertingState;
-        beginInsertRows(QModelIndex(), m_surfaceList.size() /*first*/, m_surfaceList.size() /*last*/);
-    } else {
-        Q_ASSERT(m_modelState == ResettingState);
-        // No point in signaling anything if we're resetting the whole model
-    }
-
-    int id = generateId();
-    m_surfaceList.append(ModelEntry(surface, application, id));
-    if (surface) {
-        connectSurface(surface);
-    }
-
-    if (m_modelState == InsertingState) {
-        endInsertRows();
-        Q_EMIT countChanged();
-        Q_EMIT listChanged();
-        m_modelState = IdleState;
-    }
-
-    DEBUG_MSG << " after " << toString();
-}
-
-void TopLevelSurfaceList::connectSurface(MirSurfaceInterface *surface)
-{
-    connect(surface, &MirSurfaceInterface::liveChanged, this, [this, surface](bool live){
-            if (!live) {
-                onSurfaceDied(surface);
-            }
-        });
-    connect(surface, &QObject::destroyed, this, [this, surface](){ this->onSurfaceDestroyed(surface); });
-}
-
-void TopLevelSurfaceList::onSurfaceDied(MirSurfaceInterface *surface)
-{
-    int i = indexOf(surface);
-    if (i == -1) {
-        return;
-    }
-
-    auto application = m_surfaceList[i].application;
-
-    // can't be starting if it already has a surface
-    Q_ASSERT(application->state() != ApplicationInfoInterface::Starting);
-
-    if (application->state() == ApplicationInfoInterface::Running) {
-        m_surfaceList[i].removeOnceSurfaceDestroyed = true;
-    } else {
-        // assume it got killed by the out-of-memory daemon.
-        //
-        // So leave entry in the model and only remove its surface, so shell can display a screenshot
-        // in its place.
-        m_surfaceList[i].removeOnceSurfaceDestroyed = false;
-    }
-}
-
-void TopLevelSurfaceList::onSurfaceDestroyed(MirSurfaceInterface *surface)
-{
-    int i = indexOf(surface);
-    if (i == -1) {
-        return;
-    }
-
-    if (m_surfaceList[i].removeOnceSurfaceDestroyed) {
-        removeAt(i);
-    } else {
-        m_surfaceList[i].surface = nullptr;
-        Q_EMIT dataChanged(index(i) /* topLeft */, index(i) /* bottomRight */, QVector<int>() << SurfaceRole);
-        DEBUG_MSG << " Removed surface from entry. After: " << toString();
-    }
-}
-
-void TopLevelSurfaceList::removeAt(int index)
-{
-    if (m_modelState == IdleState) {
-        beginRemoveRows(QModelIndex(), index, index);
-        m_modelState = RemovingState;
-    } else {
-        Q_ASSERT(m_modelState == ResettingState);
-        // No point in signaling anything if we're resetting the whole model
-    }
-
-    m_surfaceList.removeAt(index);
-
-    if (m_modelState == RemovingState) {
-        endRemoveRows();
-        Q_EMIT countChanged();
-        Q_EMIT listChanged();
-        m_modelState = IdleState;
-    }
-
-    DEBUG_MSG << " after " << toString();
-}
-
-int TopLevelSurfaceList::indexOf(MirSurfaceInterface *surface)
-{
-    for (int i = 0; i < m_surfaceList.count(); ++i) {
-        if (m_surfaceList.at(i).surface == surface) {
-            return i;
-        }
-    }
-    return -1;
-}
-
-void TopLevelSurfaceList::move(int from, int to)
-{
-    if (from == to) return;
-    DEBUG_MSG << " from=" << from << " to=" << to;
-
-    if (from >= 0 && from < m_surfaceList.size() && to >= 0 && to < m_surfaceList.size()) {
-        QModelIndex parent;
-        /* When moving an item down, the destination index needs to be incremented
-           by one, as explained in the documentation:
-           http://qt-project.org/doc/qt-5.0/qtcore/qabstractitemmodel.html#beginMoveRows */
-
-        Q_ASSERT(m_modelState == IdleState);
-        m_modelState = MovingState;
-
-        beginMoveRows(parent, from, from, parent, to + (to > from ? 1 : 0));
-        m_surfaceList.move(from, to);
-        endMoveRows();
-        Q_EMIT listChanged();
-
-        m_modelState = IdleState;
-
-        DEBUG_MSG << " after " << toString();
-    }
-}
-
-MirSurfaceInterface *TopLevelSurfaceList::surfaceAt(int index) const
-{
-    if (index >=0 && index < m_surfaceList.count()) {
-        return m_surfaceList[index].surface;
-    } else {
-        return nullptr;
-    }
-}
-
-ApplicationInfoInterface *TopLevelSurfaceList::applicationAt(int index) const
-{
-    if (index >=0 && index < m_surfaceList.count()) {
-        return m_surfaceList[index].application;
-    } else {
-        return nullptr;
-    }
-}
-
-int TopLevelSurfaceList::idAt(int index) const
-{
-    if (index >=0 && index < m_surfaceList.count()) {
-        return m_surfaceList[index].id;
-    } else {
-        return 0;
-    }
-}
-
-int TopLevelSurfaceList::indexForId(int id) const
-{
-    for (int i = 0; i < m_surfaceList.count(); ++i) {
-        if (m_surfaceList[i].id == id) {
-            return i;
-        }
-    }
-    return -1;
-}
-
-void TopLevelSurfaceList::doRaiseId(int id)
-{
-    int fromIndex = indexForId(id);
-    if (fromIndex != -1) {
-        move(fromIndex, 0 /* toIndex */);
-    }
-}
-
-void TopLevelSurfaceList::raiseId(int id)
-{
-    if (m_modelState == IdleState) {
-        DEBUG_MSG << "(id=" << id << ") - do it now.";
-        doRaiseId(id);
-    } else {
-        DEBUG_MSG << "(id=" << id << ") - Model busy (modelState=" << m_modelState << "). Try again in the next event loop.";
-        // The model has just signalled some change. If we have a Repeater responding to this update, it will get nuts
-        // if we perform yet another model change straight away.
-        //
-        // A bad sympton of this problem is a Repeater.itemAt(index) call returning null event though Repeater.count says
-        // the index is definitely within bounds.
-        QMetaObject::invokeMethod(this, "raiseId", Qt::QueuedConnection, Q_ARG(int, id));
-    }
-}
-
-int TopLevelSurfaceList::generateId()
-{
-    int id = m_nextId;
-    m_nextId = nextFreeId(m_nextId + 1);
-    Q_EMIT nextIdChanged();
-    return id;
-}
-
-int TopLevelSurfaceList::nextFreeId(int candidateId)
-{
-    if (candidateId > m_maxId) {
-        return nextFreeId(1);
-    } else {
-        if (indexForId(candidateId) == -1) {
-            // it's indeed free
-            return candidateId;
-        } else {
-            return nextFreeId(candidateId + 1);
-        }
-    }
-}
-
-QString TopLevelSurfaceList::toString()
-{
-    QString str;
-    for (int i = 0; i < m_surfaceList.count(); ++i) {
-        auto item = m_surfaceList.at(i);
-
-        QString itemStr = QString("(index=%1,appId=%2,surface=0x%3,id=%4)")
-            .arg(i)
-            .arg(item.application->appId())
-            .arg((qintptr)item.surface, 0, 16)
-            .arg(item.id);
-
-        if (i > 0) {
-            str.append(",");
-        }
-        str.append(itemStr);
-    }
-    return str;
-}
-
-void TopLevelSurfaceList::addApplication(ApplicationInfoInterface *application)
-{
-    DEBUG_MSG << "(" << application->appId() << ")";
-    Q_ASSERT(!m_applications.contains(application));
-    m_applications.append(application);
-
-    MirSurfaceListInterface *surfaceList = application->surfaceList();
-
-    if (application->state() != ApplicationInfoInterface::Stopped) {
-        if (surfaceList->count() == 0) {
-            appendPlaceholder(application);
-        } else {
-            for (int i = 0; i < surfaceList->count(); ++i) {
-                appendSurface(surfaceList->get(i), application);
-            }
-        }
-    }
-
-    connect(surfaceList, &QAbstractItemModel::rowsInserted, this,
-            [this, application, surfaceList](const QModelIndex & /*parent*/, int first, int last)
-            {
-                for (int i = last; i >= first; --i) {
-                    this->appendSurface(surfaceList->get(i), application);
-                }
-            });
-}
-
-void TopLevelSurfaceList::removeApplication(ApplicationInfoInterface *application)
-{
-    DEBUG_MSG << "(" << application->appId() << ")";
-    Q_ASSERT(m_applications.contains(application));
-
-    MirSurfaceListInterface *surfaceList = application->surfaceList();
-
-    disconnect(surfaceList, 0, this, 0);
-
-    Q_ASSERT(m_modelState == IdleState);
-    m_modelState = RemovingState;
-
-    int i = 0;
-    while (i < m_surfaceList.count()) {
-        if (m_surfaceList.at(i).application == application) {
-            beginRemoveRows(QModelIndex(), i, i);
-            m_surfaceList.removeAt(i);
-            endRemoveRows();
-            Q_EMIT countChanged();
-            Q_EMIT listChanged();
-        } else {
-            ++i;
-        }
-    }
-
-    m_modelState = IdleState;
-
-    DEBUG_MSG << " after " << toString();
-
-    m_applications.removeAll(application);
-}
-
-QAbstractListModel *TopLevelSurfaceList::applicationsModel() const
-{
-    return m_applicationsModel;
-}
-
-void TopLevelSurfaceList::setApplicationsModel(QAbstractListModel* value)
-{
-    if (m_applicationsModel == value) {
-        return;
-    }
-
-    DEBUG_MSG << "(" << value << ")";
-
-    Q_ASSERT(m_modelState == IdleState);
-    m_modelState = ResettingState;
-
-    beginResetModel();
-
-    if (m_applicationsModel) {
-        m_surfaceList.clear();
-        m_applications.clear();
-        disconnect(m_applicationsModel, 0, this, 0);
-    }
-
-    m_applicationsModel = value;
-
-    if (m_applicationsModel) {
-        findApplicationRole();
-
-        connect(m_applicationsModel, &QAbstractItemModel::rowsInserted,
-                this, [this](const QModelIndex &/*parent*/, int first, int last) {
-                    for (int i = first; i <= last; ++i) {
-                        auto application = getApplicationFromModelAt(i);
-                        addApplication(application);
-                    }
-                });
-
-        connect(m_applicationsModel, &QAbstractItemModel::rowsAboutToBeRemoved,
-                this, [this](const QModelIndex &/*parent*/, int first, int last) {
-                    for (int i = first; i <= last; ++i) {
-                        auto application = getApplicationFromModelAt(i);
-                        removeApplication(application);
-                    }
-                });
-
-        for (int i = 0; i < m_applicationsModel->rowCount(); ++i) {
-            auto application = getApplicationFromModelAt(i);
-            addApplication(application);
-        }
-    }
-
-    endResetModel();
-    m_modelState = IdleState;
-}
-
-ApplicationInfoInterface *TopLevelSurfaceList::getApplicationFromModelAt(int index)
-{
-    QModelIndex modelIndex = m_applicationsModel->index(index);
-
-    QVariant variant =  m_applicationsModel->data(modelIndex, m_applicationRole);
-
-    // variant.value<ApplicationInfoInterface*>() returns null for some reason.
-    return static_cast<ApplicationInfoInterface*>(variant.value<QObject*>());
-}
-
-void TopLevelSurfaceList::findApplicationRole()
-{
-    QHash<int, QByteArray> namesHash = m_applicationsModel->roleNames();
-
-    m_applicationRole = -1;
-    for (auto i = namesHash.begin(); i != namesHash.end() && m_applicationRole == -1; ++i) {
-        if (i.value() == "application") {
-            m_applicationRole = i.key();
-        }
-    }
-
-    if (m_applicationRole == -1) {
-        qFatal("TopLevelSurfaceList: applicationsModel must have a \"application\" role.");
-    }
-}

=== removed file 'plugins/WindowManager/TopLevelSurfaceList.h'
--- plugins/WindowManager/TopLevelSurfaceList.h	2016-04-04 13:39:44 +0000
+++ plugins/WindowManager/TopLevelSurfaceList.h	1970-01-01 00:00:00 +0000
@@ -1,223 +0,0 @@
-/*
- * Copyright (C) 2016 Canonical, Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 3.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- */
-
-#ifndef TOPLEVELSURFACELIST_H
-#define TOPLEVELSURFACELIST_H
-
-#include <QAbstractListModel>
-#include <QList>
-#include <QLoggingCategory>
-
-Q_DECLARE_LOGGING_CATEGORY(UNITY_TOPSURFACELIST)
-
-namespace unity {
-    namespace shell {
-        namespace application {
-            class ApplicationInfoInterface;
-            class MirSurfaceInterface;
-        }
-    }
-}
-
-/**
- * @brief A model of top-level surfaces
- *
- * It's an abstraction of top-level application windows.
- *
- * When an entry first appears, it normaly doesn't have a surface yet, meaning that the application is
- * still starting up. A shell should then display a splash screen or saved screenshot of the application
- * until its surface comes up.
- *
- * As applications can have multiple surfaces and you can also have entries without surfaces at all,
- * the only way to unambiguously refer to an entry in this model is through its id.
- */
-class TopLevelSurfaceList : public QAbstractListModel
-{
-
-    Q_OBJECT
-
-    /**
-     * @brief A list model of applications.
-     *
-     * It's expected to have a role called "application" which returns a ApplicationInfoInterface
-     */
-    Q_PROPERTY(QAbstractListModel* applicationsModel READ applicationsModel
-                                                     WRITE setApplicationsModel
-                                                     NOTIFY applicationsModelChanged)
-
-    /**
-     * @brief Number of top-level surfaces in this model
-     *
-     * This is the same as rowCount, added in order to keep compatibility with QML ListModels.
-     */
-    Q_PROPERTY(int count READ rowCount NOTIFY countChanged)
-
-    /**
-      The id to be used on the next entry created
-      Useful for tests
-     */
-    Q_PROPERTY(int nextId READ nextId NOTIFY nextIdChanged)
-public:
-
-    /**
-     * @brief The Roles supported by the model
-     *
-     * SurfaceRole - A MirSurfaceInterface. It will be null if the application is still starting up
-     * ApplicationRole - An ApplicationInfoInterface
-     * IdRole - A unique identifier for this entry. Useful to unambiguosly track elements as they move around in the list
-     */
-    enum Roles {
-        SurfaceRole = Qt::UserRole,
-        ApplicationRole = Qt::UserRole + 1,
-        IdRole = Qt::UserRole + 2,
-    };
-
-    explicit TopLevelSurfaceList(QObject *parent = nullptr);
-    virtual ~TopLevelSurfaceList();
-
-    // QAbstractItemModel methods
-    int rowCount(const QModelIndex &parent = QModelIndex()) const override;
-    QVariant data(const QModelIndex& index, int role) const override;
-    QHash<int, QByteArray> roleNames() const override {
-        QHash<int, QByteArray> roleNames { {SurfaceRole, "surface"},
-                                           {ApplicationRole, "application"},
-                                           {IdRole, "id"} };
-        return roleNames;
-    }
-
-    int nextId() const { return m_nextId; }
-
-    QAbstractListModel *applicationsModel() const;
-    void setApplicationsModel(QAbstractListModel*);
-
-public Q_SLOTS:
-    /**
-     * @brief Returns the surface at the given index
-     *
-     * It will be a nullptr if the application is still starting up and thus hasn't yet created
-     * and drawn into a surface.
-     */
-    unity::shell::application::MirSurfaceInterface *surfaceAt(int index) const;
-
-    /**
-     * @brief Returns the application at the given index
-     */
-    unity::shell::application::ApplicationInfoInterface *applicationAt(int index) const;
-
-    /**
-     * @brief Returns the unique id of the element at the given index
-     */
-    int idAt(int index) const;
-
-    /**
-     * @brief Returns the index where the row with the given id is located
-     *
-     * Returns -1 if there's no row with the given id.
-     */
-    int indexForId(int id) const;
-
-    /**
-     * @brief Raises the row with the given id to index 0
-     */
-    void raiseId(int id);
-
-    void doRaiseId(int id);
-
-Q_SIGNALS:
-    void countChanged();
-
-    /**
-     * @brief Emitted when the list changes
-     *
-     * Emitted when model gains an element, loses an element or when elements exchange positions.
-     */
-    void listChanged();
-
-    void nextIdChanged();
-
-    void applicationsModelChanged();
-
-private:
-    void addApplication(unity::shell::application::ApplicationInfoInterface *application);
-    void removeApplication(unity::shell::application::ApplicationInfoInterface *application);
-
-    int indexOf(unity::shell::application::MirSurfaceInterface *surface);
-    void raise(unity::shell::application::MirSurfaceInterface *surface);
-    void move(int from, int to);
-    void appendSurfaceHelper(unity::shell::application::MirSurfaceInterface *surface,
-                              unity::shell::application::ApplicationInfoInterface *application);
-    void connectSurface(unity::shell::application::MirSurfaceInterface *surface);
-    int generateId();
-    int nextFreeId(int candidateId);
-    QString toString();
-    void onSurfaceDestroyed(unity::shell::application::MirSurfaceInterface *surface);
-    void onSurfaceDied(unity::shell::application::MirSurfaceInterface *surface);
-    void removeAt(int index);
-    void findApplicationRole();
-
-    unity::shell::application::ApplicationInfoInterface *getApplicationFromModelAt(int index);
-
-    /*
-        Placeholder for a future surface from a starting or running application.
-        Enables shell to give immediate feedback to the user by showing, eg,
-        a splash screen.
-
-        It's a model row containing a null surface and the given application.
-     */
-    void appendPlaceholder(unity::shell::application::ApplicationInfoInterface *application);
-
-    /*
-        Adds a model row with the given surface and application
-
-        Alternatively, if a placeholder exists for the given application it's
-        filled with the given surface instead.
-     */
-    void appendSurface(unity::shell::application::MirSurfaceInterface *surface,
-            unity::shell::application::ApplicationInfoInterface *application);
-
-    struct ModelEntry {
-        ModelEntry(unity::shell::application::MirSurfaceInterface *surface, unity::shell::application::ApplicationInfoInterface *application, int id)
-            : surface(surface), application(application), id(id) {}
-        unity::shell::application::MirSurfaceInterface *surface;
-        unity::shell::application::ApplicationInfoInterface *application;
-        int id;
-        bool removeOnceSurfaceDestroyed{false};
-    };
-
-    QList<ModelEntry> m_surfaceList;
-    int m_nextId{1};
-    static const int m_maxId{1000000};
-
-    // applications that are being monitored
-    QList<unity::shell::application::ApplicationInfoInterface *> m_applications;
-
-    QAbstractListModel* m_applicationsModel{nullptr};
-    int m_applicationRole{-1};
-
-    enum ModelState {
-        IdleState,
-        InsertingState,
-        RemovingState,
-        MovingState,
-        ResettingState
-    };
-    ModelState m_modelState{IdleState};
-};
-
-Q_DECLARE_METATYPE(TopLevelSurfaceList*)
-Q_DECLARE_METATYPE(QAbstractListModel*)
-
-#endif // TOPLEVELSURFACELIST_H

=== added file 'plugins/WindowManager/TopLevelWindowModel.cpp'
--- plugins/WindowManager/TopLevelWindowModel.cpp	1970-01-01 00:00:00 +0000
+++ plugins/WindowManager/TopLevelWindowModel.cpp	2016-12-12 16:49:02 +0000
@@ -0,0 +1,668 @@
+/*
+ * Copyright (C) 2016 Canonical, Ltd.
+ *
+ * This program is free software: you can redistribute it and/or modify it under
+ * the terms of the GNU Lesser General Public License version 3, as published by
+ * the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
+ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "TopLevelWindowModel.h"
+
+// unity-api
+#include <unity/shell/application/ApplicationInfoInterface.h>
+#include <unity/shell/application/ApplicationManagerInterface.h>
+#include <unity/shell/application/MirSurfaceInterface.h>
+#include <unity/shell/application/MirSurfaceListInterface.h>
+#include <unity/shell/application/SurfaceManagerInterface.h>
+
+// Qt
+#include <QGuiApplication>
+#include <QDebug>
+
+// local
+#include "Window.h"
+
+Q_LOGGING_CATEGORY(TOPLEVELWINDOWMODEL, "toplevelwindowmodel", QtInfoMsg)
+
+#define DEBUG_MSG qCDebug(TOPLEVELWINDOWMODEL).nospace().noquote() << __func__
+#define INFO_MSG qCInfo(TOPLEVELWINDOWMODEL).nospace().noquote() << __func__
+
+namespace unityapi = unity::shell::application;
+
+TopLevelWindowModel::TopLevelWindowModel()
+{
+}
+
+void TopLevelWindowModel::setApplicationManager(unityapi::ApplicationManagerInterface* value)
+{
+    if (m_applicationManager == value) {
+        return;
+    }
+
+    DEBUG_MSG << "(" << value << ")";
+
+    Q_ASSERT(m_modelState == IdleState);
+    m_modelState = ResettingState;
+
+    beginResetModel();
+
+    if (m_applicationManager) {
+        m_windowModel.clear();
+        disconnect(m_applicationManager, 0, this, 0);
+    }
+
+    m_applicationManager = value;
+
+    if (m_applicationManager) {
+        connect(m_applicationManager, &QAbstractItemModel::rowsInserted,
+                this, [this](const QModelIndex &/*parent*/, int first, int last) {
+                    for (int i = first; i <= last; ++i) {
+                        auto application = m_applicationManager->get(i);
+                        addApplication(application);
+                    }
+                });
+
+        connect(m_applicationManager, &QAbstractItemModel::rowsAboutToBeRemoved,
+                this, [this](const QModelIndex &/*parent*/, int first, int last) {
+                    for (int i = first; i <= last; ++i) {
+                        auto application = m_applicationManager->get(i);
+                        removeApplication(application);
+                    }
+                });
+
+        for (int i = 0; i < m_applicationManager->rowCount(); ++i) {
+            auto application = m_applicationManager->get(i);
+            addApplication(application);
+        }
+    }
+
+    endResetModel();
+    m_modelState = IdleState;
+}
+
+void TopLevelWindowModel::setSurfaceManager(unityapi::SurfaceManagerInterface *surfaceManager)
+{
+    if (surfaceManager == m_surfaceManager) {
+        return;
+    }
+
+    DEBUG_MSG << "(" << surfaceManager << ")";
+
+    if (m_surfaceManager) {
+        disconnect(m_surfaceManager, 0, this, 0);
+    }
+
+    m_surfaceManager = surfaceManager;
+
+    if (m_surfaceManager) {
+        connect(m_surfaceManager, &unityapi::SurfaceManagerInterface::surfaceCreated, this, &TopLevelWindowModel::onSurfaceCreated);
+        connect(m_surfaceManager, &unityapi::SurfaceManagerInterface::surfacesRaised, this, &TopLevelWindowModel::onSurfacesRaised);
+        connect(m_surfaceManager, &unityapi::SurfaceManagerInterface::modificationsStarted, this, &TopLevelWindowModel::onModificationsStarted);
+        connect(m_surfaceManager, &unityapi::SurfaceManagerInterface::modificationsEnded, this, &TopLevelWindowModel::onModificationsEnded);
+    }
+
+    Q_EMIT surfaceManagerChanged(m_surfaceManager);
+}
+
+void TopLevelWindowModel::addApplication(unityapi::ApplicationInfoInterface *application)
+{
+    DEBUG_MSG << "(" << application->appId() << ")";
+
+    if (application->state() != unityapi::ApplicationInfoInterface::Stopped && application->surfaceList()->count() == 0) {
+        prependPlaceholder(application);
+    }
+}
+
+void TopLevelWindowModel::removeApplication(unityapi::ApplicationInfoInterface *application)
+{
+    DEBUG_MSG << "(" << application->appId() << ")";
+
+    Q_ASSERT(m_modelState == IdleState);
+
+    int i = 0;
+    while (i < m_windowModel.count()) {
+        if (m_windowModel.at(i).application == application) {
+            removeAt(i);
+        } else {
+            ++i;
+        }
+    }
+}
+
+void TopLevelWindowModel::prependPlaceholder(unityapi::ApplicationInfoInterface *application)
+{
+    INFO_MSG << "(" << application->appId() << ")";
+
+    prependSurfaceHelper(nullptr, application);
+}
+
+void TopLevelWindowModel::prependSurface(unityapi::MirSurfaceInterface *surface, unityapi::ApplicationInfoInterface *application)
+{
+    Q_ASSERT(surface != nullptr);
+
+    bool filledPlaceholder = false;
+    for (int i = 0; i < m_windowModel.count() && !filledPlaceholder; ++i) {
+        ModelEntry &entry = m_windowModel[i];
+        if (entry.application == application && entry.window->surface() == nullptr) {
+            entry.window->setSurface(surface);
+            connectSurface(surface);
+            INFO_MSG << " appId=" << application->appId() << " surface=" << surface
+                      << ", filling out placeholder. after: " << toString();
+            filledPlaceholder = true;
+        }
+    }
+
+    if (!filledPlaceholder) {
+        INFO_MSG << " appId=" << application->appId() << " surface=" << surface << ", adding new row";
+        prependSurfaceHelper(surface, application);
+    }
+}
+
+void TopLevelWindowModel::prependSurfaceHelper(unityapi::MirSurfaceInterface *surface, unityapi::ApplicationInfoInterface *application)
+{
+    if (m_modelState == IdleState) {
+        m_modelState = InsertingState;
+        beginInsertRows(QModelIndex(), 0 /*first*/, 0 /*last*/);
+    } else {
+        Q_ASSERT(m_modelState == ResettingState);
+        // No point in signaling anything if we're resetting the whole model
+    }
+
+    int id = generateId();
+    Window *window = new Window(id, this);
+    if (surface) {
+        window->setSurface(surface);
+    }
+    m_windowModel.prepend(ModelEntry(window, application));
+    if (surface) {
+        connectSurface(surface);
+    }
+
+    connectWindow(window);
+
+    if (m_modelState == InsertingState) {
+        endInsertRows();
+        Q_EMIT countChanged();
+        Q_EMIT listChanged();
+        m_modelState = IdleState;
+    }
+
+    if (!surface) {
+        activateEmptyWindow(window);
+    }
+
+    INFO_MSG << " after " << toString();
+}
+
+void TopLevelWindowModel::connectWindow(Window *window)
+{
+    connect(window, &Window::focusRequested, this, [this, window]() {
+        if (!window->surface()) {
+            activateEmptyWindow(window);
+        }
+    });
+
+    connect(window, &Window::focusedChanged, this, [this, window](bool focused) {
+        if (window->surface()) {
+            // Condense changes to the focused window
+            // eg: Do focusedWindow=A to focusedWindow=B instead of
+            // focusedWindow=A to focusedWindow=null to focusedWindow=B
+            if (focused) {
+                Q_ASSERT(m_newlyFocusedWindow == nullptr);
+                m_focusedWindowChanged = true;
+                m_newlyFocusedWindow = window;
+            } else if (m_focusedWindow == window) {
+                m_focusedWindowChanged = true;
+            } else {
+                // don't clear the focused window if you were not there in the first place
+                // happens when a filled window gets replaced with an empty one (no surface) as the focused window.
+            }
+        }
+    });
+
+    connect(window, &Window::closeRequested, this, [this, window]() {
+        if (!window->surface()) {
+            // do things ourselves as miral doesn't know about this window
+            int id = window->id();
+            int index = indexForId(id);
+            bool focusOther = false;
+            Q_ASSERT(index >= 0);
+            if (window->focused()) {
+                focusOther = true;
+            }
+            m_windowModel[index].application->close();
+            if (focusOther) {
+                activateTopMostWindowWithoutId(id);
+            }
+        }
+    });
+
+    connect(window, &Window::emptyWindowActivated, this, [this, window]() {
+        activateEmptyWindow(window);
+    });
+}
+
+void TopLevelWindowModel::activateEmptyWindow(Window *window)
+{
+    Q_ASSERT(!window->surface());
+    DEBUG_MSG << "(" << window << ")";
+
+    // miral doesn't know about empty windows (ie, windows that are not backed up by MirSurfaces)
+    // So we have to activate them ourselves (instead of asking SurfaceManager to do it for us).
+
+    window->setFocused(true);
+    raiseId(window->id());
+    Window *previousWindow = m_focusedWindow;
+    setFocusedWindow(window);
+    if (previousWindow && previousWindow->surface() && previousWindow->surface()->focused()) {
+        m_surfaceManager->activate(nullptr);
+    }
+}
+
+void TopLevelWindowModel::connectSurface(unityapi::MirSurfaceInterface *surface)
+{
+    connect(surface, &unityapi::MirSurfaceInterface::liveChanged, this, [this, surface](bool live){
+            if (!live) {
+                onSurfaceDied(surface);
+            }
+        });
+    connect(surface, &QObject::destroyed, this, [this, surface](){ this->onSurfaceDestroyed(surface); });
+}
+
+void TopLevelWindowModel::onSurfaceDied(unityapi::MirSurfaceInterface *surface)
+{
+    if (surface->type() == Mir::InputMethodType) {
+        removeInputMethodWindow();
+        return;
+    }
+
+    int i = indexOf(surface);
+    if (i == -1) {
+        return;
+    }
+
+    auto application = m_windowModel[i].application;
+
+    // can't be starting if it already has a surface
+    Q_ASSERT(application->state() != unityapi::ApplicationInfoInterface::Starting);
+
+    if (application->state() == unityapi::ApplicationInfoInterface::Running) {
+        m_windowModel[i].removeOnceSurfaceDestroyed = true;
+    } else {
+        // assume it got killed by the out-of-memory daemon.
+        //
+        // So leave entry in the model and only remove its surface, so shell can display a screenshot
+        // in its place.
+        m_windowModel[i].removeOnceSurfaceDestroyed = false;
+    }
+}
+
+void TopLevelWindowModel::onSurfaceDestroyed(unityapi::MirSurfaceInterface *surface)
+{
+    int i = indexOf(surface);
+    if (i == -1) {
+        return;
+    }
+
+    if (m_windowModel[i].removeOnceSurfaceDestroyed) {
+        removeAt(i);
+    } else {
+        auto window = m_windowModel[i].window;
+        window->setSurface(nullptr);
+        window->setFocused(false);
+        INFO_MSG << " Removed surface from entry. After: " << toString();
+    }
+}
+
+void TopLevelWindowModel::onSurfaceCreated(unityapi::MirSurfaceInterface *surface)
+{
+    DEBUG_MSG << "(" << surface << ")";
+    if (surface->type() == Mir::InputMethodType) {
+        int id = generateId();
+        Window *qmlWindow = new Window(id, this);
+        connectWindow(qmlWindow);
+        qmlWindow->setSurface(surface);
+        setInputMethodWindow(qmlWindow);
+    } else {
+        auto application = m_applicationManager->findApplicationWithSurface(surface);
+        if (application) {
+            prependSurface(surface, application);
+        } else {
+            // Must be a prompt session. No need to do add it as a prompt surface is not top-level.
+            // It will show up in the ApplicationInfoInterface::promptSurfaceList of some application.
+            // Still wrap it in a Window though, so that we keep focusedWindow() up to date.
+            int id = generateId();
+            Window *promptWindow = new Window(id, this);
+            connectWindow(promptWindow);
+            promptWindow->setSurface(surface);
+            connect(surface, &QObject::destroyed, promptWindow, [=](){
+                promptWindow->setSurface(nullptr);
+                promptWindow->deleteLater();
+            });
+        }
+    }
+    // TODO: handle surfaces that are neither top-level windows nor input method. eg: child dialogs, popups, menus
+}
+
+void TopLevelWindowModel::removeAt(int index)
+{
+    if (m_modelState == IdleState) {
+        beginRemoveRows(QModelIndex(), index, index);
+        m_modelState = RemovingState;
+    } else {
+        Q_ASSERT(m_modelState == ResettingState);
+        // No point in signaling anything if we're resetting the whole model
+    }
+
+    auto window = m_windowModel[index].window;
+
+    window->setSurface(nullptr);
+    window->setFocused(false);
+
+    m_windowModel.removeAt(index);
+
+    if (m_modelState == RemovingState) {
+        endRemoveRows();
+        Q_EMIT countChanged();
+        Q_EMIT listChanged();
+        m_modelState = IdleState;
+    }
+
+    disconnect(window, 0, this, 0);
+    if (m_focusedWindow == window) {
+        setFocusedWindow(nullptr);
+    }
+    delete window;
+
+    INFO_MSG << " after " << toString();
+}
+
+void TopLevelWindowModel::setInputMethodWindow(Window *window)
+{
+    if (m_inputMethodWindow) {
+        qWarning("Multiple Input Method Surfaces created, removing the old one!");
+        delete m_inputMethodWindow;
+    }
+    m_inputMethodWindow = window;
+    Q_EMIT inputMethodSurfaceChanged(m_inputMethodWindow->surface());
+}
+
+void TopLevelWindowModel::removeInputMethodWindow()
+{
+    if (m_inputMethodWindow) {
+        delete m_inputMethodWindow;
+        m_inputMethodWindow = nullptr;
+        Q_EMIT inputMethodSurfaceChanged(nullptr);
+    }
+}
+
+void TopLevelWindowModel::onSurfacesRaised(const QVector<unityapi::MirSurfaceInterface*> &surfaces)
+{
+    DEBUG_MSG << "(" << surfaces << ")";
+    const int raiseCount = surfaces.size();
+    for (int i = 0; i < raiseCount; i++) {
+        int fromIndex = findIndexOf(surfaces[i]);
+        if (fromIndex != -1) {
+            move(fromIndex, 0);
+        }
+    }
+}
+
+int TopLevelWindowModel::rowCount(const QModelIndex &/*parent*/) const
+{
+    return m_windowModel.count();
+}
+
+QVariant TopLevelWindowModel::data(const QModelIndex& index, int role) const
+{
+    if (index.row() < 0 || index.row() >= m_windowModel.size())
+        return QVariant();
+
+    if (role == WindowRole) {
+        Window *window = m_windowModel.at(index.row()).window;
+        return QVariant::fromValue(window);
+    } else if (role == ApplicationRole) {
+        return QVariant::fromValue(m_windowModel.at(index.row()).application);
+    } else {
+        return QVariant();
+    }
+}
+
+int TopLevelWindowModel::findIndexOf(const unityapi::MirSurfaceInterface *surface) const
+{
+    for (int i=0; i<m_windowModel.count(); i++) {
+        if (m_windowModel[i].window->surface() == surface) {
+            return i;
+        }
+    }
+    return -1;
+}
+
+int TopLevelWindowModel::generateId()
+{
+    int id = m_nextId;
+    m_nextId = nextFreeId(nextId(id), id);
+    return id;
+}
+
+int TopLevelWindowModel::nextId(int id) const
+{
+    if (id == m_maxId) {
+        return id = 1;
+    } else {
+        return id + 1;
+    }
+}
+
+int TopLevelWindowModel::nextFreeId(int candidateId, const int latestId)
+{
+    int firstCandidateId = candidateId;
+
+    while (indexForId(candidateId) != -1 || candidateId == latestId) {
+        candidateId = nextId(candidateId);
+
+        if (candidateId == firstCandidateId) {
+            qFatal("TopLevelWindowModel: run out of window ids.");
+        }
+    }
+
+    return candidateId;
+}
+
+QString TopLevelWindowModel::toString()
+{
+    QString str;
+    for (int i = 0; i < m_windowModel.count(); ++i) {
+        auto item = m_windowModel.at(i);
+
+        QString itemStr = QString("(index=%1,appId=%2,surface=0x%3,id=%4)")
+            .arg(QString::number(i),
+                 item.application->appId(),
+                 QString::number((qintptr)item.window->surface(), 16),
+                 QString::number(item.window->id()));
+
+        if (i > 0) {
+            str.append(",");
+        }
+        str.append(itemStr);
+    }
+    return str;
+}
+
+int TopLevelWindowModel::indexOf(unityapi::MirSurfaceInterface *surface)
+{
+    for (int i = 0; i < m_windowModel.count(); ++i) {
+        if (m_windowModel.at(i).window->surface() == surface) {
+            return i;
+        }
+    }
+    return -1;
+}
+
+int TopLevelWindowModel::indexForId(int id) const
+{
+    for (int i = 0; i < m_windowModel.count(); ++i) {
+        if (m_windowModel[i].window->id() == id) {
+            return i;
+        }
+    }
+    return -1;
+}
+
+Window *TopLevelWindowModel::windowAt(int index) const
+{
+    if (index >=0 && index < m_windowModel.count()) {
+        return m_windowModel[index].window;
+    } else {
+        return nullptr;
+    }
+}
+
+unityapi::MirSurfaceInterface *TopLevelWindowModel::surfaceAt(int index) const
+{
+    if (index >=0 && index < m_windowModel.count()) {
+        return m_windowModel[index].window->surface();
+    } else {
+        return nullptr;
+    }
+}
+
+unityapi::ApplicationInfoInterface *TopLevelWindowModel::applicationAt(int index) const
+{
+    if (index >=0 && index < m_windowModel.count()) {
+        return m_windowModel[index].application;
+    } else {
+        return nullptr;
+    }
+}
+
+int TopLevelWindowModel::idAt(int index) const
+{
+    if (index >=0 && index < m_windowModel.count()) {
+        return m_windowModel[index].window->id();
+    } else {
+        return 0;
+    }
+}
+
+void TopLevelWindowModel::raiseId(int id)
+{
+    if (m_modelState == IdleState) {
+        DEBUG_MSG << "(id=" << id << ") - do it now.";
+        doRaiseId(id);
+    } else {
+        DEBUG_MSG << "(id=" << id << ") - Model busy (modelState=" << m_modelState << "). Try again in the next event loop.";
+        // The model has just signalled some change. If we have a Repeater responding to this update, it will get nuts
+        // if we perform yet another model change straight away.
+        //
+        // A bad sympton of this problem is a Repeater.itemAt(index) call returning null event though Repeater.count says
+        // the index is definitely within bounds.
+        QMetaObject::invokeMethod(this, "raiseId", Qt::QueuedConnection, Q_ARG(int, id));
+    }
+}
+
+void TopLevelWindowModel::doRaiseId(int id)
+{
+    int fromIndex = indexForId(id);
+    // can't raise something that doesn't exist or that it's already on top
+    if (fromIndex != -1 && fromIndex != 0) {
+        auto surface = m_windowModel[fromIndex].window->surface();
+        if (surface) {
+            m_surfaceManager->raise(surface);
+        } else {
+            // move it ourselves. Since there's no mir::scene::Surface/miral::Window, there's nothing
+            // miral can do about it.
+            move(fromIndex, 0);
+        }
+    }
+}
+
+void TopLevelWindowModel::setFocusedWindow(Window *window)
+{
+    if (window != m_focusedWindow) {
+        INFO_MSG << "(" << window << ")";
+
+        Window* previousWindow = m_focusedWindow;
+
+        m_focusedWindow = window;
+        Q_EMIT focusedWindowChanged(m_focusedWindow);
+
+        if (previousWindow && previousWindow->focused() && !previousWindow->surface()) {
+            // do it ourselves. miral doesn't know about this window
+            previousWindow->setFocused(false);
+        }
+    }
+}
+
+unityapi::MirSurfaceInterface* TopLevelWindowModel::inputMethodSurface() const
+{
+    return m_inputMethodWindow ? m_inputMethodWindow->surface() : nullptr;
+}
+
+Window* TopLevelWindowModel::focusedWindow() const
+{
+    return m_focusedWindow;
+}
+
+void TopLevelWindowModel::move(int from, int to)
+{
+    if (from == to) return;
+    DEBUG_MSG << " from=" << from << " to=" << to;
+
+    if (from >= 0 && from < m_windowModel.size() && to >= 0 && to < m_windowModel.size()) {
+        QModelIndex parent;
+        /* When moving an item down, the destination index needs to be incremented
+           by one, as explained in the documentation:
+           http://qt-project.org/doc/qt-5.0/qtcore/qabstractitemmodel.html#beginMoveRows */
+
+        Q_ASSERT(m_modelState == IdleState);
+        m_modelState = MovingState;
+
+        beginMoveRows(parent, from, from, parent, to + (to > from ? 1 : 0));
+#if QT_VERSION < QT_VERSION_CHECK(5, 6, 0)
+        const auto &window = m_windowModel.takeAt(from);
+        m_windowModel.insert(to, window);
+#else
+        m_windowModel.move(from, to);
+#endif
+        endMoveRows();
+
+        Q_EMIT listChanged();
+        m_modelState = IdleState;
+
+        INFO_MSG << " after " << toString();
+    }
+}
+void TopLevelWindowModel::onModificationsStarted()
+{
+}
+
+void TopLevelWindowModel::onModificationsEnded()
+{
+    if (m_focusedWindowChanged) {
+        setFocusedWindow(m_newlyFocusedWindow);
+    }
+    // reset
+    m_focusedWindowChanged = false;
+    m_newlyFocusedWindow = nullptr;
+}
+
+void TopLevelWindowModel::activateTopMostWindowWithoutId(int forbiddenId)
+{
+    DEBUG_MSG << "(" << forbiddenId << ")";
+
+    for (int i = 0; i < m_windowModel.count(); ++i) {
+        Window *window = m_windowModel[i].window;
+        if (window->id() != forbiddenId) {
+            window->activate();
+        }
+    }
+}

=== added file 'plugins/WindowManager/TopLevelWindowModel.h'
--- plugins/WindowManager/TopLevelWindowModel.h	1970-01-01 00:00:00 +0000
+++ plugins/WindowManager/TopLevelWindowModel.h	2016-12-12 16:49:02 +0000
@@ -0,0 +1,260 @@
+/*
+ * Copyright (C) 2016 Canonical, Ltd.
+ *
+ * This program is free software: you can redistribute it and/or modify it under
+ * the terms of the GNU Lesser General Public License version 3, as published by
+ * the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
+ * SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef TOPLEVELWINDOWMODEL_H
+#define TOPLEVELWINDOWMODEL_H
+
+#include <QAbstractListModel>
+#include <QLoggingCategory>
+
+Q_DECLARE_LOGGING_CATEGORY(TOPLEVELWINDOWMODEL)
+
+class Window;
+
+namespace unity {
+    namespace shell {
+        namespace application {
+            class ApplicationInfoInterface;
+            class ApplicationManagerInterface;
+            class MirSurfaceInterface;
+            class SurfaceManagerInterface;
+        }
+    }
+}
+
+/**
+ * @brief A model of top-level surfaces
+ *
+ * It's an abstraction of top-level application windows.
+ *
+ * When an entry first appears, it normaly doesn't have a surface yet, meaning that the application is
+ * still starting up. A shell should then display a splash screen or saved screenshot of the application
+ * until its surface comes up.
+ *
+ * As applications can have multiple surfaces and you can also have entries without surfaces at all,
+ * the only way to unambiguously refer to an entry in this model is through its id.
+ */
+class TopLevelWindowModel : public QAbstractListModel
+{
+    Q_OBJECT
+
+    /**
+     * @brief Number of top-level surfaces in this model
+     *
+     * This is the same as rowCount, added in order to keep compatibility with QML ListModels.
+     */
+    Q_PROPERTY(int count READ rowCount NOTIFY countChanged)
+
+    /**
+     * @brief The input method surface, if any
+     *
+     * The surface of a onscreen keyboard (akak "virtual keyboard") would be kept here and not in the model itself.
+     */
+    Q_PROPERTY(unity::shell::application::MirSurfaceInterface* inputMethodSurface READ inputMethodSurface NOTIFY inputMethodSurfaceChanged)
+
+    /**
+     * @brief The currently focused window, if any
+     */
+    Q_PROPERTY(Window* focusedWindow READ focusedWindow NOTIFY focusedWindowChanged)
+
+    Q_PROPERTY(unity::shell::application::SurfaceManagerInterface* surfaceManager
+            READ surfaceManager
+            WRITE setSurfaceManager
+            NOTIFY surfaceManagerChanged)
+
+    Q_PROPERTY(unity::shell::application::ApplicationManagerInterface* applicationManager
+            READ applicationManager
+            WRITE setApplicationManager
+            NOTIFY applicationManagerChanged)
+
+    /**
+      The id to be used on the next entry created
+      Useful for tests
+     */
+    Q_PROPERTY(int nextId READ nextId NOTIFY nextIdChanged)
+
+public:
+    /**
+     * @brief The Roles supported by the model
+     *
+     * WindowRole - A Window.
+     * ApplicationRole - An ApplicationInfoInterface
+     */
+    enum Roles {
+        WindowRole = Qt::UserRole,
+        ApplicationRole = Qt::UserRole + 1,
+    };
+
+    TopLevelWindowModel();
+
+    // From QAbstractItemModel
+    int rowCount(const QModelIndex &parent = QModelIndex()) const override;
+    QVariant data(const QModelIndex& index, int role) const override;
+    QHash<int, QByteArray> roleNames() const override {
+        QHash<int, QByteArray> roleNames { {WindowRole, "window"},
+                                           {ApplicationRole, "application"} };
+        return roleNames;
+    }
+
+    // Own API
+
+    unity::shell::application::MirSurfaceInterface* inputMethodSurface() const;
+    Window* focusedWindow() const;
+
+    unity::shell::application::ApplicationManagerInterface *applicationManager() const { return m_applicationManager; }
+    void setApplicationManager(unity::shell::application::ApplicationManagerInterface*);
+
+    unity::shell::application::SurfaceManagerInterface *surfaceManager() const { return m_surfaceManager; }
+    void setSurfaceManager(unity::shell::application::SurfaceManagerInterface*);
+
+    int nextId() const { return m_nextId; }
+
+public:
+    /**
+     * @brief Returns the surface at the given index
+     *
+     * It will be a nullptr if the application is still starting up and thus hasn't yet created
+     * and drawn into a surface.
+     *
+     * Same as windowAt(index).surface()
+     */
+    Q_INVOKABLE unity::shell::application::MirSurfaceInterface *surfaceAt(int index) const;
+
+    /**
+     * @brief Returns the window at the given index
+     *
+     * Will always be valid
+     */
+    Q_INVOKABLE Window *windowAt(int index) const;
+
+    /**
+     * @brief Returns the application at the given index
+     */
+    Q_INVOKABLE unity::shell::application::ApplicationInfoInterface *applicationAt(int index) const;
+
+    /**
+     * @brief Returns the unique id of the element at the given index
+     */
+    Q_INVOKABLE int idAt(int index) const;
+
+    /**
+     * @brief Returns the index where the row with the given id is located
+     *
+     * Returns -1 if there's no row with the given id.
+     */
+    Q_INVOKABLE int indexForId(int id) const;
+
+    /**
+     * @brief Raises the row with the given id to the top of the window stack (index == count-1)
+     */
+    Q_INVOKABLE void raiseId(int id);
+
+Q_SIGNALS:
+    void countChanged();
+    void inputMethodSurfaceChanged(unity::shell::application::MirSurfaceInterface* inputMethodSurface);
+    void focusedWindowChanged(Window *focusedWindow);
+    void applicationManagerChanged(unity::shell::application::ApplicationManagerInterface*);
+    void surfaceManagerChanged(unity::shell::application::SurfaceManagerInterface*);
+
+    /**
+     * @brief Emitted when the list changes
+     *
+     * Emitted when model gains an element, loses an element or when elements exchange positions.
+     */
+    void listChanged();
+
+    void nextIdChanged();
+
+private Q_SLOTS:
+    void onSurfaceCreated(unity::shell::application::MirSurfaceInterface *surface);
+    void onSurfacesRaised(const QVector<unity::shell::application::MirSurfaceInterface*> &surfaces);
+
+    void onModificationsStarted();
+    void onModificationsEnded();
+
+private:
+    void doRaiseId(int id);
+    int generateId();
+    int nextFreeId(int candidateId, const int latestId);
+    int nextId(int id) const;
+    QString toString();
+    int indexOf(unity::shell::application::MirSurfaceInterface *surface);
+
+    void setInputMethodWindow(Window *window);
+    void setFocusedWindow(Window *window);
+    void removeInputMethodWindow();
+    int findIndexOf(const unity::shell::application::MirSurfaceInterface *surface) const;
+    void removeAt(int index);
+
+    void addApplication(unity::shell::application::ApplicationInfoInterface *application);
+    void removeApplication(unity::shell::application::ApplicationInfoInterface *application);
+
+    void prependPlaceholder(unity::shell::application::ApplicationInfoInterface *application);
+    void prependSurface(unity::shell::application::MirSurfaceInterface *surface,
+                        unity::shell::application::ApplicationInfoInterface *application);
+    void prependSurfaceHelper(unity::shell::application::MirSurfaceInterface *surface,
+                              unity::shell::application::ApplicationInfoInterface *application);
+
+    void connectWindow(Window *window);
+    void connectSurface(unity::shell::application::MirSurfaceInterface *surface);
+
+    void onSurfaceDied(unity::shell::application::MirSurfaceInterface *surface);
+    void onSurfaceDestroyed(unity::shell::application::MirSurfaceInterface *surface);
+
+    void move(int from, int to);
+
+    void activateEmptyWindow(Window *window);
+
+    void activateTopMostWindowWithoutId(int forbiddenId);
+
+    struct ModelEntry {
+        ModelEntry() {}
+        ModelEntry(Window *window,
+                   unity::shell::application::ApplicationInfoInterface *application)
+            : window(window), application(application) {}
+        Window *window{nullptr};
+        unity::shell::application::ApplicationInfoInterface *application{nullptr};
+        bool removeOnceSurfaceDestroyed{false};
+    };
+
+    QVector<ModelEntry> m_windowModel;
+    Window* m_inputMethodWindow{nullptr};
+    Window* m_focusedWindow{nullptr};
+
+    int m_nextId{1};
+    // Just something big enough that we don't risk running out of unused id numbers.
+    // Not sure if QML int type supports something close to std::numeric_limits<int>::max() and
+    // there's no reason to try out its limits.
+    static const int m_maxId{1000000};
+
+    unity::shell::application::ApplicationManagerInterface* m_applicationManager{nullptr};
+    unity::shell::application::SurfaceManagerInterface *m_surfaceManager{nullptr};
+
+    enum ModelState {
+        IdleState,
+        InsertingState,
+        RemovingState,
+        MovingState,
+        ResettingState
+    };
+    ModelState m_modelState{IdleState};
+
+    // Valid between modificationsStarted and modificationsEnded
+    bool m_focusedWindowChanged{false};
+    Window *m_newlyFocusedWindow{nullptr};
+};
+
+#endif // TOPLEVELWINDOWMODEL_H

=== added file 'plugins/WindowManager/Window.cpp'
--- plugins/WindowManager/Window.cpp	1970-01-01 00:00:00 +0000
+++ plugins/WindowManager/Window.cpp	2016-12-12 16:49:02 +0000
@@ -0,0 +1,237 @@
+/*
+ * Copyright (C) 2016 Canonical, Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "Window.h"
+
+// unity-api
+#include <unity/shell/application/MirSurfaceInterface.h>
+
+#include <QQmlEngine>
+#include <QTextStream>
+
+namespace unityapi = unity::shell::application;
+
+Q_LOGGING_CATEGORY(UNITY_WINDOW, "unity.window", QtWarningMsg)
+
+#define DEBUG_MSG qCDebug(UNITY_WINDOW).nospace() << qPrintable(toString()) << "::" << __func__
+
+Window::Window(int id, QObject *parent)
+    : QObject(parent)
+    , m_id(id)
+{
+    DEBUG_MSG << "()";
+    QQmlEngine::setObjectOwnership(this, QQmlEngine::CppOwnership);
+}
+
+Window::~Window()
+{
+    DEBUG_MSG << "()";
+}
+
+QPoint Window::position() const
+{
+    return m_position;
+}
+
+QPoint Window::requestedPosition() const
+{
+    return m_requestedPosition;
+}
+
+void Window::setRequestedPosition(const QPoint &value)
+{
+    m_positionRequested = true;
+    if (value != m_requestedPosition) {
+        m_requestedPosition = value;
+        Q_EMIT requestedPositionChanged(m_requestedPosition);
+        if (m_surface) {
+            m_surface->setRequestedPosition(value);
+        } else {
+            // fake-miral: always comply
+            m_position = m_requestedPosition;
+            Q_EMIT positionChanged(m_position);
+        }
+    }
+}
+
+Mir::State Window::state() const
+{
+    return m_state;
+}
+
+bool Window::focused() const
+{
+    return m_focused;
+}
+
+bool Window::confinesMousePointer() const
+{
+    if (m_surface) {
+        return m_surface->confinesMousePointer();
+    } else {
+        return false;
+    }
+}
+
+int Window::id() const
+{
+    return m_id;
+}
+
+unityapi::MirSurfaceInterface* Window::surface() const
+{
+    return m_surface;
+}
+
+void Window::requestState(Mir::State state)
+{
+    m_stateRequested = true;
+    if (m_surface) {
+        m_surface->requestState(state);
+    } else if (m_state != state) {
+        m_state = state;
+        Q_EMIT stateChanged(m_state);
+    }
+}
+
+void Window::close()
+{
+    if (m_surface) {
+        m_surface->close();
+    } else {
+        Q_EMIT closeRequested();
+    }
+}
+
+void Window::activate()
+{
+    DEBUG_MSG << "()";
+    if (m_surface) {
+        m_surface->activate();
+    } else {
+        Q_EMIT emptyWindowActivated();
+    }
+}
+
+void Window::setSurface(unityapi::MirSurfaceInterface *surface)
+{
+    DEBUG_MSG << "(" << surface << ")";
+    if (m_surface) {
+        disconnect(m_surface, 0, this, 0);
+    }
+
+    m_surface = surface;
+
+    if (m_surface) {
+        connect(surface, &unityapi::MirSurfaceInterface::focusRequested, this, [this]() {
+            Q_EMIT focusRequested();
+        });
+
+        connect(surface, &unityapi::MirSurfaceInterface::closeRequested, this, &Window::closeRequested);
+
+        connect(surface, &unityapi::MirSurfaceInterface::positionChanged, this, [this]() {
+            updatePosition();
+        });
+
+        connect(surface, &unityapi::MirSurfaceInterface::stateChanged, this, [this]() {
+            updateState();
+        });
+
+        connect(surface, &unityapi::MirSurfaceInterface::focusedChanged, this, [this]() {
+            updateFocused();
+        });
+
+        // bring it up to speed
+        if (m_positionRequested) {
+            m_surface->setRequestedPosition(m_requestedPosition);
+        }
+        if (m_stateRequested && m_surface->state() == Mir::RestoredState) {
+            m_surface->requestState(m_state);
+        }
+
+        // and sync with surface
+        updatePosition();
+        updateState();
+        updateFocused();
+    }
+
+    Q_EMIT surfaceChanged(surface);
+}
+
+void Window::updatePosition()
+{
+    if (m_surface->position() != m_position) {
+        m_position = m_surface->position();
+        Q_EMIT positionChanged(m_position);
+    }
+}
+
+void Window::updateState()
+{
+    if (m_surface->state() != m_state) {
+        m_state = m_surface->state();
+        Q_EMIT stateChanged(m_state);
+    }
+}
+
+void Window::updateFocused()
+{
+    if (m_surface->focused() != m_focused) {
+        m_focused = m_surface->focused();
+        Q_EMIT focusedChanged(m_focused);
+    }
+}
+
+void Window::setFocused(bool value)
+{
+    if (value != m_focused) {
+        DEBUG_MSG << "(" << value << ")";
+        m_focused = value;
+        Q_EMIT focusedChanged(m_focused);
+        // when we have a surface we get focus changes from updateFocused() instead
+        Q_ASSERT(!m_surface);
+    }
+}
+
+QString Window::toString() const
+{
+    QString result;
+    {
+        QTextStream stream(&result);
+        stream << "Window["<<(void*)this<<", id="<<id()<<", ";
+        if (surface()) {
+            stream << "MirSurface["<<(void*)surface()<<",\""<<surface()->name()<<"\"]";
+        } else {
+            stream << "null";
+        }
+        stream << "]";
+    }
+    return result;
+}
+
+QDebug operator<<(QDebug dbg, const Window *window)
+{
+    QDebugStateSaver saver(dbg);
+    dbg.nospace();
+
+    if (window) {
+        dbg << qPrintable(window->toString());
+    } else {
+        dbg << (void*)(window);
+    }
+
+    return dbg;
+}

=== added file 'plugins/WindowManager/Window.h'
--- plugins/WindowManager/Window.h	1970-01-01 00:00:00 +0000
+++ plugins/WindowManager/Window.h	2016-12-12 16:49:02 +0000
@@ -0,0 +1,161 @@
+/*
+ * Copyright (C) 2016 Canonical, Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef UNITY_WINDOW_H
+#define UNITY_WINDOW_H
+
+#include <QLoggingCategory>
+#include <QObject>
+#include <QPoint>
+
+// Unity API
+#include <unity/shell/application/Mir.h>
+
+namespace unity {
+    namespace shell {
+        namespace application {
+            class MirSurfaceInterface;
+        }
+    }
+}
+
+
+Q_DECLARE_LOGGING_CATEGORY(UNITY_WINDOW)
+
+/**
+   @brief A slightly higher concept than MirSurface
+
+   A Window exists before its MirSurface gets created (for splashscreen purposes)
+   and might also hang around after the backing surface is gone (In case the application
+   was killed to free up memory, as it should still remain in the window list since the user
+   did not explicitly close it).
+ */
+class Window : public QObject
+{
+    Q_OBJECT
+
+    /**
+     * @brief Position of the current surface buffer, in pixels.
+     */
+    Q_PROPERTY(QPoint position READ position NOTIFY positionChanged)
+
+    /**
+     * @brief Requested position of the current surface buffer, in pixels.
+     */
+    Q_PROPERTY(QPoint requestedPosition READ requestedPosition WRITE setRequestedPosition NOTIFY requestedPositionChanged)
+
+    /**
+     * @brief State of the surface
+     */
+    Q_PROPERTY(Mir::State state READ state NOTIFY stateChanged)
+
+    /**
+     * @brief Whether the surface is focused
+     *
+     * It will be true if this surface is MirFocusControllerInterface::focusedSurface
+     */
+    Q_PROPERTY(bool focused READ focused NOTIFY focusedChanged)
+
+    /**
+     * @brief Whether the surface wants to confine the mouse pointer within its boundaries
+     *
+     * If true, the surface doesn't want the mouse pointer to leave its boundaries while it's focused.
+     */
+    Q_PROPERTY(bool confinesMousePointer READ confinesMousePointer NOTIFY confinesMousePointerChanged)
+
+    /**
+     * @brief A unique identifier for this window.
+     * Useful for telling windows apart in a list model as they get moved around
+     */
+    Q_PROPERTY(int id READ id CONSTANT)
+
+    /**
+     * @brief Surface backing up this window
+     * It might be null if a surface hasn't been created yet (application is starting up) or if
+     * the corresponding application has been killed (but can still get restarted to continue from
+     * where it left)
+     */
+    Q_PROPERTY(unity::shell::application::MirSurfaceInterface* surface READ surface NOTIFY surfaceChanged)
+
+public:
+    Window(int id, QObject *parent = nullptr);
+    virtual ~Window();
+    QPoint position() const;
+    QPoint requestedPosition() const;
+    void setRequestedPosition(const QPoint &);
+    Mir::State state() const;
+    bool focused() const;
+    bool confinesMousePointer() const;
+    int id() const;
+    unity::shell::application::MirSurfaceInterface* surface() const;
+
+    void setSurface(unity::shell::application::MirSurfaceInterface *surface);
+    void setFocused(bool value);
+
+    QString toString() const;
+
+public Q_SLOTS:
+    /**
+     * @brief Requests a change to the specified state
+     */
+    void requestState(Mir::State state);
+
+    /**
+     * @brief Sends a close request
+     *
+     */
+    void close();
+
+    /**
+     * @brief Focuses and raises the window
+     */
+    void activate();
+
+Q_SIGNALS:
+    void closeRequested();
+    void emptyWindowActivated();
+
+    void positionChanged(QPoint position);
+    void requestedPositionChanged(QPoint position);
+    void stateChanged(Mir::State value);
+    void focusedChanged(bool value);
+    void confinesMousePointerChanged(bool value);
+    void surfaceChanged(unity::shell::application::MirSurfaceInterface *surface);
+
+    /**
+     * @brief Emitted when focus for this window is requested by an external party
+     */
+    void focusRequested();
+
+private:
+    void updatePosition();
+    void updateState();
+    void updateFocused();
+
+    QPoint m_position;
+    QPoint m_requestedPosition;
+    bool m_positionRequested{false};
+    bool m_focused{false};
+    int m_id;
+    Mir::State m_state{Mir::RestoredState};
+    bool m_stateRequested{false};
+    unity::shell::application::MirSurfaceInterface *m_surface{nullptr};
+};
+
+QDebug operator<<(QDebug dbg, const Window *window);
+
+Q_DECLARE_METATYPE(Window*)
+#endif // UNITY_WINDOW_H

=== modified file 'plugins/WindowManager/WindowManagerPlugin.cpp'
--- plugins/WindowManager/WindowManagerPlugin.cpp	2016-04-04 13:37:49 +0000
+++ plugins/WindowManager/WindowManagerPlugin.cpp	2016-12-12 16:49:02 +0000
@@ -16,13 +16,16 @@
 
 #include "WindowManagerPlugin.h"
 
-#include "TopLevelSurfaceList.h"
+#include "TopLevelWindowModel.h"
+#include "Window.h"
 
 #include <QtQml>
 
 void WindowManagerPlugin::registerTypes(const char *uri)
 {
-    qmlRegisterType<TopLevelSurfaceList>(uri, 0, 1, "TopLevelSurfaceList");
+    qmlRegisterType<TopLevelWindowModel>(uri, 1, 0, "TopLevelWindowModel");
+
+    qRegisterMetaType<Window*>("Window*");
 
     qRegisterMetaType<QAbstractListModel*>("QAbstractListModel*");
 }

=== modified file 'po/unity8.pot'
--- po/unity8.pot	2016-11-29 09:43:33 +0000
+++ po/unity8.pot	2016-12-12 16:49:02 +0000
@@ -8,7 +8,7 @@
 msgstr ""
 "Project-Id-Version: unity8\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2016-11-29 09:43+0000\n"
+"POT-Creation-Date: 2016-12-07 13:49+0000\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[e-mail]>\n"
@@ -23,7 +23,7 @@
 msgstr ""
 
 #: plugins/Unity/Launcher/launcheritem.cpp:50
-#: plugins/Unity/Launcher/launcheritem.cpp:109
+#: plugins/Unity/Launcher/launcheritem.cpp:122
 msgid "Pin shortcut"
 msgstr ""
 
@@ -31,7 +31,7 @@
 msgid "Quit"
 msgstr ""
 
-#: plugins/Unity/Launcher/launcheritem.cpp:109
+#: plugins/Unity/Launcher/launcheritem.cpp:122
 msgid "Unpin shortcut"
 msgstr ""
 
@@ -175,87 +175,95 @@
 msgid "Same as clicking on a launcher icon."
 msgstr ""
 
-#: qml/Components/KeyboardShortcutsOverlay.qml:181
+#: qml/Components/KeyboardShortcutsOverlay.qml:177
+msgid "Super + A"
+msgstr ""
+