Merge lp:~dandrader/unity8/fix_lp1236773 into lp:unity8

Proposed by Daniel d'Andrada
Status: Merged
Approved by: Michał Sawicz
Approved revision: 407
Merged at revision: 409
Proposed branch: lp:~dandrader/unity8/fix_lp1236773
Merge into: lp:unity8
Diff against target: 25 lines (+4/-4)
1 file modified
Shell.qml (+4/-4)
To merge this branch: bzr merge lp:~dandrader/unity8/fix_lp1236773
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michał Sawicz Approve
Review via email: mp+189821@code.launchpad.net

Commit message

Move OSKController to the front as it will now also block input meant to the OSK

That's in the unity-mir implementation. The SurfaceFlinger one is still an empty noop.

Currently, when the OSK is up, both shell and OSK get user input, thus we need the
OSKController to shield our shell components from them.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:407
http://jenkins.qa.ubuntu.com/job/unity8-ci/1313/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4778
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2607/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/2171
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-amd64-ci/336
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1313
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1313/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/1312
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/958
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/653
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/653/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2609
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2609/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2156
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2169/console

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1313/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity8-autolanding/602/
Executed test runs:
    SUCCESS: http://10.97.0.26:8080/job/generic-cleanup-mbs/2749
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4780
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2613/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/2173
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-amd64-autolanding/187
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-autolanding/606
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-autolanding/606/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-autolanding/606
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/960
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/655
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/655/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2615
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2615/artifact/work/output/*zip*/output.zip
    ABORTED: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2161/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2175/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

mako died during testing. It was set offline to be worked.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity8-autolanding/605/
Executed test runs:
    SUCCESS: http://10.97.0.26:8080/job/generic-cleanup-mbs/2753
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4789
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2625
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/2179
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-amd64-autolanding/190
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-autolanding/609
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-autolanding/609/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-autolanding/609
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/969
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/664
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/664/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2627
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2627/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2174
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2187

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Shell.qml'
2--- Shell.qml 2013-10-08 00:01:04 +0000
3+++ Shell.qml 2013-10-08 11:37:24 +0000
4@@ -160,10 +160,6 @@
5 }
6 }
7
8- OSKController {
9- anchors.fill: parent // as needs to know the geometry of the shell
10- }
11-
12 VolumeControl {
13 id: volumeControl
14 }
15@@ -731,6 +727,10 @@
16 value: "unity8"
17 }
18
19+ OSKController {
20+ anchors.fill: parent // as needs to know the geometry of the shell
21+ }
22+
23 //FIXME: This should be handled in the input stack, keyboard shouldnt propagate
24 MouseArea {
25 anchors.bottom: parent.bottom

Subscribers

People subscribed via source and target branches