Merge lp:~dandrader/unity8/fallbackCursorNames into lp:unity8

[Daniel d'Andrada]

Cursor: Add more fallback names, a blank and custom cursor support

For testing (assuming a laptop/desktop in the instructions below), use the following application:
$ bzr branch lp:~dandrader/+junk/animatedDemos
$ cd animatedDemos/CustomCursor/
animatedDemos/CustomCursor$ qmake && make
animatedDemos/CustomCursor$ cd ..
animatedDemos$ vim football.desktop (edit the Icon path appropriately)
animatedDemos$ unset QT_QPA_PLATFORMTHEME
animatedDemos$ export MIR_SOCKET=/var/run/user/YOUR-UID/mir_socket
animatedDemos$ export QT_QPA_PLATFORM=ubuntumirclient
animatedDemos$ qmlscene -I . CursorShapes.qml --desktop_file_hint=PATH-TO-HERE/animatedDemos/football.desktop

* Are there any related MPs required for this MP to build/function as expected? Please list.
https://code.launchpad.net/~dandrader/unity-api/surfaceCursor/+merge/277283
https://code.launchpad.net/~dandrader/qtmir/surfaceCursor/+merge/277286
https://code.launchpad.net/~dandrader/qtubuntu/cursor/+merge/277285

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes, on a test laptop running a unity8-mir session.

* Did you make sure that your branch does not contain spurious tags?
Yes.

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable

* If you changed the UI, has there been a design review?
Not applicable

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:2037
http://jenkins.qa.ubuntu.com/job/unity8-ci/6699/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5127/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-xenial-touch/114/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1411/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-qmluitest-xenial-amd64/114/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1306/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1307/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-xenial-amd64-ci/113/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-xenial-i386-ci/113/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5139/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/114/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6699/rebuild

review: Needs Fixing (continuous-integration)

[Lukáš Tinkl (lukas-kde)]

QList<QString> -> QStringList (in various places)

review: Needs Fixing

[Lukáš Tinkl (lukas-kde)]

Now that we've got this client side cursor stuff in place, I'd like to see it used in WindowResizeArea.qml (it's a MouseArea so you should be able to set its "cursorShape" properly).

review: Needs Fixing

[Lukáš Tinkl (lukas-kde)]

There are still many more fallback names missing, looks like QtWayland has a more complete list:

http://code.woboq.org/qt5/qtwayland/src/client/qwaylandcursor.cpp.html#_ZN15QtWaylandClient14QWaylandCursor13initCursorMapEv

review: Needs Fixing

[Daniel d'Andrada (dandrader)]

On 13/11/2015 12:05, Lukáš Tinkl wrote:
> Review: Needs Fixing
>
> Now that we've got this client side cursor stuff in place, I'd like to see it used in WindowResizeArea.qml (it's a MouseArea so you should be able to set its "cursorShape" properly).

This is not related and that's not possible.

1 - WindowResizeArea not on client side.
2 - WindowResizeArea uses cursor names that have no counterpart in
Qt::CursorShape. That's the whole point for having Mir.cursorName in the
first place.

[lp:~dandrader/unity8/fallbackCursorNames]

2038. By Daniel d'Andrada on 2015-11-16

s/QList<QString>/QStringList

[Daniel d'Andrada (dandrader)]

On 13/11/2015 12:03, Lukáš Tinkl wrote:
> Review: Needs Fixing
>
> QList<QString> -> QStringList (in various places)

Done.
I only found "QMap<QString, QList<QString>> m_fallbackNames" though.

[Lukáš Tinkl (lukas-kde)]

> On 13/11/2015 12:05, Lukáš Tinkl wrote:
> > Review: Needs Fixing
> >
> > Now that we've got this client side cursor stuff in place, I'd like to see
> it used in WindowResizeArea.qml (it's a MouseArea so you should be able to set
> its "cursorShape" properly).
>
> This is not related and that's not possible.

Ack, I see

[lp:~dandrader/unity8/fallbackCursorNames]

2039. By Daniel d'Andrada on 2015-11-16

Extend fallback names

[Daniel d'Andrada (dandrader)]

On 13/11/2015 13:54, Lukáš Tinkl wrote:
> Review: Needs Fixing
>
> There are still many more fallback names missing, looks like QtWayland has a more complete list:
>
> http://code.woboq.org/qt5/qtwayland/src/client/qwaylandcursor.cpp.html#_ZN15QtWaylandClient14QWaylandCursor13initCursorMapEv

Would say more complete as for some items here and there we do diverge.
But they have more stuff indeed. Added the non-conflicting ones.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:2038
http://jenkins.qa.ubuntu.com/job/unity8-ci/6713/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5171/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-xenial-touch/128/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1425/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-qmluitest-xenial-amd64/128/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1320/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1321/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-xenial-amd64-ci/127/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-xenial-i386-ci/127/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5185/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/128/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6713/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:2039
http://jenkins.qa.ubuntu.com/job/unity8-ci/6714/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5185/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-xenial-touch/129/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1426/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-qmluitest-xenial-amd64/129/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1321/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1322/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-xenial-amd64-ci/128/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-xenial-i386-ci/128/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5202/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/129/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6714/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:2038
http://jenkins.qa.ubuntu.com/job/unity8-ci/6727/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5221/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-xenial-touch/142/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1440/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-qmluitest-xenial-amd64/142/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1334/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1335/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-xenial-amd64-ci/141/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-xenial-i386-ci/141/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5238/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/142/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6727/rebuild

review: Needs Fixing (continuous-integration)

[Lukáš Tinkl (lukas-kde)]

The SizeAll and OpenHand cursors don't work for me (Qt::OpenHandCursor and Qt::SizeAllCursor), the rest is fine. Also, having tested this in a webbrowser, it works pretty fine.

review: Needs Fixing

[Daniel d'Andrada (dandrader)]

On 18/11/2015 17:46, Lukáš Tinkl wrote:
> Review: Needs Fixing
>
> The SizeAll and OpenHand cursors don't work for me (Qt::OpenHandCursor and Qt::SizeAllCursor), the rest is fine. Also, having tested this in a webbrowser, it works pretty fine.
Because DMZ theme doesn't have them. Providing cursors for all shapes is
beyond the scope of this patch.

This patch is solely about enabling client applications to set the
cursor shape.

[Lukáš Tinkl (lukas-kde)]

Approving, works fine (modulo the missing SizeAll and OpenHand cursors due to incomplete DMZ theme). However, as I could test this only with the default DMZ theme, filing a bug report about broken non-default theme loading.

* Did you perform an exploratory manual test run of the code change and any related functionality?

Yes

* Did CI run pass? If not, please explain why.

No, incompatible unity-api

* Did you make sure that the branch does not contain spurious tags?

Yes

review: Approve

[Michał Sawicz (saviq)]

review: Needs Fixing

[lp:~dandrader/unity8/fallbackCursorNames]

2040. By Daniel d'Andrada on 2015-11-23

Update libunity-api-dev version dependency

[Daniel d'Andrada (dandrader)]

On 23/11/2015 07:41, Michał Sawicz wrote:
> Review: Needs Fixing
>
>
>
> Diff comments:
>
>> === modified file 'debian/control'
> You need to bump the unity-api Build-Depends to >=7.103
>
>
>

Done.

[Michał Sawicz (saviq)]

review: Abstain

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2015-11-04 14:57:54 +0000
+++ CMakeLists.txt	2015-11-23 11:13:25 +0000
@@ -57,7 +57,7 @@
 find_package(Qt5Concurrent 5.4 REQUIRED)
 find_package(Qt5Sql 5.4 REQUIRED)
 
-pkg_check_modules(APPLICATION_API REQUIRED unity-shell-application=10)
+pkg_check_modules(APPLICATION_API REQUIRED unity-shell-application=11)
 
 # Standard install paths
 include(GNUInstallDirs)

=== modified file 'debian/control'
--- debian/control	2015-11-12 20:40:56 +0000
+++ debian/control	2015-11-23 11:13:25 +0000
@@ -29,7 +29,7 @@
                libqt5xmlpatterns5-dev,
                libsystemsettings-dev,
                libudev-dev,
-               libunity-api-dev (>= 7.102),
+               libunity-api-dev (>= 7.103),
                libusermetricsoutput1-dev,
                libxcb1-dev,
                pkg-config,
@@ -128,7 +128,7 @@
          qtdeclarative5-ubuntu-ui-toolkit-plugin (>= 1.3.1627) | qtdeclarative5-ubuntu-ui-toolkit-plugin-gles (>= 1.3.1627),
          qtdeclarative5-unity-notifications-plugin (>= 0.1.2) | unity-notifications-impl,
          ubuntu-thumbnailer-impl-0,
-         unity-application-impl-10,
+         unity-application-impl-11,
          unity-notifications-impl-3,
          unity-plugin-scopes | unity-scopes-impl,
          unity-scopes-impl-7,
@@ -174,7 +174,7 @@
 Depends: ${misc:Depends},
          ${shlibs:Depends},
 Provides: unity-application-impl,
-          unity-application-impl-10,
+          unity-application-impl-11,
 Replaces: unity8-autopilot (<< 8.02+15.04.20150422-0ubuntu1)
 Description: Fake environment for running Unity 8 shell
  Provides fake implementations of some QML modules used by Unity 8 shell

=== modified file 'plugins/Cursor/CursorImageProvider.cpp'
--- plugins/Cursor/CursorImageProvider.cpp	2015-09-29 13:45:05 +0000
+++ plugins/Cursor/CursorImageProvider.cpp	2015-11-23 11:13:25 +0000
@@ -16,6 +16,7 @@
 
 #include "CursorImageProvider.h"
 
+#include <QCursor>
 #include <QDebug>
 #include <QFile>
 #include <QPainter>
@@ -50,6 +51,26 @@
 }
 
 /////
+// BlankCursorImage
+
+
+BlankCursorImage::BlankCursorImage()
+{
+    qimage = QImage(1, 1, QImage::Format_ARGB32);
+    qimage.fill(Qt::transparent);
+}
+
+/////
+// CustomCursorImage
+
+
+CustomCursorImage::CustomCursorImage(const QCursor &cursor)
+{
+    qimage = cursor.pixmap().toImage();
+    hotspot = cursor.hotSpot();
+}
+
+/////
 // XCursorImage
 
 XCursorImage::XCursorImage(const QString &theme, const QString &file)
@@ -91,6 +112,68 @@
         qFatal("Cannot have multiple CursorImageProvider instances");
     }
     m_instance = this;
+
+    m_fallbackNames[QLatin1String("closedhand")].append(QLatin1String("grabbing"));
+    m_fallbackNames[QLatin1String("closedhand")].append(QLatin1String("dnd-none"));
+
+    m_fallbackNames[QLatin1String("dnd-copy")].append(QLatin1String("dnd-none"));
+    m_fallbackNames[QLatin1String("dnd-copy")].append(QLatin1String("grabbing"));
+    m_fallbackNames[QLatin1String("dnd-copy")].append(QLatin1String("closedhand"));
+
+    m_fallbackNames[QLatin1String("dnd-move")].append(QLatin1String("dnd-none"));
+    m_fallbackNames[QLatin1String("dnd-move")].append(QLatin1String("grabbing"));
+    m_fallbackNames[QLatin1String("dnd-move")].append(QLatin1String("closedhand"));
+
+    m_fallbackNames[QLatin1String("dnd-link")].append(QLatin1String("dnd-none"));
+    m_fallbackNames[QLatin1String("dnd-link")].append(QLatin1String("grabbing"));
+    m_fallbackNames[QLatin1String("dnd-link")].append(QLatin1String("closedhand"));
+
+    m_fallbackNames[QLatin1String("forbidden")].append(QLatin1String("crossed_circle")); // DMZ-White and DMZ-Black themes
+    m_fallbackNames[QLatin1String("forbidden")].append(QLatin1String("not-allowed"));
+    m_fallbackNames[QLatin1String("forbidden")].append(QLatin1String("circle"));
+
+    m_fallbackNames[QLatin1String("hand")].append(QLatin1String("pointing_hand"));
+    m_fallbackNames[QLatin1String("hand")].append(QLatin1String("pointer"));
+
+    m_fallbackNames[QLatin1String("ibeam")].append(QLatin1String("xterm"));
+    m_fallbackNames[QLatin1String("ibeam")].append(QLatin1String("text"));
+
+    m_fallbackNames[QLatin1String("left_ptr")].append(QLatin1String("default"));
+    m_fallbackNames[QLatin1String("left_ptr")].append(QLatin1String("top_left_arrow"));
+    m_fallbackNames[QLatin1String("left_ptr")].append(QLatin1String("left_arrow"));
+
+    m_fallbackNames[QLatin1String("left_ptr_watch")].append(QLatin1String("half-busy"));
+    m_fallbackNames[QLatin1String("left_ptr_watch")].append(QLatin1String("progress"));
+
+    m_fallbackNames[QLatin1String("size_bdiag")].append(QLatin1String("fd_double_arrow"));
+    m_fallbackNames[QLatin1String("size_bdiag")].append(QLatin1String("nesw-resize"));
+
+    m_fallbackNames[QLatin1String("size_fdiag")].append(QLatin1String("bd_double_arrow")); // DMZ-White and DMZ-Black themes
+    m_fallbackNames[QLatin1String("size_fdiag")].append(QLatin1String("nwse-resize"));
+
+    m_fallbackNames[QLatin1String("size_hor")].append(QLatin1String("sb_h_double_arrow")); // DMZ-White and DMZ-Black themes
+    m_fallbackNames[QLatin1String("size_hor")].append(QLatin1String("ew-resize"));
+    m_fallbackNames[QLatin1String("size_hor")].append(QLatin1String("h_double_arrow"));
+
+    m_fallbackNames[QLatin1String("size_ver")].append(QLatin1String("sb_v_double_arrow")); // DMZ-White and DMZ-Black themes
+    m_fallbackNames[QLatin1String("size_ver")].append(QLatin1String("ns-resize"));
+    m_fallbackNames[QLatin1String("size_ver")].append(QLatin1String("v_double_arrow"));
+
+    m_fallbackNames[QLatin1String("split_h")].append(QLatin1String("sb_h_double_arrow")); // DMZ-White and DMZ-Black themes
+    m_fallbackNames[QLatin1String("split_h")].append(QLatin1String("col-resize"));
+
+    m_fallbackNames[QLatin1String("split_v")].append(QLatin1String("sb_v_double_arrow")); // DMZ-White and DMZ-Black themes
+    m_fallbackNames[QLatin1String("split_v")].append(QLatin1String("row-resize"));
+
+    m_fallbackNames[QLatin1String("up_arrow")].append(QLatin1String("sb_up_arrow")); // DMZ-White and DMZ-Black themes
+
+    m_fallbackNames[QLatin1String("watch")].append(QLatin1String("wait"));
+
+    m_fallbackNames[QLatin1String("whats_this")].append(QLatin1String("left_ptr_help"));
+    m_fallbackNames[QLatin1String("whats_this")].append(QLatin1String("help"));
+    m_fallbackNames[QLatin1String("whats_this")].append(QLatin1String("question_arrow"));
+
+    m_fallbackNames[QLatin1String("xterm")].append(QLatin1String("ibeam"));
 }
 
 CursorImageProvider::~CursorImageProvider()
@@ -151,12 +234,14 @@
 
     // Try some fallbacks
     if (cursorImage->qimage.isNull()) {
-        if (cursorName == "ibeam") {
-            qDebug() << "CursorImageProvider: \"ibeam\" not found, falling back to \"xterm\"";
-            cursorImage = fetchCursorHelper(themeName, "xterm");
-        } else if (cursorName == "xterm") {
-            qDebug() << "CursorImageProvider: \"xterm\" not found, falling back to \"ibeam\"";
-            cursorImage = fetchCursorHelper(themeName, "ibeam");
+        if (m_fallbackNames.contains(cursorName)) {
+            const QStringList &fallbackNames = m_fallbackNames[cursorName];
+            int i = 0;
+            while (cursorImage->qimage.isNull() && i < fallbackNames.count()) {
+                qDebug().nospace() << "CursorImageProvider: "<< cursorName <<" not found, trying " << fallbackNames.at(i);
+                cursorImage = fetchCursorHelper(themeName, fallbackNames.at(i));
+                ++i;
+            }
         }
     }
 
@@ -181,11 +266,26 @@
 
 CursorImage *CursorImageProvider::fetchCursorHelper(const QString &themeName, const QString &cursorName)
 {
-    QMap<QString, CursorImage*> &themeCursors = m_cursors[themeName];
-
-    if (!themeCursors.contains(cursorName)) {
-        themeCursors[cursorName] = new XCursorImage(themeName, cursorName);
-    }
-
-    return themeCursors[cursorName];
+    if (cursorName == QLatin1String("blank")) {
+        return &m_blankCursorImage;
+    } else if (cursorName == QLatin1String("custom")) {
+        return m_customCursorImage.data();
+    } else {
+        QMap<QString, CursorImage*> &themeCursors = m_cursors[themeName];
+
+        if (!themeCursors.contains(cursorName)) {
+            themeCursors[cursorName] = new XCursorImage(themeName, cursorName);
+        }
+
+        return themeCursors[cursorName];
+    }
+}
+
+void CursorImageProvider::setCustomCursor(const QCursor &customCursor)
+{
+    if (customCursor.pixmap().isNull()) {
+        m_customCursorImage.reset();
+    } else {
+        m_customCursorImage.reset(new CustomCursorImage(customCursor));
+    }
 }

=== modified file 'plugins/Cursor/CursorImageProvider.h'
--- plugins/Cursor/CursorImageProvider.h	2015-09-29 13:45:05 +0000
+++ plugins/Cursor/CursorImageProvider.h	2015-11-23 11:13:25 +0000
@@ -47,6 +47,16 @@
     BuiltInCursorImage();
 };
 
+class BlankCursorImage  : public CursorImage {
+public:
+    BlankCursorImage();
+};
+
+class CustomCursorImage  : public CursorImage {
+public:
+    CustomCursorImage(const QCursor &cursor);
+};
+
 class CursorImageProvider : public QQuickImageProvider
 {
 public:
@@ -60,6 +70,8 @@
 
     QPoint hotspot(const QString &themeName, const QString &cursorName);
 
+    void setCustomCursor(const QCursor &customCursor);
+
 private:
     CursorImage *fetchCursor(const QString &cursorThemeAndName);
     CursorImage *fetchCursor(const QString &themeName, const QString &cursorName);
@@ -69,6 +81,10 @@
     QMap<QString, QMap<QString, CursorImage*> > m_cursors;
 
     QScopedPointer<CursorImage> m_builtInCursorImage;
+    BlankCursorImage m_blankCursorImage;
+    QScopedPointer<CursorImage> m_customCursorImage;
+
+    QMap<QString, QStringList> m_fallbackNames;
 
     static CursorImageProvider *m_instance;
 };

=== modified file 'plugins/Cursor/MousePointer.cpp'
--- plugins/Cursor/MousePointer.cpp	2015-11-12 20:39:12 +0000
+++ plugins/Cursor/MousePointer.cpp	2015-11-23 11:13:25 +0000
@@ -124,3 +124,8 @@
         Q_EMIT themeNameChanged(m_themeName);
     }
 }
+
+void MousePointer::setCustomCursor(const QCursor &customCursor)
+{
+    CursorImageProvider::instance()->setCustomCursor(customCursor);
+}

=== modified file 'plugins/Cursor/MousePointer.h'
--- plugins/Cursor/MousePointer.h	2015-10-21 16:16:37 +0000
+++ plugins/Cursor/MousePointer.h	2015-11-23 11:13:25 +0000
@@ -38,6 +38,8 @@
     qreal hotspotX() const override { return m_hotspotX; }
     qreal hotspotY() const override { return m_hotspotY; }
 
+    void setCustomCursor(const QCursor &) override;
+
 public Q_SLOTS:
     void handleMouseEvent(ulong timestamp, QPointF movement, Qt::MouseButtons buttons,
             Qt::KeyboardModifiers modifiers) override;