Merge lp:~dandrader/unity8/consecutiveCustomCursors into lp:unity8
Status: | Merged |
---|---|
Approved by: | Albert Astals Cid |
Approved revision: | 2442 |
Merged at revision: | 2482 |
Proposed branch: | lp:~dandrader/unity8/consecutiveCustomCursors |
Merge into: | lp:unity8 |
Diff against target: |
12 lines (+1/-1) 1 file modified
plugins/Cursor/CursorImageProvider.cpp (+1/-1) |
To merge this branch: | bzr merge lp:~dandrader/unity8/consecutiveCustomCursors |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Unity8 CI Bot | continuous-integration | Needs Fixing | |
Albert Astals Cid (community) | Approve | ||
Review via email: mp+296608@code.launchpad.net |
Commit message
Custom cursor name just have to start with "custom"
That way it's possible to change between consecutive custom
cursors as they will yield different image URLs
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
https:/
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.
To test:
$ bzr branch lp:~dandrader/+junk/animatedDemos
$ cd animatedDemos/
$ qmake && make
$ cd ..
$ qmlscene -I $PWD CursorShapes.qml --desktop_
Scroll to the bottom of the grid, where you will see a boat and a football. Move the cursor between those two cells and see the cursor shape change accordingly. Beware that if you do that many times you will eventually hit bug 1588929!
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable
* If you changed the UI, has there been a design review?
Not applicable
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
* Did CI run pass? If not, please explain why.
Waiting for it to finish before top approving