On 19/01/2017 11:58, Gerry Boland wrote:
> Review: Needs Information
>
> +// Meant to be created with a Loader to circunvent
> typo, "circumvent"
Fixed, thanks.
> +++ qml/Stage/ChildWindow.qml
> Wanted to double-check this with you:
>
> + WindowDecoration {
> + onPressed: root.surface.activate();
> + onPressedChanged: if (d.moveHandler) { d.moveHandler.handlePressedChanged(pressed, pressedButtons, mouseX, mouseY); }
>
> You're listening to both of MouseArea's pressed signals. Since the order is emission isn't guaranteed, you're sure both slots are roughly independent (one doesn't impact the other)? Just in case future Qt's reversed the order..
Again, am copy-pasting from elsewhere (DecoratedWindow.qml in this
case). I think those two are rather independent (order not particularly
important).
On 19/01/2017 11:58, Gerry Boland wrote:
> Review: Needs Information
>
> +// Meant to be created with a Loader to circunvent
> typo, "circumvent"
Fixed, thanks.
> +++ qml/Stage/ ChildWindow. qml activate( ); handlePressedCh anged(pressed, pressedButtons, mouseX, mouseY); }
> Wanted to double-check this with you:
>
> + WindowDecoration {
> + onPressed: root.surface.
> + onPressedChanged: if (d.moveHandler) { d.moveHandler.
>
> You're listening to both of MouseArea's pressed signals. Since the order is emission isn't guaranteed, you're sure both slots are roughly independent (one doesn't impact the other)? Just in case future Qt's reversed the order..
Again, am copy-pasting from elsewhere (DecoratedWindo w.qml in this
case). I think those two are rather independent (order not particularly
important).