Code review comment for lp:~dandrader/unity8/childWindows

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

Just 2 minor nitpicks, otherwise the code looks good (haven't tested yet):

+ Window *TopLevelWindowModel::createWindow(unityapi::MirSurfaceInterface *surface)

-> const qualifier, it's a getter

+ readonly property bool decorated

-> this could be rewritten to be a direct binding, instead of a function

review: Needs Fixing

« Back to merge proposal