Merge lp:~dandrader/unity/phablet_fixSearchHistory into lp:unity/phablet
Proposed by
Daniel d'Andrada
Status: | Merged |
---|---|
Approved by: | Albert Astals Cid |
Approved revision: | no longer in the source branch. |
Merged at revision: | 647 |
Proposed branch: | lp:~dandrader/unity/phablet_fixSearchHistory |
Merge into: | lp:unity/phablet |
Diff against target: |
71 lines (+5/-5) 5 files modified
Dash/DashApps.qml (+1/-0) Dash/DashContent.qml (+1/-2) Dash/DashMusic.qml (+1/-1) Dash/DashPeople.qml (+1/-1) Dash/DashVideos.qml (+1/-1) |
To merge this branch: | bzr merge lp:~dandrader/unity/phablet_fixSearchHistory |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Albert Astals Cid (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Michael Zanetti | Pending | ||
Review via email: mp+161636@code.launchpad.net |
Commit message
Fixes search history in the dash.
It was giving out warnings about non-existing "root" variable.
Also the seach history ended up being per-lens instead of
being the same for all lenses.
Description of the change
Fixes search history in the dash.
It was giving out warnings about non-existing "root" variable.
Also the seach history ended up being per-lens instead of being the same for all lenses.
I started working on a test for it (tst_Dash.qml) but gave up. It would be quite a bit o work to make it properly (loading Dash music, videos, people etc with fake models etc).
To post a comment you must log in.
PASSED: Continuous integration, rev:639 jenkins. qa.ubuntu. com/job/ unity-phablet- ci/803/ s-jenkins: 8080/job/ unity-phablet- qmluitests/ 693 jenkins. qa.ubuntu. com/job/ unity-phablet- raring- armhf-ci/ 679 jenkins. qa.ubuntu. com/job/ unity-phablet- raring- armhf-ci/ 679/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ unity-phablet- raring- i386-ci/ 683 jenkins. qa.ubuntu. com/job/ generic- mediumtests- runner/ 1351
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ unity-phablet- ci/803/ rebuild
http://