Merge lp:~dandrader/unity-api/surfaceItemSizeHints into lp:unity-api

Proposed by Daniel d'Andrada
Status: Superseded
Proposed branch: lp:~dandrader/unity-api/surfaceItemSizeHints
Merge into: lp:unity-api
Diff against target: 99 lines (+56/-1)
3 files modified
debian/changelog (+6/-0)
include/unity/shell/application/CMakeLists.txt (+1/-1)
include/unity/shell/application/MirSurfaceInterface.h (+49/-0)
To merge this branch: bzr merge lp:~dandrader/unity-api/surfaceItemSizeHints
Reviewer Review Type Date Requested Status
Lukáš Tinkl (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+278740@code.launchpad.net

This proposal has been superseded by a proposal from 2016-02-03.

Commit message

MirSurfaceInterface: added size hints

Description of the change

MirSurfaceInterface: added size hints

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

LGTM, approving

review: Approve
202. By Daniel d'Andrada

Add MirSurfaceItem.fillMode
Approved by: Michael Zanetti

203. By Michael Terry

Added ApplicationInfoInterface::exemptFromLifecycle Fixes: #1518764
Approved by: PS Jenkins bot, Daniel d'Andrada

204. By CI Train Bot Account

Releasing 7.104+16.04.20151207-0ubuntu1

205. By Daniel d'Andrada

MirSurfaceInterface: added size hints

Unmerged revisions

205. By Daniel d'Andrada

MirSurfaceInterface: added size hints

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-12-07 16:21:29 +0000
3+++ debian/changelog 2015-12-14 10:04:26 +0000
4@@ -1,3 +1,9 @@
5+unity-api (7.105) UNRELEASED; urgency=medium
6+
7+ * MirSurfaceInterface: added size hints
8+
9+ -- Daniel d'Andrada <daniel.dandrada@canonical.com> Mon, 14 Dec 2015 07:53:47 -0200
10+
11 unity-api (7.104+16.04.20151207-0ubuntu1) xenial; urgency=medium
12
13 [ Daniel d'Andrada ]
14
15=== modified file 'include/unity/shell/application/CMakeLists.txt'
16--- include/unity/shell/application/CMakeLists.txt 2015-12-03 19:32:37 +0000
17+++ include/unity/shell/application/CMakeLists.txt 2015-12-14 10:04:26 +0000
18@@ -7,7 +7,7 @@
19
20 set(UNITY_API_LIB_HDRS ${UNITY_API_LIB_HDRS} ${headers} ${internal_headers} PARENT_SCOPE)
21
22-set(VERSION 12)
23+set(VERSION 13)
24 set(PKGCONFIG_NAME "unity-shell-application")
25 set(PKGCONFIG_DESCRIPTION "Unity shell Application APIs")
26 set(PKGCONFIG_REQUIRES "Qt5Core")
27
28=== modified file 'include/unity/shell/application/MirSurfaceInterface.h'
29--- include/unity/shell/application/MirSurfaceInterface.h 2015-10-26 18:26:01 +0000
30+++ include/unity/shell/application/MirSurfaceInterface.h 2015-12-14 10:04:26 +0000
31@@ -78,6 +78,42 @@
32 Q_PROPERTY(Mir::OrientationAngle orientationAngle READ orientationAngle WRITE setOrientationAngle
33 NOTIFY orientationAngleChanged DESIGNABLE false)
34
35+ /**
36+ * @brief The requested minimum width for the surface
37+ * Zero if not set
38+ */
39+ Q_PROPERTY(int minimumWidth READ minimumWidth NOTIFY minimumWidthChanged)
40+
41+ /**
42+ * @brief The requested minimum height for the surface
43+ * Zero if not set
44+ */
45+ Q_PROPERTY(int minimumHeight READ minimumHeight NOTIFY minimumHeightChanged)
46+
47+ /**
48+ * @brief The requested maximum width for the surface
49+ * Zero if not set
50+ */
51+ Q_PROPERTY(int maximumWidth READ maximumWidth NOTIFY maximumWidthChanged)
52+
53+ /**
54+ * @brief The requested maximum height for the surface
55+ * Zero if not set
56+ */
57+ Q_PROPERTY(int maximumHeight READ maximumHeight NOTIFY maximumHeightChanged)
58+
59+ /**
60+ * @brief The requested width increment for the surface
61+ * Zero if not set
62+ */
63+ Q_PROPERTY(int widthIncrement READ widthIncrement NOTIFY widthIncrementChanged)
64+
65+ /**
66+ * @brief The requested height increment for the surface
67+ * Zero if not set
68+ */
69+ Q_PROPERTY(int heightIncrement READ heightIncrement NOTIFY heightIncrementChanged)
70+
71 public:
72 /// @cond
73 MirSurfaceInterface(QObject *parent = nullptr) : QObject(parent) {}
74@@ -100,6 +136,13 @@
75
76 virtual Mir::OrientationAngle orientationAngle() const = 0;
77 virtual void setOrientationAngle(Mir::OrientationAngle angle) = 0;
78+
79+ virtual int minimumWidth() const = 0;
80+ virtual int minimumHeight() const = 0;
81+ virtual int maximumWidth() const = 0;
82+ virtual int maximumHeight() const = 0;
83+ virtual int widthIncrement() const = 0;
84+ virtual int heightIncrement() const = 0;
85 /// @endcond
86
87 Q_SIGNALS:
88@@ -111,6 +154,12 @@
89 void orientationAngleChanged(Mir::OrientationAngle value);
90 void sizeChanged(const QSize &value);
91 void nameChanged(const QString &name);
92+ void minimumWidthChanged(int value);
93+ void minimumHeightChanged(int value);
94+ void maximumWidthChanged(int value);
95+ void maximumHeightChanged(int value);
96+ void widthIncrementChanged(int value);
97+ void heightIncrementChanged(int value);
98 /// @endcond
99 };
100

Subscribers

People subscribed via source and target branches

to all changes: