Merge lp:~dandrader/unity-api/surfaceItemFillMode into lp:unity-api

Proposed by Daniel d'Andrada
Status: Superseded
Proposed branch: lp:~dandrader/unity-api/surfaceItemFillMode
Merge into: lp:unity-api
Prerequisite: lp:~dandrader/unity-api/mousePointer
Diff against target: 64 lines (+21/-1)
2 files modified
debian/changelog (+7/-1)
include/unity/shell/application/MirSurfaceItemInterface.h (+14/-0)
To merge this branch: bzr merge lp:~dandrader/unity-api/surfaceItemFillMode
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michael Zanetti (community) Approve
Review via email: mp+274446@code.launchpad.net

This proposal supersedes a proposal from 2015-09-18.

This proposal has been superseded by a proposal from 2015-11-30.

Commit message

Add MirSurfaceItem.fillMode

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

debian/changelog merge is broken?

Revision history for this message
Daniel d'Andrada (dandrader) wrote : Posted in a previous version of this proposal

On 14/09/15 04:49, Albert Astals Cid wrote:
> debian/changelog merge is broken?

Merged trunk again. That weird diff should go away.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote : Posted in a previous version of this proposal

ack, lgtm.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

still good

review: Approve
190. By Daniel d'Andrada

Merge trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

190. By Daniel d'Andrada

Merge trunk

189. By Daniel d'Andrada

Merge mousePointer again

188. By Daniel d'Andrada

Merge mousePointer

187. By Daniel d'Andrada

Merge trunk-15.04

[ Michal Sawicz ]
* No change rebuild to resync vivid+overlay and wily
[ CI Train Bot ]
* No-change rebuild.

186. By Daniel d'Andrada

Add MirSurfaceItem.fillMode

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-11-02 11:23:43 +0000
3+++ debian/changelog 2015-11-06 16:31:15 +0000
4@@ -1,7 +1,13 @@
5+unity-api (7.103) UNRELEASED; urgency=medium
6+
7+ * Add MirSurfaceItem.fillMode
8+
9+ -- Daniel d'Andrada <daniel.dandrada@canonical.com> Fri, 11 Sep 2015 08:54:29 -0300
10+
11 unity-api (7.102+16.04.20151102-0ubuntu1) xenial; urgency=medium
12
13 [ Nick Dedekind ]
14- * Added visibility to surface interface.
15+ * Added visibility to surface interface.
16
17 [ Michael Terry ]
18 * Add isTouchApp to ApplicationInfoInterface
19
20=== modified file 'include/unity/shell/application/MirSurfaceItemInterface.h'
21--- include/unity/shell/application/MirSurfaceItemInterface.h 2015-09-29 11:34:31 +0000
22+++ include/unity/shell/application/MirSurfaceItemInterface.h 2015-11-06 16:31:15 +0000
23@@ -41,6 +41,8 @@
24 {
25 Q_OBJECT
26
27+ Q_ENUMS(FillMode)
28+
29 /**
30 * @brief The surface to be displayed
31 */
32@@ -103,7 +105,15 @@
33 WRITE setSurfaceHeight
34 NOTIFY surfaceHeightChanged)
35
36+ Q_PROPERTY(FillMode fillMode READ fillMode WRITE setFillMode NOTIFY fillModeChanged)
37+
38 public:
39+
40+ enum FillMode {
41+ Stretch,
42+ PadOrCrop
43+ };
44+
45 /// @cond
46 MirSurfaceItemInterface(QQuickItem *parent = 0) : QQuickItem(parent) {}
47 virtual ~MirSurfaceItemInterface() {}
48@@ -129,6 +139,9 @@
49
50 virtual int surfaceHeight() const = 0;
51 virtual void setSurfaceHeight(int value) = 0;
52+
53+ virtual FillMode fillMode() const = 0;
54+ virtual void setFillMode(FillMode value) = 0;
55 /// @endcond
56
57 Q_SIGNALS:
58@@ -142,6 +155,7 @@
59 void surfaceWidthChanged(int value);
60 void surfaceHeightChanged(int value);
61 void nameChanged(const QString &name);
62+ void fillModeChanged(FillMode value);
63 /// @endcond
64 };
65

Subscribers

People subscribed via source and target branches

to all changes: