Merge lp:~dandrader/unity-api/surfaceAllowClientResize into lp:unity-api

Proposed by Daniel d'Andrada on 2017-03-13
Status: Merged
Approved by: Gerry Boland on 2017-03-13
Approved revision: 277
Merged at revision: 279
Proposed branch: lp:~dandrader/unity-api/surfaceAllowClientResize
Merge into: lp:unity-api
Prerequisite: lp:~mzanetti/unity-api/private-quicklist-entries
Diff against target: 65 lines (+16/-2)
3 files modified
debian/changelog (+4/-1)
include/unity/shell/application/CMakeLists.txt (+1/-1)
include/unity/shell/application/MirSurfaceInterface.h (+11/-0)
To merge this branch: bzr merge lp:~dandrader/unity-api/surfaceAllowClientResize
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration 2017-03-13 Approve on 2017-03-13
Gerry Boland 2017-03-13 Approve on 2017-03-13
Review via email: mp+319730@code.launchpad.net

This proposal supersedes a proposal from 2017-03-07.

Commit message

MirSurfaceInterface::allowClientResize - specify if client can resize its windows

To post a comment you must log in.
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:276
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/149/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4343
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4371
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4205
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4205/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4205
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4205/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4205
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4205/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4205
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4205/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4205
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4205/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4205
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4205/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/149/rebuild

review: Approve (continuous-integration)
Gerry Boland (gerboland) : Posted in a previous version of this proposal
review: Approve
Gerry Boland (gerboland) wrote :

Ok.

review: Approve
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:277
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/151/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4422
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4450
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4283
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4283/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4283
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4283/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4283
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4283/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4283
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4283/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4283
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4283/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4283
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4283/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/151/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2017-03-13 17:57:02 +0000
3+++ debian/changelog 2017-03-13 17:57:03 +0000
4@@ -1,8 +1,11 @@
5-unity-api (8.5) zesty; urgency=medium
6+unity-api (8.5) UNRELEASED; urgency=medium
7
8 [ Michael Zanetti ]
9 * Add RoleIsPrivate to launcher's quicklist entries
10
11+ [ Daniel d'Andrada ]
12+ * MirSurfaceInterface::allowClientResize
13+
14 -- Michael Zanetti <michael.zanetti@canonical.com> Fri, 24 Feb 2017 13:57:12 +0000
15
16 unity-api (8.4+17.04.20170223-0ubuntu1) zesty; urgency=medium
17
18=== modified file 'include/unity/shell/application/CMakeLists.txt'
19--- include/unity/shell/application/CMakeLists.txt 2017-01-26 11:07:35 +0000
20+++ include/unity/shell/application/CMakeLists.txt 2017-03-13 17:57:03 +0000
21@@ -7,7 +7,7 @@
22
23 set(UNITY_API_LIB_HDRS ${UNITY_API_LIB_HDRS} ${headers} ${internal_headers} PARENT_SCOPE)
24
25-set(VERSION 26)
26+set(VERSION 27)
27 set(PKGCONFIG_NAME "unity-shell-application")
28 set(PKGCONFIG_DESCRIPTION "Unity shell Application APIs")
29 set(PKGCONFIG_REQUIRES "Qt5Core")
30
31=== modified file 'include/unity/shell/application/MirSurfaceInterface.h'
32--- include/unity/shell/application/MirSurfaceInterface.h 2017-01-26 11:07:35 +0000
33+++ include/unity/shell/application/MirSurfaceInterface.h 2017-03-13 17:57:03 +0000
34@@ -165,6 +165,13 @@
35 Q_PROPERTY(bool confinesMousePointer READ confinesMousePointer NOTIFY confinesMousePointerChanged)
36
37 /**
38+ * @brief Whether to comply to resize requests coming from the client side
39+ *
40+ * It's true by default
41+ */
42+ Q_PROPERTY(bool allowClientResize READ allowClientResize WRITE setAllowClientResize NOTIFY allowClientResizeChanged)
43+
44+ /**
45 * @brief The parent MirSurface or null if this is a top-level surface
46 */
47 Q_PROPERTY(MirSurfaceInterface* parentSurface READ parentSurface CONSTANT)
48@@ -221,6 +228,9 @@
49
50 virtual bool confinesMousePointer() const = 0;
51
52+ virtual bool allowClientResize() const = 0;
53+ virtual void setAllowClientResize(bool) = 0;
54+
55 virtual QPoint requestedPosition() const = 0;
56 virtual void setRequestedPosition(const QPoint &) = 0;
57
58@@ -270,6 +280,7 @@
59 void focusedChanged(bool value);
60 void inputBoundsChanged(QRect value);
61 void confinesMousePointerChanged(bool value);
62+ void allowClientResizeChanged(bool value);
63 /// @endcond
64
65 /**

Subscribers

People subscribed via source and target branches

to all changes: