Unity API

Merge lp:~dandrader/unity-api/mirSurfaceInputBounds into lp:unity-api

  1. mirSurfaceInputBounds
  2. Merge into trunk
Proposed by Daniel d'Andrada
Status: Merged
Approved by: Gerry Boland
Approved revision: 239
Merged at revision: 239
Proposed branch: lp:~dandrader/unity-api/mirSurfaceInputBounds
Merge into: lp:unity-api
Diff against target: 69 lines (+18/-1)
3 files modified
debian/changelog (+6/-0)
include/unity/shell/application/CMakeLists.txt (+1/-1)
include/unity/shell/application/MirSurfaceInterface.h (+11/-0)
To merge this branch: bzr merge lp:~dandrader/unity-api/mirSurfaceInputBounds
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Approve
Gerry Boland (community) Approve
Michał Sawicz Needs Fixing
Review via email: mp+296985@code.launchpad.net

Commit message

MirSurfaceInterface: add inputBounds property

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:236
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/87/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/1938
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1964
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1899
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1899
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/1899
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1890
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1890/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1890
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1890/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1890
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1890/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1890
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1890/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1890
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1890/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1890
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1890/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1890
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1890/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1890
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1890/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1890
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1890/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/87/rebuild

review: Approve (continuous-integration)
lp:~dandrader/unity-api/mirSurfaceInputBounds updated
236. By CI Train Bot Account

Add ApplicationInfoInterface::surfaceCount property

237. By CI Train Bot Account

Drop Launchermodel::setAlerting, it's not needed

238. By CI Train Bot Account

Releasing 7.115+16.10.20160614-0ubuntu1

Revision history for this message
Michał Sawicz (saviq) wrote :

Text conflict in debian/changelog
1 conflicts encountered.

review: Needs Fixing
lp:~dandrader/unity-api/mirSurfaceInputBounds updated
239. By Daniel d'Andrada

MirSurfaceInterface: add inputBounds property

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

On 18/06/2016 19:45, Michał Sawicz wrote:
> Review: Needs Fixing
>
> Text conflict in debian/changelog
> 1 conflicts encountered.

Fixed.

Revision history for this message
Gerry Boland (gerboland) :
review: Approve
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:239
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/90/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2079
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2107
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2018
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2018
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2018
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2009
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2009/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2009
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2009/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2009
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2009/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2009
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2009/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2009
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2009/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2009
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2009/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2009
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2009/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2009
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2009/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2009
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2009/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/90/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2016-06-14 08:34:16 +0000
3+++ debian/changelog 2016-06-20 14:06:35 +0000
4@@ -1,3 +1,9 @@
5+unity-api (7.116) UNRELEASED; urgency=medium
6+
7+ * MirSurfaceInterface: add inputBounds property
8+
9+ -- Daniel d'Andrada <daniel.dandrada@canonical.com> Mon, 20 Jun 2016 11:04:39 -0300
10+
11 unity-api (7.115+16.10.20160614-0ubuntu1) yakkety; urgency=medium
12
13 [ Michael Zanetti ]
14
15=== modified file 'include/unity/shell/application/CMakeLists.txt'
16--- include/unity/shell/application/CMakeLists.txt 2016-06-03 11:20:04 +0000
17+++ include/unity/shell/application/CMakeLists.txt 2016-06-20 14:06:35 +0000
18@@ -7,7 +7,7 @@
19
20 set(UNITY_API_LIB_HDRS ${UNITY_API_LIB_HDRS} ${headers} ${internal_headers} PARENT_SCOPE)
21
22-set(VERSION 18)
23+set(VERSION 19)
24 set(PKGCONFIG_NAME "unity-shell-application")
25 set(PKGCONFIG_DESCRIPTION "Unity shell Application APIs")
26 set(PKGCONFIG_REQUIRES "Qt5Core")
27
28=== modified file 'include/unity/shell/application/MirSurfaceInterface.h'
29--- include/unity/shell/application/MirSurfaceInterface.h 2016-05-17 12:55:00 +0000
30+++ include/unity/shell/application/MirSurfaceInterface.h 2016-06-20 14:06:35 +0000
31@@ -18,6 +18,7 @@
32 #define UNITY_SHELL_APPLICATION_MIRSURFACE_H
33
34 #include <QObject>
35+#include <QRect>
36 #include <QSize>
37
38 #include "Mir.h"
39@@ -134,6 +135,13 @@
40 */
41 Q_PROPERTY(bool focused READ focused NOTIFY focusedChanged)
42
43+ /**
44+ * @brief Input bounds
45+ *
46+ * Bounding rectangle of the surface region that accepts input.
47+ */
48+ Q_PROPERTY(QRect inputBounds READ inputBounds NOTIFY inputBoundsChanged)
49+
50 public:
51 /// @cond
52 MirSurfaceInterface(QObject *parent = nullptr) : QObject(parent) {}
53@@ -170,6 +178,8 @@
54 virtual Mir::ShellChrome shellChrome() const = 0;
55
56 virtual bool focused() const = 0;
57+
58+ virtual QRect inputBounds() const = 0;
59 /// @endcond
60
61 /**
62@@ -208,6 +218,7 @@
63 void shellChromeChanged(Mir::ShellChrome value);
64 void keymapChanged(const QString &value);
65 void focusedChanged(bool value);
66+ void inputBoundsChanged(QRect value);
67 /// @endcond
68
69 /**

Subscribers

People subscribed via source and target branches

to all changes: