Merge lp:~dandrader/ubuntu/quantal/compiz/enable_resize_vertically into lp:ubuntu/quantal/compiz

Proposed by Daniel d'Andrada on 2012-08-27
Status: Merged
Merged at revision: 3286
Proposed branch: lp:~dandrader/ubuntu/quantal/compiz/enable_resize_vertically
Merge into: lp:ubuntu/quantal/compiz
Diff against target: 28 lines (+9/-2)
1 file modified
debian/patches/ubuntu-config.patch (+9/-2)
To merge this branch: bzr merge lp:~dandrader/ubuntu/quantal/compiz/enable_resize_vertically
Reviewer Review Type Date Requested Status
Daniel van Vugt (community) Approve on 2012-08-31
Ubuntu branches 2012-08-27 Pending
Review via email: mp+121479@code.launchpad.net

Commit Message

Enable vertical maximization on resize plugin by default.

As per Unity UI specification

Description of the Change

Enable vertical maximization on resize plugin by default.

So that it follows Unity Touch specification [1], by John Lea.

In section "5.2 User resizes a window", subsection "3.a Variation - User vertically maximizes window"

Document was intended for 11.04 but it's still valid for 12.10. That feature (vertical resize) has landed on compiz just about a week ago.

[1] - https://docs.google.com/a/canonical.com/document/d/1XnouyB1d4rTG_33xdexpiiBIacimhmEAeENSEQ1erpc/edit#

To post a comment you must log in.
Daniel van Vugt (vanvugt) wrote :

Looks good to me. false becomes true.

FYI, as this is an ubuntu branch it should usually be reviewed and approved by distro, I think.

review: Approve
Daniel van Vugt (vanvugt) wrote :

And for that reason, I do not have permissions to change the Status to Approved.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/patches/ubuntu-config.patch'
2--- debian/patches/ubuntu-config.patch 2012-07-27 12:50:13 +0000
3+++ debian/patches/ubuntu-config.patch 2012-08-27 19:26:19 +0000
4@@ -392,7 +392,14 @@
5 <min>0</min>
6 <max>3</max>
7 <desc>
8-@@ -57,9 +57,9 @@
9+@@ -56,15 +56,15 @@
10+ <option name="maximize_vertically" type="bool">
11+ <short>Maximize Vertically if screen edge hit</short>
12+ <long>Maximizes the window vertically if the top or bottom screen edge is hit while resizing</long>
13+- <default>false</default>
14++ <default>true</default>
15+ </option>
16+ <option name="border_color" type="color">
17 <_short>Border Color</_short>
18 <_long>Border color used for outline and rectangle resize modes</_long>
19 <default>
20@@ -405,7 +412,7 @@
21 <alpha>0x9f9f</alpha>
22 </default>
23 </option>
24-@@ -67,10 +67,10 @@
25+@@ -72,10 +72,10 @@
26 <_short>Fill Color</_short>
27 <_long>Fill color used for rectangle resize mode</_long>
28 <default>

Subscribers

People subscribed via source and target branches