Merge lp:~dandrader/ubuntu-ui-toolkit/dontReparentPopup into lp:ubuntu-ui-toolkit

[Daniel d'Andrada]

Added PopupBase.reparentToRootItem property

Some applications need Popups to behave as regular items and therefore
remain as children of their original parents (ie, no reparenting
to scene's root item behind the scenes).

This is the case when an application does its own UI rotation (which includes
any dialogs it might be displaying) where Popups should follow its parent
transformations (rotations) and resizes or when it doesn't want the Popup to cover
its entire scene.

This is needed by unity8 for the "shell rotation" feature (ie shell does all the rotation work instead of apps rotating themselves). unity8's dialogs (like the power dialog when you long press the power button) should follow its parent item rotation and size, as one would expect, and not be sneakily reparented to the scene root item, in which case the shell UI would be rotated but its dialog would not.

PPA with shell rotation:
https://launchpad.net/~unity-team/+archive/ubuntu/demo-stuff

And this is how unity8 is using Dialogs:
http://bazaar.launchpad.net/~unity-team/unity8/shellRotation/view/head:/qml/Components/Dialogs.qml

[lp:~dandrader/ubuntu-ui-toolkit/dontReparentPopup]

1338. By Daniel d'Andrada on 2014-11-20

Added PopupBase.reparentToRootItem property

Some applications need Popups to behave as regular items and therefore
remain as children of their original parents (ie, no reparenting
to scene's root item behind the scenes).

This is the case when an application does its own UI rotation (which includes
any dialogs it might be displaying) where Popups should follow its parent
transformations (rotations) and resizes or when it doesn't want the Popup to cover
its entire scene.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1131
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/2178/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/288
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/199
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-vivid-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-vivid-armhf-ci/2
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-vivid-armhf-ci/2/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/262
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/288
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/288/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16034
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/176
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/203
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/203/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-toolkit-ci/2178/rebuild

review: Needs Fixing (continuous-integration)

[lp:~dandrader/ubuntu-ui-toolkit/dontReparentPopup]

1339. By Daniel d'Andrada on 2014-11-27

Make it a hidden property

1340. By Daniel d'Andrada on 2014-11-27

Remove it from components.api

1341. By Daniel d'Andrada on 2014-12-03

merge staging

Unmerged revisions

=== modified file 'components.api'
--- components.api	2014-10-01 21:20:06 +0000
+++ components.api	2014-11-20 07:34:01 +0000
@@ -377,6 +377,7 @@
 OrientationHelper
     property Item dismissArea
     property bool grabDismissAreaEvents
+    property bool reparentToRootItem
     property PropertyAnimation fadingAnimation
     function show()
     function hide()

=== modified file 'modules/Ubuntu/Components/Popups/PopupBase.qml'
--- modules/Ubuntu/Components/Popups/PopupBase.qml	2014-08-22 15:02:28 +0000
+++ modules/Ubuntu/Components/Popups/PopupBase.qml	2014-11-20 07:34:01 +0000
@@ -42,6 +42,11 @@
     property bool grabDismissAreaEvents: true
 
     /*!
+        Whether it should reparent itself to the scene's root item. The default is true.
+     */
+    property bool reparentToRootItem: true
+
+    /*!
       \internal
       FIXME: publish this property once agreed
       */
@@ -67,11 +72,15 @@
       PopupUtils.open() to do it automatically.
     */
     function show() {
-        if (!dismissArea)
-            dismissArea = stateWrapper.rootItem
+        if (reparentToRootItem) {
+            parent = stateWrapper.rootItem;
+        }
+
+        if (!dismissArea) {
+            dismissArea = parent
+        }
 
         // Without setting the parent, mapFromItem() breaks in internalPopupUtils.
-        parent = stateWrapper.rootItem;
         stateWrapper.state = 'opened';
     }