Merge lp:~dandrader/ubuntu-settings-components/deprecation-warnings into lp:~registry/ubuntu-settings-components/trunk
| Status: | Merged |
|---|---|
| Approved by: | Andrea Cimitan on 2015-06-23 |
| Approved revision: | 92 |
| Merged at revision: | 96 |
| Proposed branch: | lp:~dandrader/ubuntu-settings-components/deprecation-warnings |
| Merge into: | lp:~registry/ubuntu-settings-components/trunk |
| Diff against target: |
572 lines (+53/-53) 31 files modified
examples/MessageComponents.qml (+1/-1) examples/OtherComponents.qml (+1/-1) examples/SettingsComponents.qml (+2/-2) examples/TransferComponents.qml (+1/-1) plugins/Ubuntu/Settings/Components/ActionTextField.qml (+1/-1) plugins/Ubuntu/Settings/Components/Calendar.qml (+3/-3) plugins/Ubuntu/Settings/Components/MessageHeader.qml (+3/-3) plugins/Ubuntu/Settings/Components/QuickReply.qml (+1/-1) plugins/Ubuntu/Settings/Components/UbuntuShapeForItem.qml (+1/-1) plugins/Ubuntu/Settings/Menus/AccessPointMenu.qml (+4/-4) plugins/Ubuntu/Settings/Menus/ButtonMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/CalendarMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/CheckableMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/EventMenu.qml (+2/-2) plugins/Ubuntu/Settings/Menus/GroupedMessageMenu.qml (+3/-3) plugins/Ubuntu/Settings/Menus/MediaPlayerMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/PlaybackItemMenu.qml (+7/-7) plugins/Ubuntu/Settings/Menus/ProgressBarMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/ProgressValueMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/SectionMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/SimpleMessageMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/SliderMenu.qml (+3/-3) plugins/Ubuntu/Settings/Menus/SnapDecisionMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/StandardMenu.qml (+2/-2) plugins/Ubuntu/Settings/Menus/SwitchMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/TextMessageMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/TimeZoneMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/TransferMenu.qml (+2/-2) plugins/Ubuntu/Settings/Menus/UserSessionMenu.qml (+2/-2) tests/qmltests/Components/tst_ServerPropertySynchroniser.qml (+1/-1) tests/utils/modules/Ubuntu/Test/UbuntuTestCase.qml (+1/-1) |
| To merge this branch: | bzr merge lp:~dandrader/ubuntu-settings-components/deprecation-warnings |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Zanetti (community) | Needs Information on 2015-06-23 | ||
| Andrea Cimitan (community) | 2015-06-17 | Approve on 2015-06-23 | |
| PS Jenkins bot (community) | continuous-integration | Approve on 2015-06-23 | |
|
Review via email:
|
|||
Commit Message
Avoid creating a deluge of deprecation warnings
unity8 log is getting filled with the following warning:
"""
<Unknown File>: QML UCDeprecatedTheme: Theme.palette is deprecated. Use ThemeSettings instead.
"""
| Andrea Cimitan (cimi) wrote : | # |
Can we move everything to 1.3 at this point and test it works fine?
- 91. By Daniel d'Andrada on 2015-06-18
-
Moving everything to Ubuntu.Components 1.3
| Daniel d'Andrada (dandrader) wrote : | # |
> Can we move everything to 1.3 at this point and test it works fine?
Done. Tested on the phone and all seems fine.
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:91
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| Andrea Cimitan (cimi) wrote : | # |
There's just a minor "Theme.name" in examples/
- 92. By Daniel d'Andrada on 2015-06-23
-
s/Theme.
name/theme. name
| Daniel d'Andrada (dandrader) wrote : | # |
On 22/06/15 07:32, Andrea Cimitan wrote:
> Review: Needs Fixing
>
> There's just a minor "Theme.name" in examples/
Fixed.
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:92
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| Andrea Cimitan (cimi) wrote : | # |
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
* Did CI run pass? If not, please explain why.
Yes
| Michael Zanetti (mzanetti) wrote : | # |
The SDK guys said that 1.3 is not stable API yet. I'm afraid we block them of changing the API when we're already using it.
| Nick Dedekind (nick-dedekind) wrote : | # |
perhaps we shouldn't approve the branch until this happens?

PASSED: Continuous integration, rev:90 jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- ci/113/ jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- vivid-amd64- ci/20 jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- vivid-armhf- ci/20 jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- vivid-armhf- ci/20/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- settings- components- ci/113/ rebuild
http://