Merge lp:~dandrader/qtubuntu/qtToolIsMirSatellite into lp:qtubuntu

[Daniel d'Andrada]

Qt::Tool == mir_window_type_satellite

Proper support for windows of Qt::Tool type.

For Tool windows to work properly support on the unity8 side is also needed

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:379
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/211/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4534
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4562
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4389
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4389/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4389
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4389/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4389
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4389/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4389
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4389/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4389
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4389/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4389
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4389/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/211/rebuild

review: Approve (continuous-integration)

[Albert Astals Cid (aacid)]

Looks good :)

review: Approve

=== modified file 'src/ubuntumirclient/qmirclientwindow.cpp'
--- src/ubuntumirclient/qmirclientwindow.cpp	2017-03-08 11:58:41 +0000
+++ src/ubuntumirclient/qmirclientwindow.cpp	2017-03-17 13:21:50 +0000
@@ -174,8 +174,9 @@
     case Qt::Drawer:
         return mir_window_type_utility;
     case Qt::Popup:
+        return mir_window_type_menu;
     case Qt::Tool:
-        return mir_window_type_menu;
+        return mir_window_type_satellite;
     case Qt::ToolTip:
         return mir_window_type_tip;
     case Qt::SplashScreen:
@@ -262,6 +263,15 @@
     case mir_window_type_inputmethod:
         spec = Spec{mir_create_input_method_window_spec(connection, width, height)};
         break;
+    case mir_window_type_satellite:
+        // There's no helper function for satellite windows. Guess they're not very popular
+        spec = Spec{mir_create_window_spec(connection)};
+        mir_window_spec_set_type(spec.get(), mir_window_type_satellite);
+        mir_window_spec_set_buffer_usage(spec.get(), mir_buffer_usage_hardware);
+        mir_window_spec_set_parent(spec.get(), parent);
+        mir_window_spec_set_width(spec.get(), width);
+        mir_window_spec_set_height(spec.get(), height);
+        break;
     default:
         spec = Spec{mir_create_normal_window_spec(connection, width, height)};
         break;